From patchwork Thu Feb 28 20:01:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 668 Return-Path: Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C6E87610B6 for ; Thu, 28 Feb 2019 21:01:28 +0100 (CET) Received: from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101]) (Authenticated sender: jacopo@jmondi.org) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 4FC6C100006; Thu, 28 Feb 2019 20:01:28 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Thu, 28 Feb 2019 21:01:42 +0100 Message-Id: <20190228200151.2948-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 0/8] v4l2_(sub)dev: improvements and tests X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2019 20:01:28 -0000 One more round, one more (trivial) patch: 6/9 Most of what is here is reviewed. Particular attention to format enumeration which has been reworked, and to META_CAPTURE support, on which I had one more comment on v3. The rest should be smooth. Thanks j Jacopo Mondi (9): libcamera: v4l2_subdevice: Store media entity libcamera: v4l2_subdevice: Inherit from Loggable libcamera: v4l2_subdevice: Implement ENUM_FRAME_SIZES libcamera: v4l2_device: Add support for META_CAPTURE devices libcamera: v4l2_subdevice: Update crop/compose rectangle libcamera: v4l2_device: Expose the device node path test: v4l2_subdevice: Add format handling test test: v4l2_subdevice: Add ListFormat test test: v4l2_device: Add format handling test src/libcamera/geometry.cpp | 34 ++++++ src/libcamera/include/geometry.h | 12 ++ src/libcamera/include/v4l2_device.h | 5 + src/libcamera/include/v4l2_subdevice.h | 25 +++- src/libcamera/v4l2_device.cpp | 44 +++++--- src/libcamera/v4l2_subdevice.cpp | 119 ++++++++++++++++++-- test/meson.build | 1 + test/v4l2_device/formats.cpp | 53 +++++++++ test/v4l2_device/meson.build | 1 + test/v4l2_subdevice/list_formats.cpp | 85 ++++++++++++++ test/v4l2_subdevice/meson.build | 11 ++ test/v4l2_subdevice/test_formats.cpp | 78 +++++++++++++ test/v4l2_subdevice/v4l2_subdevice_test.cpp | 89 +++++++++++++++ test/v4l2_subdevice/v4l2_subdevice_test.h | 36 ++++++ 14 files changed, 563 insertions(+), 30 deletions(-) create mode 100644 test/v4l2_device/formats.cpp create mode 100644 test/v4l2_subdevice/list_formats.cpp create mode 100644 test/v4l2_subdevice/meson.build create mode 100644 test/v4l2_subdevice/test_formats.cpp create mode 100644 test/v4l2_subdevice/v4l2_subdevice_test.cpp create mode 100644 test/v4l2_subdevice/v4l2_subdevice_test.h --- 2.20.1