From patchwork Mon Jun 22 13:55:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 4108 Return-Path: Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F154603BD for ; Mon, 22 Jun 2020 15:55:59 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="nb21Nx+c"; dkim-atps=neutral Received: by mail-wr1-x42a.google.com with SMTP id q2so14337924wrv.8 for ; Mon, 22 Jun 2020 06:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=J7lV/S7fH1hulSlzlxsE5oPUNUfHiguBLz4lMDvsFU0=; b=nb21Nx+cICTDZrIPfuE8/Hj4fk85CWHJYSzFuDz/AknXkbygitEHQXKXlwfFtUqvMq oKVWgrMWBo0gUSWso+of4pIkxWdWPvCkL8zuLtA089Eh8I93BYOIwqVuXPDOPgYSKhbb Q4GEIvj4TnIiwJsyvnfMiGi8g9b1FFj1vH4zqqhGEOj/PaO1xBszR3GTNLf76amuZCiW FrWF7Zs2U+0aJh8qCybdOWFJzDgjA2syjxiMK+9lACYwA2mN9iloeRJlKK9gObI7+lmf CAf7/vPsE02AagQSusLw22p+DQlE6l0FYbdk0d0JD4LoBq5p4uhu7hYaKBf+XIlK705Y WYEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=J7lV/S7fH1hulSlzlxsE5oPUNUfHiguBLz4lMDvsFU0=; b=fpL2XKmrYFLqEAftHXHSW8EtmP8b1AZqfFqeqAFcNZRbBX3AmuH4bbGPNTrHMsNKKY ShLLc+jXYWeeOIQlGyZNaApPiTtNVfUPAEwoDf37w/6TCTtNYoQwZOrXKuRkslkYlngz HMtWfqyGtTWDuQOMh9b9Jatw1fGyimaJOFl/twkAYm7dyBNW9XQG7MLDqq8xENr5BZI2 s3HNxTTmjMHR+1E3zorh06zMURNSfX1xu6Th78+aI3F5WTEbNl7EoT6/VTeb53VaBDN/ utKTTy6dtKOBb+7rTncUZJqx/jqz1+PLQOZX686viiOHbmE05Sa1AK5lU0+NRz7waWrd OerQ== X-Gm-Message-State: AOAM531dH4FLDlXZtLXF5NiwSrQCHIgWhBOGOLlWnO0QdAPsHRE3E43r bz5b0zNcoEESD9veKdsQwKW6D6palYU= X-Google-Smtp-Source: ABdhPJyHWOMeYtAQnJsS9EJdaTT/JZwgzexmZbbVy70WOjCm+7rNXfKuNDc235QVsqbp06xbXZfSmQ== X-Received: by 2002:a5d:5381:: with SMTP id d1mr1908371wrv.177.1592834158567; Mon, 22 Jun 2020 06:55:58 -0700 (PDT) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id c201sm12742903wmd.4.2020.06.22.06.55.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2020 06:55:58 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Mon, 22 Jun 2020 14:55:46 +0100 Message-Id: <20200622135550.10788-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/4] libcamera sharpness strength control X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2020 13:55:59 -0000 Hi everyone Here's version 2 of this patch set, I think it address the review comments - so thanks for those! As part of doing that, I've squeezed in a small new patch at number 2 which turns the "mode_factor" into a regular double; there's no need for it to be "atomic". Thanks and best regards David David Plowman (4): libcamera: add a sharpness strength control libcamera: ipa: raspberrypi: make sharpening mode_factor an ordinary double libcamera: ipa: raspberrypi: add sharpness strength control to Raspberry Pi IPAs libcamera: ipa: raspberrypi: plumb the libcamera sharpness control through to the Raspberry Pi implementation include/libcamera/ipa/raspberrypi.h | 1 + .../raspberrypi/controller/rpi/sharpen.cpp | 31 +++++++++++++++---- .../raspberrypi/controller/rpi/sharpen.hpp | 8 +++-- .../controller/sharpen_algorithm.hpp | 21 +++++++++++++ .../raspberrypi/controller/sharpen_status.h | 2 ++ src/ipa/raspberrypi/raspberrypi.cpp | 12 +++++++ src/libcamera/control_ids.yaml | 12 +++++++ 7 files changed, 78 insertions(+), 9 deletions(-) create mode 100644 src/ipa/raspberrypi/controller/sharpen_algorithm.hpp