From patchwork Tue Jun 2 01:38:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 3889 Return-Path: Received: from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net [195.74.38.228]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 34BBA603C8 for ; Tue, 2 Jun 2020 03:39:28 +0200 (CEST) X-Halon-ID: d060fa1b-a471-11ea-a73e-0050569116f7 Authorized-sender: niklas@soderlund.pp.se Received: from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de [79.202.35.146]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA id d060fa1b-a471-11ea-a73e-0050569116f7; Tue, 02 Jun 2020 03:38:58 +0200 (CEST) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: libcamera-devel@lists.libcamera.org Date: Tue, 2 Jun 2020 03:38:59 +0200 Message-Id: <20200602013909.3170593-1-niklas.soderlund@ragnatech.se> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 00/10] libcamera: ipu3: Allow zero-copy RAW stream X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2020 01:39:28 -0000 Hi, This series removes the need to copy the buffer when capturing RAW buffers from the IPU3 pipeline. This is made possible by allocating an internal queue of buffers in the pipeline handler which is used when the application does not provide an buffer for the RAW stream. The first 9 out of 10 patches in this series cleans up the IPU3 pipeline handler a but and breaks out the CIO2Device helper class into separate cio.{cpp,h} files. The CIO2Device is also reworked to make its interface more strict, making it easier to grasp what is going in in ipu3.cpp. I plan to post similar patches breaking out the ImgU on top of this series. There is on issue with this series. If the camera is configured to supply the application with more then one stream and one of them is a RAW stream. Then the sequence number of the RAW buffers in all requests are set to 0 before the request completes. This is due to that if two or more streams are used the RAW buffer is always queued to the ImgU input to serve as input to the vf and/or output buffers. When the RAW buffers is dequeued from the ImgU input device the kernel sets the sequence number to zero. I believe this is a kernel issue and should be fixed there. As the RPi pipeline handler already started using the copy approach we can not yet rename to role nor remove the copyFrom() helper. I aim to work on that once the approach taken in this series is agreed upon. Niklas Söderlund (10): libcamera: stream: Initialize stride and bufferCount libcamera: ipu3: Remove id from camera names libcamera: ipu3: Fold mediaBusToFormat() into only caller libcamera: ipu3: Breakout stream assignment to new function libcamera: ipu3: Calculate number of buffers for ImgU libcamera: ipu3: cio2: Move the CIO2Device class to separate files libcamera: ipu3: cio2: Add function to generate configuration libcamera: ipu3: cio2: Make the V4L2 devices private libcamera: ipu3: cio2: Hide buffer allocation and freeing from users libcamera: ipu3: Allow zero-copy RAW stream capture src/libcamera/pipeline/ipu3/cio2.cpp | 292 ++++++++++++++ src/libcamera/pipeline/ipu3/cio2.h | 76 ++++ src/libcamera/pipeline/ipu3/ipu3.cpp | 500 +++++------------------- src/libcamera/pipeline/ipu3/meson.build | 1 + src/libcamera/stream.cpp | 5 +- 5 files changed, 478 insertions(+), 396 deletions(-) create mode 100644 src/libcamera/pipeline/ipu3/cio2.cpp create mode 100644 src/libcamera/pipeline/ipu3/cio2.h