From patchwork Mon May 11 10:01:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 3747 Return-Path: Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1DE75603E2 for ; Mon, 11 May 2020 12:01:56 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="lPwCfbZY"; dkim-atps=neutral Received: by mail-wr1-x42c.google.com with SMTP id x17so10158761wrt.5 for ; Mon, 11 May 2020 03:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id; bh=V6K1LMRgF7ULUJPOXdy+1S6acPNQ9pvOKzffHzC8PcA=; b=lPwCfbZYE+lBQUs8/aNF/HEFQDInSz0Tql1SzjmINzRTLfK5naBzwzmcP3DNtz4v5n 4ChoCSMAjk6DBYjy0F0PtwGWZds9XgttgAx6TY78ddCpECbLnbCRKryikCrPdN0fk+It dNmr6hjttn8sTwz58cADQUBkEc8Jfi4q+JgXmA5UkZtT98cDmsyeT74aZu4c5YqugOtk Pm7B5wzjlLBY4JmyG9p5eG/jXf87Bn+9w551+lFppm6pA+VDkHrDfUwi+8ZD8IIhqC+i 5P6LFbdaIBdSlq/3QrT/642DwytIWrq6loz3WpkDI1vKpCQOi13wNN3BE0Vwv841+mlI opxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=V6K1LMRgF7ULUJPOXdy+1S6acPNQ9pvOKzffHzC8PcA=; b=bR2f6tQVFgWG8jva4P3O3KfzkDIn/BcHbQpJr+5LRu62XvOIDIjVx2KnxRrsWnxlaV h9exqai5jnCd4NZzIgJ7gzVeNjIuVFDGdqvy46qIyUPsq0E8iwvo5BJI5xZTMcZHYjPl mRFbEokV33vvbNAExSYK+/+wuS8bPFr5pLNPns/1VEZKGmuBmU5IHzDOFWqiJ0AS3qQn bDU5FXe3nITpGH2S0aQKVqIh14DfENgwlwOjlrU5wVvydtGSjjyj8YVCWCxZmmS4ZdeZ W37LDSv05IdxLxWUzEtmq9A6xqEa66m5VMXbzwzggOzgK4++iXET99yFOvlveKpZnfOz FUkQ== X-Gm-Message-State: AGi0Pubso2hoxbJJHnWJwqi+5r59mXFqwyMYTJvZsIX7K7Uvay1P4+dH 5p8ruSL3MUcv1n+AjjcYlbOUHKfkAn0deA== X-Google-Smtp-Source: APiQypI+UtUsciwIHhgBZHQHNDtvd5ThgL7Z7ANP4ZMLKK6Ph6zMEawCUCOeXUfvsjqwKQ58MxC6Hg== X-Received: by 2002:adf:e64c:: with SMTP id b12mr17634737wrn.131.1589191315547; Mon, 11 May 2020 03:01:55 -0700 (PDT) Received: from naushir-VirtualBox.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id u74sm26391908wmu.13.2020.05.11.03.01.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2020 03:01:55 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Mon, 11 May 2020 11:01:48 +0100 Message-Id: <20200511100150.5205-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.17.1 Subject: [libcamera-devel] [PATCH 0/2] raspberrypi: FPS control X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 May 2020 10:01:56 -0000 Hi, The following two patches add variable framerate control to a sensor subdevice. This will allow shutter speeds below 33ms during viewfinder (for example). I've currently hardcoded the maximum limit at 30.0fps, but we ought to have a discussion on how a user can request fps limits - perhaps though a Request, or stream configuration parameters? Thanks, Naush Naushir Patuck (2): libcamera: raspberrypi: Add control of sensor vblanking libcamera: raspberrypi: Limit the maximum framerate to 30.0fps src/ipa/raspberrypi/cam_helper.hpp | 1 + src/ipa/raspberrypi/cam_helper_imx219.cpp | 23 +++++++++++++++++++ src/ipa/raspberrypi/cam_helper_imx477.cpp | 23 +++++++++++++++++++ src/ipa/raspberrypi/cam_helper_ov5647.cpp | 23 +++++++++++++++++++ src/ipa/raspberrypi/raspberrypi.cpp | 14 ++++++++++- .../pipeline/raspberrypi/raspberrypi.cpp | 2 ++ 6 files changed, 85 insertions(+), 1 deletion(-)