From patchwork Wed May 6 10:33:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 3688 Return-Path: Received: from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E8A38603F2 for ; Wed, 6 May 2020 12:33:52 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=uajain.com header.i=@uajain.com header.b="F6D9c+kZ"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com; h=from:subject:mime-version:to:cc:content-transfer-encoding: content-type; s=s1; bh=CF4bVLVnoO++sPZ2jY7mP5xQZCRWO850iOpA6okRImc=; b=F6D9c+kZSaAScpmRLT7XcKrG62zKglzkMnAxF3hF4C75SOqwTwG4Gs53Wj3Ik3AvLIxp qbu9+HXDaCp1b3Mq6zoFKidQLfcrtIcyYFiqgAWBrL8fA5D3uldkSyjD8nyJM47Qp/cN/T L9UqhqkuDVCfDayysSEDe53CrGAeU2fPk= Received: by filter0073p3las1.sendgrid.net with SMTP id filter0073p3las1-3640-5EB2928E-B0 2020-05-06 10:33:50.835394126 +0000 UTC m=+1773089.258245711 Received: from mail.uajain.com (unknown) by ismtpd0004p1maa1.sendgrid.net (SG) with ESMTP id jX19BDfQSB26t9zVdvREKA for ; Wed, 06 May 2020 10:33:50.586 +0000 (UTC) From: Umang Jain Date: Wed, 06 May 2020 10:33:51 +0000 (UTC) Message-Id: <20200506103346.3433-1-email@uajain.com> Mime-Version: 1.0 X-SG-EID: 1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPc7nggfkZXnk4gpr6Hf1oWqR869PN94HZjau4vp3/fI1SZf5qGE5Pl56X9iwbcs4MbxONfVE3kXPrFcuHB6mGeS+uXZ4pi2xt8SwTMV4KRJRkh2X4vI2mHa8wd9HFee72n1SqA3132eJH7Koc5t2yVyDnphTP31vGm2qd/J8Ij/CPjSc/mkXbYv4dqSpDMZbin To: libcamera-devel Subject: [libcamera-devel] [PATCH 0/4] Introduce UVC hotplug support X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 May 2020 10:33:53 -0000 Hi all, This is the patch series which introduces support for hotplugging and hot-unplugging UVC devices (like external webcam) while the camera-manager is running. The implementation comes with a automated unit test and qcam integration. To test, simply compile the patch series, fire up qcam, attach a UVC device and start streaming! However, while writing the unit-test in order to test this, I might have uncovered a bug in libcamera which I have not been able to dig deeper as of now. The unit-test simply bind/unbind a available UVC camera to simulate the hotplug/unplug event. However, while unbinding a camera, I noticed that camera-manager still keeps around some reference of media-directory(ies) in /sys/module/uvcvideo/drivers/usb:uvcvideo/ which makes the symlinks keep linger around *until* the CameraManager is stopped. Hence, the test currently has a "restart the CameraManager" workaround to cleanup symlinks in that sysfs directory, before cleanly rebinding. Umang Jain (4): libcamera: device_enumerator: Emit a signal when a new device is hotplugged libcamera: camera_manager: Introduce signals when a camera is added/removed qcam: main_window: Introduce hotplug support tests: Introduce hotplug hot-unplug unit test include/libcamera/camera_manager.h | 4 + src/libcamera/camera_manager.cpp | 47 ++++++- src/libcamera/device_enumerator.cpp | 10 ++ src/libcamera/include/device_enumerator.h | 3 + src/qcam/main_window.cpp | 31 +++++ src/qcam/main_window.h | 3 + test/hotplug-cameras.cpp | 152 ++++++++++++++++++++++ test/meson.build | 1 + 8 files changed, 249 insertions(+), 2 deletions(-) create mode 100644 test/hotplug-cameras.cpp