From patchwork Mon Apr 27 22:05:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 3577 Return-Path: Received: from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net [195.74.38.228]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D8DB860AF4 for ; Tue, 28 Apr 2020 00:06:16 +0200 (CEST) X-Halon-ID: 3dbc9e95-88d3-11ea-b7d8-005056917a89 Authorized-sender: niklas@soderlund.pp.se Received: from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de [79.202.35.146]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA id 3dbc9e95-88d3-11ea-b7d8-005056917a89; Tue, 28 Apr 2020 00:05:48 +0200 (CEST) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: libcamera-devel@lists.libcamera.org Date: Tue, 28 Apr 2020 00:05:24 +0200 Message-Id: <20200427220529.1085074-1-niklas.soderlund@ragnatech.se> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/5] {cam, qcam}: Unify stream option parsing X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Apr 2020 22:06:17 -0000 Hi, Prepare for allowing multiple streams in qcam by unifying the cam and qcam command line options parsing for stream options. With this RAW capture support can be added to qcam without first redesigning the whole GUI to allow for individual stream configuration. Also having the same options for cam and qcam to configure streams is a good idea. As this series reveals some features where enabled in cam but not in qcam. Niklas Söderlund (5): cam: options: Make KeyValueParser::parse() virtual cam: options: Add public method to invalided options cam: Add helper class to parse stream configuration cam: Make use of StreamKeyValueParser qcam: Make use of StreamKeyValueParser src/cam/main.cpp | 69 ++----------------- src/cam/meson.build | 1 + src/cam/options.cpp | 6 ++ src/cam/options.h | 6 +- src/cam/stream_options.cpp | 133 +++++++++++++++++++++++++++++++++++++ src/cam/stream_options.h | 32 +++++++++ src/qcam/main.cpp | 12 ++-- src/qcam/main_window.cpp | 35 +++++----- src/qcam/main_window.h | 4 +- src/qcam/meson.build | 1 + 10 files changed, 208 insertions(+), 91 deletions(-) create mode 100644 src/cam/stream_options.cpp create mode 100644 src/cam/stream_options.h