From patchwork Fri Apr 24 10:46:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 3512 Return-Path: Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 41516603FC for ; Fri, 24 Apr 2020 12:47:03 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="XbD61A55"; dkim-atps=neutral Received: by mail-wr1-x430.google.com with SMTP id b11so10204565wrs.6 for ; Fri, 24 Apr 2020 03:47:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id; bh=j7eUpfHnYzIdbXkt9y4l8rVNAbsyP3kdFt7vwnxtbu8=; b=XbD61A55ZV4N3nkMTQvNmqjU8kiXX8BS+5GlXhugv7/BxYjKQCUjpBXkjB4ZG+w24g T0ErjBdffIkK2Ce4cv8AiZv8zmb9/q3MWikJVVp8ijPxEb2uc/AnVaIPV4JsaLQJc3+Q PMyGOZ48Wj1a5zV7civ/OzI0Dn2c0ZXweO+Ayi2by9SvgCYtpiCzhS9ugtkiZdtPX1dJ DVjES1BQZbPdmBYUwiLiW2UX95vP0lJFkOi1+7IYCnyKrHwc6W6+/W43YiAe0lUTWiMm gBj982ZKM33nxRt84TZzW382GF5rlyE7DbBM0FXT4Kwy/zBKEQ1JFw8bd4G+xsvva/qU NZ3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=j7eUpfHnYzIdbXkt9y4l8rVNAbsyP3kdFt7vwnxtbu8=; b=fZQeHT7A2t5Y1FENZJ518V+b9ZnnzjB1Sos9YAVWOEtv8n5UbceRLDNAIFARcKjBZN VhxcNC2IKXzvTTvQFgurfzLOHN/1NNbx+dVyCL2BNkYNu+y+PfWMavxoR9+CBiTcECOk mdEcrp1F7NJi4aiQWy/VAPRRkosE/EW27mz01uDm6du7AWgrEdbBrQqPzpunSJtmb4Ik pZQfcWgyUo7vx7XgMOZ1mygZrSUGN+rECpYuFiX4t5/ZQ9pJpoEaDKkeikiD9z4Qageq 8mmKDrnVDuF8HNdHX4KYpDa7Z/JU/xmZc1/2SLzBpanWH8qpgEKPW4K0f+Wq0Mmdz2TA 4D/A== X-Gm-Message-State: AGi0PubH44v15SOSL3QkDh6ffNVEgJbhuvcgGACXAtClmMpxGzib2LJ0 HrId6jgx21n4XIgeiJXahXlTeoGGkppznA== X-Google-Smtp-Source: APiQypJgJz2N9vmBFO5jrZV6qTUlS09FUGbPSNf629bDbAHPRXx0JuWoo+Z6KGvAp7CqnOR89S2cXQ== X-Received: by 2002:adf:ce0d:: with SMTP id p13mr11080245wrn.66.1587725222679; Fri, 24 Apr 2020 03:47:02 -0700 (PDT) Received: from naushir-VirtualBox.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id j68sm7884997wrj.32.2020.04.24.03.47.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2020 03:47:02 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 24 Apr 2020 11:46:55 +0100 Message-Id: <20200424104700.26819-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.17.1 Subject: [libcamera-devel] [PATCH v4 0/5] Patchset for libcamera controls X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 10:47:03 -0000 Hi, Here is patch-set v4 for the changes to libcamera controls. The following changes have been made from the v3 patch-set: - Document controls to be bi-directional by default. - Fix rounding of gain control for the uvcvideo pipeline. - Merge patches 1 and 2 (gain/exposure unit changes and uvcvideo pipeline changes). - Remove reference to ManualGain from AwbEnable. - Contrast/Brightness/Saturation now all use floats for consistency. - Add Shadow constraint mode to AE. - Reword documentation for Lux control. - Fix typo metering mode -> exposure mode. - Reword AWB CT -> colour temperature. Hope I did not miss out on any other comments. Regards, Naush Naushir Patuck (5): libcamera: control_ids: Add comment to specify control direction libcamera: controls: Updates to gain and exposure controls libcamera: controls: Reorder and update description of existing controls libcamera: controls: Add AE related controls libcamera: controls: Add AWB related controls src/libcamera/control_ids.cpp.in | 3 + src/libcamera/control_ids.yaml | 213 +++++++++++++++++-- src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 37 +++- 3 files changed, 229 insertions(+), 24 deletions(-)