From patchwork Wed Apr 15 05:45:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 3464 Return-Path: Received: from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4AE8D60401 for ; Wed, 15 Apr 2020 07:45:16 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=uajain.com header.i=@uajain.com header.b="guL37pCe"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com; h=from:subject:mime-version:to:cc:content-transfer-encoding: content-type; s=s1; bh=7nFOFD3gKkny8O82ZXCZTUNKphbeN+h5RCqxzeTZiwU=; b=guL37pCehxihHpr7MtRrinNQavZk17t0PISYTHLg0qjmOHPDQoTxBef17wv5Y42VuU/Z C02wAAMfmKqspNhiJY9tER2Jw3NkfbFM7DhcVnZSAiieguZkD1d+jB1rf7rrTlKg7y3iU3 s9grD5E8EqGtPGfIhDkfLJt3Wm0dH4hFg= Received: by filter0081p3las1.sendgrid.net with SMTP id filter0081p3las1-23682-5E969F6A-4E 2020-04-15 05:45:14.391867827 +0000 UTC m=+1152855.443148027 Received: from mail.uajain.com (unknown) by ismtpd0005p1maa1.sendgrid.net (SG) with ESMTP id UQtvfn9QR62VfqVBcwbohg Wed, 15 Apr 2020 05:45:14.054 +0000 (UTC) From: Umang Jain Date: Wed, 15 Apr 2020 05:45:14 +0000 (UTC) Message-Id: <20200415054503.13108-1-email@uajain.com> Mime-Version: 1.0 X-SG-EID: 1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPclq38gSC/txiORZpK15NbTtgrjKPpgjhEIFfqCF2YDw+O4wkLE7n1GCntQM+cuvDeYR4a7ZgLzgPg833xXDLGNP9YbVU47RkYCDw2TWbZygj89egFxBrd2y1kua/NkD6Ip3giPjC1Sc/i6sXa7wK5Llt1xXHohSDQ0mIPOApii0vmLX3bx8BjyfNDB4ZaHhQ5 To: libcamera-devel@lists.libcamera.org Subject: [libcamera-devel] [PATCH v2 0/2] More coverity scan fixes X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2020 05:45:16 -0000 Hi all, Second interation of the following patches. Changelog: * libcamera: camera: Return -EINVAL if any stream is null while configure() - Return, instead of excluding a stream in Camera::configure(). Empty the activeStreams_ on error path too. I did not find any other cleanups needed to be done and the camera state is still unchanged. * test: v4l2_videodevice: buffer_cache: Fail the test if no hot-buffer is obtained - Tweak the commit message. Umang Jain (2): libcamera: camera: Return -EINVAL if any stream is null while configure() test: v4l2_videodevice: buffer_cache: Fail the test if no hot-buffer is obtained src/libcamera/camera.cpp | 5 ++++- test/v4l2_videodevice/buffer_cache.cpp | 5 +++++ 2 files changed, 9 insertions(+), 1 deletion(-)