From patchwork Sat Apr 11 00:19:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 3421 Return-Path: Received: from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net [195.74.38.227]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B83B6277E for ; Sat, 11 Apr 2020 02:19:21 +0200 (CEST) X-Halon-ID: 0f3e99df-7b8a-11ea-aeed-005056917f90 Authorized-sender: niklas@soderlund.pp.se Received: from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de [79.202.35.146]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA id 0f3e99df-7b8a-11ea-aeed-005056917f90; Sat, 11 Apr 2020 02:19:13 +0200 (CEST) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: libcamera-devel@lists.libcamera.org Date: Sat, 11 Apr 2020 02:19:04 +0200 Message-Id: <20200411001911.1143155-1-niklas.soderlund@ragnatech.se> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/7] libcamera: ipa_manager: Proxy open-source IPAs to a thread X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Apr 2020 00:19:21 -0000 Hello, This series tries to solve some issues discovered by testing Laurent's patch (7/7 in this series). The main change is to extend the IPAInterface with a start() and stop() method that can deal with things as starting threads or allocating resources needed by the IPA in tandem with the camera start and stop. The series is a mix of patches to the rkisp1 pipeline handler solving issues uncovered by running the IPA in a separate thread, adding the IPA start() and stop() methods and integrating them with Laurent's work to run open-source IPAs in a thread. Laurent Pinchart (1): libcamera: ipa_manager: Proxy open-source IPAs to a thread Niklas Söderlund (6): ipa: Add start() and stop() operations libcamera: pipeline: rkisp1: Queue parameters even if they are not ready libcamera: pipeline: rkisp1: Initialize IPA libcamera: pipeline: rkisp1: Do not try to process cancelled frames libcamera: pipeline: rkisp1: Call IPA start() and stop() libcamera: pipeline: vimc: Call IPA start() and stop() include/ipa/ipa_interface.h | 4 + include/ipa/ipa_vimc.h | 2 + src/ipa/libipa/ipa_interface_wrapper.cpp | 16 ++ src/ipa/libipa/ipa_interface_wrapper.h | 2 + src/ipa/rkisp1/rkisp1.cpp | 2 + src/ipa/vimc/vimc.cpp | 20 +++ src/libcamera/include/ipa_context_wrapper.h | 2 + src/libcamera/ipa_context_wrapper.cpp | 26 ++++ src/libcamera/ipa_interface.cpp | 35 +++++ src/libcamera/ipa_manager.cpp | 48 +++--- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 45 +++++- src/libcamera/pipeline/vimc/vimc.cpp | 8 + src/libcamera/proxy/ipa_proxy_linux.cpp | 2 + src/libcamera/proxy/ipa_proxy_thread.cpp | 162 ++++++++++++++++++++ src/libcamera/proxy/meson.build | 1 + test/ipa/ipa_interface_test.cpp | 24 +++ test/ipa/ipa_wrappers_test.cpp | 33 +++- 17 files changed, 398 insertions(+), 34 deletions(-) create mode 100644 src/libcamera/proxy/ipa_proxy_thread.cpp