From patchwork Fri Apr 3 14:53:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 3370 Return-Path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D209600FA for ; Fri, 3 Apr 2020 16:53:09 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="P87eASwS"; dkim-atps=neutral Received: by mail-wr1-x441.google.com with SMTP id m17so8828400wrw.11 for ; Fri, 03 Apr 2020 07:53:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id; bh=ZEgD0ZJt+HvhNzPSRewlclDGxcSLDNonM6lcGw9ipB4=; b=P87eASwS7aaAEgYwJ1jP+4poQfu1yH0dt79qZvwivWD3IH0o+OBZhoz+FVAI+4u5Ip NfT/IxOwn+gDKFTHsa1M+ugPRQKfw8oE5YHGzyAU5LUJIS5+ngh8v2PgChLVcuHvjUqW 3AlSC2qzl5pakFa4AJ2Ydvsby8PmpEOC37qiIy2mOvISp/klZXyKcYn5CenqGrsnEY2i m8SURQzOceH1asSbVIQpxbopzSBksKEw6L4XjnSV3+xuD1J+XSWvaRplxuaM4x1F3HM/ Xw9wTiwc7XiaWj+E5ivxfmwiSbh6uWwyrmz5Aa8NI+81CAd1caYOZOvUe9fSli/ieuwv bZfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ZEgD0ZJt+HvhNzPSRewlclDGxcSLDNonM6lcGw9ipB4=; b=sI1yMuXbQewDZ9EhPPaqXjmv/U9KnCnUxeOU72iBOykpzBpVJsH6uwU90JWBqXAbOS g04G8Q6XbBWckZW29LvSOUyBiJNKZylbogfbzMzd1CtZK5dpMq32irjVvgVTyhOmjMEs fxKiek1F1FnCBhI1vkS+Hge56BUC1aI7scIr2uGt+xiHKefQwc8C59xbualNyi3igYY8 axM1ai+S9DOjSskTmLaP58SrnUYt0c3+TjUHQgiLj5fFemZHtFOtslXh6hhis+mrKGYJ a8M+SsV9XWMCW1bDGL8arfBy18+FxnPAYJb/ZahlS223mWchaL9h7GNPFAUEvAD/DWf5 q8hA== X-Gm-Message-State: AGi0PuaB5nWFp/LCOS4oarUojzVM0/2NKGo/edZMacAGprYuV2etqEbY QfGmXUPB1RiFXd/lG1yuAlkS5hszaHC6/g== X-Google-Smtp-Source: APiQypKbBCHW9w4GbkfNDFPQgzuwmDKOcR9LErvGFLyB3Cqyp4jAaUty1x0+KGxCgReVcePKZYWt2A== X-Received: by 2002:adf:e90e:: with SMTP id f14mr9631000wrm.106.1585925589097; Fri, 03 Apr 2020 07:53:09 -0700 (PDT) Received: from naushir-VirtualBox.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id u5sm13559469wrp.81.2020.04.03.07.53.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2020 07:53:08 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 3 Apr 2020 15:53:00 +0100 Message-Id: <20200403145305.10288-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.17.1 Subject: [libcamera-devel] [PATCH v3 0/5] Patchset for libcamera controls X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Apr 2020 14:53:10 -0000 Hi all, This is the v3 patchset for the changes to libcamera::controls. Hopefully all comments from v2 have been addressed. Highlights of the changes from v2->v3: 1) Reorder some of the changes and reduce the number of patches. 2) Added comments in the control_ids.yaml file to list control direction. 3) Also added comments as TODOs for changes that require a bit more thought. 4) Only list one custom control enum instead of three. 5) Use of the same control for return directions where appropriate. Please do let me know if you want anything re-arranged or have further review comments. Thanks, Naush Naushir Patuck (5): libcamera: controls: Updates to gain and exposure controls libcamera: uvcvideo: Update exposure/gain ctrls set with new units libcamera: controls: Reorder and update description of existing controls libcamera: controls: Add AE related controls libcamera: controls: Add AWB related controls src/libcamera/control_ids.yaml | 202 +++++++++++++++++-- src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 25 ++- 2 files changed, 206 insertions(+), 21 deletions(-)