From patchwork Thu Mar 19 02:31:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 3190 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C505560414 for ; Thu, 19 Mar 2020 03:31:58 +0100 (CET) Received: from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2B0ED5F for ; Thu, 19 Mar 2020 03:31:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1584585118; bh=9vOn/9M5O18qUY8gM6o3vqd3JvnVUvN5laqA2NI9hGw=; h=From:To:Subject:Date:From; b=mtC/ONN3jYdTO/kBBnDulIb/ds5onZnS22JRhGbp5fiLnSE0sV7eh5vtUFSTgtWu1 tkEupUXWDjbS3ctDawlUiCmhNWcwgdS6kIePq0DrM5xSecR9IalqcyfAWg/kLLY2WL nLHZ7py2K67aNMcy85gTSYWm+BDVDEHmswLXrQlw= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Thu, 19 Mar 2020 04:31:47 +0200 Message-Id: <20200319023149.32195-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/2] Add a V4L2PixelFormat class X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2020 02:31:59 -0000 Hello, This small patch series builds on top of Niklas' PixelFormat work to introduce the V4L2 counterpart of the PixelFormat class. Compared to v1, a toString() method has been aded. The class should be extended for a lookup table of pixel format names to improve the toString() method. Other helper methods to retrieve format information should probably be added too, hopefully removing some of the data from the pixelFormatInfo array in v4l2_camera_proxy. Ideas on how to split pixel format information and conversion between the PixelFormat, V4L2PixelFormat and V4L2VideoDevice classes are welcome. Laurent Pinchart (2): libcamera: v4l2_videodevice: Add V4L2PixelFormat class libcamera: v4l2_videodevice: Make V4L2PixelFormat constructor explicit src/libcamera/include/v4l2_videodevice.h | 39 ++++-- src/libcamera/pipeline/ipu3/ipu3.cpp | 14 +- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 +- src/libcamera/pipeline/uvcvideo.cpp | 4 +- src/libcamera/pipeline/vimc.cpp | 2 +- src/libcamera/v4l2_videodevice.cpp | 125 +++++++++++++----- .../v4l2_videodevice_test.cpp | 2 +- 7 files changed, 135 insertions(+), 55 deletions(-)