From patchwork Wed Mar 18 15:24:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kaaira Gupta X-Patchwork-Id: 3170 Return-Path: Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 793DD60418 for ; Wed, 18 Mar 2020 16:24:58 +0100 (CET) Received: by mail-pf1-x441.google.com with SMTP id x2so13709362pfn.9 for ; Wed, 18 Mar 2020 08:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=es-iitr-ac-in.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=l7nhN0LBk1iD5ElNikb2Qbxaq/Xtt6lAtYENrJPRB88=; b=NwVTI6C6kIdxVk+/5UaFqjkyC0QX2XGv15qHln5UaWsTtFe5FZ+QatrYMbSuzeHSpA nYCU9ZtaaVGpI89tbR9b55KYmW/PtwlXbJNQcsz4IFHn607PXAsoHBGmvbj+IIxJ8w9n 9LRPKzaJGghLDQ1u6q1wYvFNhvYAQT2N4a7mKsmhhZQsrS5C3uYFeCvM5QEKFrgvF9vW JAHa6iS+VWkiLaCqFxhO39mf2GAC0H5Q4aNrtdc3sePHjoQuclp6cwD+OaIx9zKsrGkG Kclytge4z38K3LdGqbINJYaoTgU9Kzl4R3bbPD9bzHJCi6bA0T6Asrfm+MzCm5Osp6OG p3OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=l7nhN0LBk1iD5ElNikb2Qbxaq/Xtt6lAtYENrJPRB88=; b=CwP92bYjz51kjB/svId1/6Lg+opAgkPjQ3J95tpIZFEARJXss+lLDy3QfiPh4JlHWs A80qdR+yPJW24wlFIgEXiR34s+9VFuz4yaBpqiT3sBNDv6PeFWuC/Gl35WKEm7RtERZo V67/aAYOJ/B5g9QvvyQLWBqZ01NxK9oN8mJUWiYLu93kHuviZDgFGuieJRZ2QXsXuxwN JvTBaa5QW/bHbClnDhLj1iDZ6bFq1UpUg0Rt1GOC+H+Ko1h/kTKF5Zp8rrzGvGrH9kVx aTokJ4bNqNyMbN4EYpF5OkEfnVAD5JvKuPc+zVApa96Zy36f/ygFzdXUoZgzLJ7/b/lw jh5Q== X-Gm-Message-State: ANhLgQ2ecM00/Bha4eVMb/K0YnE788DENCTgSTwj2qnvEjjLCoEi17xd tl+gfVZTk9BbIVEYw5/Y4r/uwQ== X-Google-Smtp-Source: ADFU+vuJsPMoGxRnQMtSYSve5V4QE5KqIdAa2VNWI0HQl9dXC8BWZBPUNvrMfBvW8KN6UIEaBvaIaw== X-Received: by 2002:a63:64d:: with SMTP id 74mr5190288pgg.423.1584545096157; Wed, 18 Mar 2020 08:24:56 -0700 (PDT) Received: from kaaira-HP-Pavilion-Notebook ([103.113.213.153]) by smtp.gmail.com with ESMTPSA id c16sm7017297pfn.86.2020.03.18.08.24.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2020 08:24:55 -0700 (PDT) From: Kaaira Gupta To: Vaishali Thakkar , Helen Koike , kieran.bingham@ideasonboard.com, libcamera-devel@lists.libcamera.org Cc: Kaaira Gupta Date: Wed, 18 Mar 2020 20:54:22 +0530 Message-Id: <20200318152427.13126-1-kgupta@es.iitr.ac.in> X-Mailer: git-send-email 2.17.1 Subject: [libcamera-devel] [PATCH LIBCAMERA v4 0/5] libcamera: determine IPA_PROXY_PATH at runtime X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Mar 2020 15:25:01 -0000 This is a series of patches to determine IPA_PROXY_PATH at runtime, removing hard-coded LIBCAMERA_IPA_PROXY_PATH from test.cpp and making isLibcamerainstalled() and libcameraPath() utils' functions. Changes since v3: Renumbered the patches to account for the squashing patch 3 and 5 in one patch. Patch 1: No Changes. Patch 2: No changes. Patch 3: Squashed patch 5 with this patch. Rearranged headers alphabetically and used imperative in \brief statements. Changed Libcamera to libcamera and wrapped lines at 80 characters. Patch 4: Re-wrote the commit message as per reviews, changed 'proxy' to 'proxy workers', corrected the proxy workers' path, wrapped lines at 80 characters, and added a return std::string() while checking the condition !libcameraInstalled. Patch 5: No changes (previously patch 6). Changes since v2: Patch 1: No changes. Patch 2: No changes. Patch 3: Declared functions in utils.h and declared _DYNAMIC extern outside namespace libcamera Patch 4: No changes. Patch 5: No changes. Patch 6: No changes. Changes since v1: Renumbered the patches to account for two additional patches as described below. Patch 1: Fixed whitespace problems. Patch 2: Fixed whitespace problems. Patch 3: NEW PATCH: Adds isLibcamerainstalled() and libcameraPath() as global functions in utils module. Patch 4: Earlier patch 3: fixed styling issues and used helper functions of utils instead of defining own functions. Patch 5: NEW PATCH: Replace isLibcamerainstalled() and libcameraPath() by helper functions defined in utils in ipa_manager Patch 6: Earlier patch 4: Fixed odd tab in comment description. Kaaira Gupta (5): libcamera: ipa_proxy: use utils::split() libcamera: ipa_proxy: rearrange proxies precedence libcamera: utils: Move libcamera build path lookup to utis libcamera: ipa_proxy: search for proxy in build tree tests: remove IPA_PROXY_PATH environment variable src/libcamera/include/utils.h | 4 +++ src/libcamera/ipa_manager.cpp | 36 ++----------------------- src/libcamera/ipa_proxy.cpp | 45 ++++++++++++++++++++++---------- src/libcamera/utils.cpp | 49 +++++++++++++++++++++++++++++++++++ test/libtest/test.cpp | 4 --- 5 files changed, 86 insertions(+), 52 deletions(-)