From patchwork Wed Mar 18 11:58:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kaaira Gupta X-Patchwork-Id: 3162 Return-Path: Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4AF7E60418 for ; Wed, 18 Mar 2020 12:58:58 +0100 (CET) Received: by mail-pf1-x435.google.com with SMTP id z5so13796537pfn.5 for ; Wed, 18 Mar 2020 04:58:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=es-iitr-ac-in.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=xRrKYYNoOAUA+87yYLKIR1TFH4/aPm7ovNTYQcrmElQ=; b=XHAdA88SZKjmtw89CYp9gbAit13zR6tY0bn0m+lofusVvxxlmaLIAEwgmLFBl18rmo SJl8GrzLhFtNF+26KYAh6fnAhMm7hrvMZyii0teto8LgxEKQLgXuyjD0yAE0Go/8CnvH /0ggFlOkG4aiNOLc7ZsyrrkCcFLZCh7vpRGVtazNToUpPm9P0uEuqCaWg0Utzpzcp644 LnBIWqhLeoBOyYkQF3GBPrONjMxUe8xGEm+yYuMN567+LkG5KGq3IhdDJa+m3iDoKHdt fqYSR4cLFTX0Q+v0AT6tyTmPsNqk4UBdyKD9lsP9LOiysJ4wiJjvGUvhbMyaRbc2OVLi N12Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=xRrKYYNoOAUA+87yYLKIR1TFH4/aPm7ovNTYQcrmElQ=; b=KxJ53o2oLmGb2MmYXNI2MelkRc0EGDx0McCzcJvk3BhtqaXyGLuwTOtKLsXmW4LJZ0 lvIlpQzcowumfnjEJRxe5h2nQhGVHKIC+zffSMdqsRo9yCR2jAPz1dreEkky0XHmtHbf HcFvIm1imgnUYet9E55g9uGdP88wbxNVLQPZUP1JzYbA6uIhWk7bPVRplqnMUd0nJ3IG ZYDVKxjPDH9Xx1j4GobJ36wK5YJUIhddPpcXeDIr01S4C9qBSWoCult6RQ4OX7iqB6Lx AMJLgtYXtCzdoNeTJOLmt4pRpXAIHSczW3K7jqfe/epu9zdw6vvklPq9t8lRa5NHCUx1 cNvQ== X-Gm-Message-State: ANhLgQ0mLM9dF3tGVn1xNd612g+shBddagnMR43gMftueXlETdTHkhbS szoN2w1JqUC5btpjipIea6YkuQ== X-Google-Smtp-Source: ADFU+vvZ+OAmoLcTX5hrsIWSec4E+MtvBCeazkKFnhxRBMrS5gYGavm3CMHWNMRFv6lvVZkp8w2ugA== X-Received: by 2002:a62:ab07:: with SMTP id p7mr4142806pff.318.1584532736503; Wed, 18 Mar 2020 04:58:56 -0700 (PDT) Received: from kaaira-HP-Pavilion-Notebook ([103.113.213.153]) by smtp.gmail.com with ESMTPSA id v9sm2336339pjr.3.2020.03.18.04.58.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2020 04:58:55 -0700 (PDT) From: Kaaira Gupta To: Helen Koike , Vaishali Thakkar , kieran.bingham@ideasonboard.com, libcamera-devel@lists.libcamera.org Cc: Kaaira Gupta Date: Wed, 18 Mar 2020 17:28:40 +0530 Message-Id: <20200318115846.7975-1-kgupta@es.iitr.ac.in> X-Mailer: git-send-email 2.17.1 Subject: [libcamera-devel] [PATCH LIBCAMERA v3 0/6] libcamera: determine IPA_PROXY_PATH at runtime X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Mar 2020 11:58:58 -0000 This is a series of patches to determine IPA_PROXY_PATH at runtime, removing hard-coded LIBCAMERA_IPA_PROXY_PATH from test.cpp and making isLibcamerainstalled() and libcameraPath() utils' functions. Changes since v2: Patch 1: No changes. Patch 2: No changes. Patch 3: Declared functions in utils.h and declared _DYNAMIC extern outside namespace libcamera Patch 4: No changes. Patch 5: No changes. Patch 6: No changes. Changes since v1: Renumbered the patches to account for two additional patches as described below. Patch 1: Fixed whitespace problems. Patch 2: Fixed whitespace problems. Patch 3: NEW PATCH: Adds isLibcamerainstalled() and libcameraPath() as global functions in utils module. Patch 4: Earlier patch 3: fixed styling issues and used helper functions of utils instead of defining own functions. Patch 5: NEW PATCH: Replace isLibcamerainstalled() and libcameraPath() by helper functions defined in utils in ipa_manager Patch 6: Earlier patch 4: Fixed odd tab in comment description. Kaaira Gupta (6): libcamera: ipa_proxy: use utils::split() libcamera: ipa_proxy: rearrange proxies precedence libcamera: utils: add Libcamera installed & path libcamera: ipa_proxy: search for proxy in build tree libcamera: ipa_manager: replace by utils functions tests: remove IPA_PROXY_PATH environment variable src/libcamera/include/utils.h | 4 +++ src/libcamera/ipa_manager.cpp | 36 ++------------------------ src/libcamera/ipa_proxy.cpp | 37 +++++++++++++++++---------- src/libcamera/utils.cpp | 48 +++++++++++++++++++++++++++++++++++ test/libtest/test.cpp | 4 --- 5 files changed, 77 insertions(+), 52 deletions(-)