From patchwork Mon Mar 9 16:24:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 3065 Return-Path: Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id EB7A5628BD for ; Mon, 9 Mar 2020 17:21:27 +0100 (CET) X-Originating-IP: 93.34.114.233 Received: from uno.lan (93-34-114-233.ip49.fastwebnet.it [93.34.114.233]) (Authenticated sender: jacopo@jmondi.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 8E4E660015 for ; Mon, 9 Mar 2020 16:21:27 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Mon, 9 Mar 2020 17:24:03 +0100 Message-Id: <20200309162414.720306-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 00/11] Adda support for V4L2 array control and strings X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2020 16:21:28 -0000 This series includes two parts: - Support for controls with string type from Laurent - Support for V4L2 U8 controls with paylod from me. The series starts with a rename of ControlRange to ControlInfo as for string controls 'range' is not appropriate, then support for controls with type std::string is added to the control and control serializer frameworks. After a small fix for the V4L2Device::ioctl() return code, the series enables reading/writing V4L2 controls with type V4L2_CTRL_TYPE_U8 and enable their enumeration in the v4l2 control framework. A test for both use cases is added. Series is based on the latest master branch. Thanks j Jacopo Mondi (7): libcamera: v4l2_controls: Fix usage of strerror() libcamera: v4l2_controls: Cache query control information libcamera: v4l2_device: Support writing array U8 controls licamera: v4l2_device: Support reading U8 array controls libcamera: v4l2_controls: Support U8 array controls libcamera: v4l2_device: Enable enumeration of U8 controls test: v4l2_videodevice: Test U8 array controls Laurent Pinchart (4): libcamera: controls: Name all ControlInfoMap instance variables infoMap libcamera: controls: Rename ControlRange to ControlInfo libcamera: controls: Add support for string controls test: controls: control_value: Test string control type include/ipa/ipa_controls.h | 2 +- include/libcamera/controls.h | 48 +++++++++---- src/libcamera/control_serializer.cpp | 80 +++++++++++++-------- src/libcamera/controls.cpp | 81 ++++++++++++++------- src/libcamera/gen-controls.py | 18 ++--- src/libcamera/include/control_serializer.h | 10 +-- src/libcamera/include/v4l2_controls.h | 4 +- src/libcamera/include/v4l2_device.h | 1 + src/libcamera/ipa_controls.cpp | 38 +++++----- src/libcamera/pipeline/uvcvideo.cpp | 4 +- src/libcamera/pipeline/vimc.cpp | 4 +- src/libcamera/v4l2_controls.cpp | 39 ++++++---- src/libcamera/v4l2_device.cpp | 82 +++++++++++++++++----- test/controls/control_info.cpp | 73 ++++++------------- test/controls/control_info_map.cpp | 82 ++++++++++++++++++++++ test/controls/control_range.cpp | 51 -------------- test/controls/control_value.cpp | 22 ++++++ test/controls/meson.build | 8 +-- test/serialization/serialization_test.cpp | 4 +- test/v4l2_videodevice/controls.cpp | 47 ++++++++++--- 20 files changed, 437 insertions(+), 261 deletions(-) create mode 100644 test/controls/control_info_map.cpp delete mode 100644 test/controls/control_range.cpp --- 2.25.0