From patchwork Wed Nov 18 18:16:50 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jai Luthra X-Patchwork-Id: 29028 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B11C1C3355 for ; Wed, 18 Nov 2026 18:17:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B67216A8C7; Wed, 18 Nov 2026 19:17:54 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="pClwsw3/"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 710226A8C7 for ; Wed, 18 Nov 2026 19:17:53 +0100 (CET) Received: from mail.ideasonboard.com (unknown [IPv6:2401:4900:1c67:cdf:7464:6c04:36e4:ee87]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F3BA34; Wed, 18 Nov 2026 19:15:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1795025724; bh=HOwI9zjamyGXt81VDniTaaWfmCNQx+36e+PGlRFYvIY=; h=From:Subject:Date:To:Cc:From; b=pClwsw3/09dC2DLwM0R2htf/pjZ1/38oIK+6lYHz56s2xosYm4fsHDGufsepjjbvK hwUD8ac+b/UKeQTInW2mMbKOxaZP0mNV7qYp8K/mt2P1qqZ0cWYBDxW9KdOSyt8/IY XmHwj89bHn6Hjtwi+CpnHugObgus8vHq03c9AlMo= From: Jai Luthra Subject: [PATCH v4 0/8] Raspberry Pi: Update VC4 pipeline for mainline Date: Wed, 18 Nov 2026 23:46:50 +0530 Message-Id: <20261118-pi4-upstream-v4-0-93bdc7d925ba@ideasonboard.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAAAAAAAC/3XMvQ6DIBiF4VsxzKWBT+SnU++j6YCAlUExYE0b4 70XXUxMHd+TnGdGyUXvEroVM4pu8smHPge7FMi0un857G1uBAQ4AUrw4Bl+D2mMTndYcmVIJTQ jXKB8GaJr/GfjHs/crU9jiN9Nn+i6nkATxQSDUJJRQ6um1ndvnU6hr4OO9mpCh1Zvgt0QAAcDs uFqxmxpeGMVnBjlbijKD0aZDcY5F0RaKUH9MZZl+QGSUyZkNwEAAA== X-Change-ID: 20260210-pi4-upstream-869c057a4067 To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck , David Plowman , Laurent Pinchart , Kieran Bingham , Paul Elder , Jacopo Mondi , Jai Luthra X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3637; i=jai.luthra@ideasonboard.com; h=from:subject:message-id; bh=HOwI9zjamyGXt81VDniTaaWfmCNQx+36e+PGlRFYvIY=; b=owEBbQKS/ZANAwAKAUPekfkkmnFFAcsmYgBq/evDQKqbpQj+pdY4/VEn1yYuogXtIC+8/2u1A gpbggVAxgiJAjMEAAEKAB0WIQRN4NgY5dV16NRar8VD3pH5JJpxRQUCav3rwwAKCRBD3pH5JJpx RS88EAC5mN85mqK6cLutMyyyIO8lv0PgGvIktPQ37Y2Qz947dOAkqDyXRxl/G2zKeIji7wE6hS1 L5QBL9aRO337BQByYyVRbfYG+UhUjTMNvvNTTDbQBAWbbGll5x7S+OnbubzfMg4Bro4x+UtU8s3 YnTAl/91XmAwiGPJdFmnSAWjPjzsp000JGrJsjPBfTE2PvMitGForM1d4Kf7vBdDrNRlYPZ1Dt0 LlViZkHCG4p/Mioc11pFOwMtpVZ1eU+HpUVQzqla+UNbgO/EI2pNsXmQ1SZNjzJABnoFsQJi6Qv 3CY0t7BNJMtdc23FWDnpTV/y+d8IT4MLp+GuZX54WuzyQKLG/Nr1e7rHDEMQ4UO2KGdvLINOytq syVMHFyhq0v1g/7OHFHtubOI/tkt7FVJVNShC6zR0Hy3Kux0YEFfC6iSHhL49bi2BWg7AEw1BoF EUyEhKwMm7xHGLUSy2C/AIKAp15ac4sultK65PE2O8Hzf+AAEiqyEDEXG+JS5AYMMUuBSoiWRGc lt+eNQ3Z3Pjv/N9N//+srHC1vbr6x7ToRWDQROqstrhiXisPIzEQzdN6neQOOdu0Dxb7Clea0dt MkooF17rK9nVAAsmtTtFB6oT5MDv4wMrxR0Qz5d6r3TRgljvrgBc9c0CQJM3N8EnB9FMzRJaGl2 /ll06ZaFzYJ5rDg== X-Developer-Key: i=jai.luthra@ideasonboard.com; a=openpgp; fpr=4DE0D818E5D575E8D45AAFC543DE91F9249A7145 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, This series has updates to the Raspberry Pi VC4-based image pipeline to work with the mainline variants of the capture (unicam) and ISP (VC4) drivers. The unicam driver is already merged in mainline. The latest revision of the ISP driver is posted here: https://lore.kernel.org/all/20261118-b4-vchiq-isp-v7-0-b8c81d193abf@ideasonboard.com/ For testing this series you can use this kernel branch (with overlays, VCHIQ dependencies and a temporary firmware clock fix): https://github.com/jailuthra/linux/commits/b4/rpi-isp As this series breaks backward-compatibility with older downstream kernels, and modifies a lot of different things, I've tried to split the migration into multiple patches for ease of review: PATCH 1-4 are preparation patches, and should still work with a downstream kernel. PATCH 5-8 transition to the mainline kernel. All of these should be 'bisectable' w.r.t. compilation, but actually running libcamera on a mainline kernel in between the transition of PATCH 5 and PATCH 7 might not work. Signed-off-by: Jai Luthra --- Changes in v4: - Rebase on master - [PATCH 7] Drop unnecessary error print around populating lens-shading dmabuf fd - [PATCH 8] Move uAPI header into linux/media/broadcom/ to match the latest kernel series - Link to v3: https://patchwork.libcamera.org/project/libcamera/list/?series=6195&state=%2A&archive=both Changes in v3: - Rebase on master, switch to std::span - Fix minor review comments from Paul - Link to v2: https://patchwork.libcamera.org/project/libcamera/list/?series=6072&archive=both&state=* Changes in v2: - Populate the LS table's DMABUF descriptor in the pipeline handler - Split and reorganize migration patches to ease review - Cleanup unused PrepareParams argument in platformPrepareIsp() - Link to v1: https://patchwork.libcamera.org/project/libcamera/list/?series=5780&state=%2A&archive=both --- Jai Luthra (7): ipa: rpi: Drop unused params argument from platformPrepareIsp() include: uapi: bcm2835-isp: Add extensible parameter buffer interface ipa: rpi: vc4: Add Bcm2835Params helper ipa: rpi: Allow sharing params buffer to the IPA pipeline: rpi: vc4: Switch to mainline media topology for bcm2835-isp pipeline/ipa: rpi: vc4: Switch configuration from controls to param buffer include: uapi: bcm2835-isp: Drop legacy V4L2 controls Laurent Pinchart (1): pipeline: rpi: vc4: Configure format on Unicam subdev include/libcamera/ipa/raspberrypi.mojom | 18 +- include/linux/bcm2835-isp.h | 346 ---------------- include/linux/media/broadcom/bcm2835-isp.h | 530 +++++++++++++++++++++++++ include/linux/v4l2-controls.h | 3 - include/linux/videodev2.h | 3 +- src/ipa/rpi/common/ipa_base.cpp | 13 +- src/ipa/rpi/common/ipa_base.h | 7 +- src/ipa/rpi/pisp/pisp.cpp | 6 +- src/ipa/rpi/vc4/params.h | 79 ++++ src/ipa/rpi/vc4/vc4.cpp | 220 +++++----- src/libcamera/control_ids_rpi.yaml | 2 +- src/libcamera/pipeline/rpi/common/rpi_stream.h | 1 + src/libcamera/pipeline/rpi/pisp/pisp.cpp | 6 +- src/libcamera/pipeline/rpi/vc4/vc4.cpp | 238 ++++++++--- 14 files changed, 926 insertions(+), 546 deletions(-) --- base-commit: 5efdc682e5b54f7b9f793b1fbf99884d522fd9f9 change-id: 20260210-pi4-upstream-869c057a4067 Best regards,