From patchwork Wed Nov 18 13:15:16 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 29013 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1B71DBDE17 for ; Wed, 18 Nov 2026 14:07:26 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 659B66A8E5; Wed, 18 Nov 2026 15:07:24 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="QECBX3fR"; dkim-atps=neutral Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E66196A8C4 for ; Wed, 18 Nov 2026 15:07:22 +0100 (CET) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-4b467581b98so12138765e9.0 for ; Wed, 18 Nov 2026 06:07:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1795010842; x=1795615642; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=bj5IMw/V/BkHkuMitLvmyYmsIZdNxOJ5cIWzB15zYw0=; b=QECBX3fR99VBbYshMmmJEGfgM39lh6jeVX5ZkplAUDRBgS0BMyl7HoTeoK7NIZoQ9b XqDM+408PbOt1eycFg0sMlAgtM+3MuV2O+5ZhLaLPfEG4RSRMw9fdCS+VpxPeLYIfWc9 KuUffDTYl2jNZLRNBAUNrguTLN6PF+LsplCelOl2bST2NttrSkVFP7q27r17tWrrtscb 30kRm2wjcAi0w3lURTWtnvgQ3bS4XOK5YMF0ahmFsFtr8U2Tw8xklTzgoks/g7R+ewN/ Zz5YB3ZcpOe6xUtQn4I2e2gdrGMhxRW6zS6o3eCiHyH6BSGrXpB0pOYgLxpM3C4COTUv ymQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795010842; x=1795615642; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bj5IMw/V/BkHkuMitLvmyYmsIZdNxOJ5cIWzB15zYw0=; b=lhuUj+gIUEomfXtlP/eGSniez9bRvCbj0EzmqlAQjzEtJSug2LBX67GOyqC9AXfVav 7mRtQT+AcX9UXGqIJx3vUO4cgdF4TCGSqE1rqE5QrynID0P8hUtLnbdsFHf0Olu6UmD/ ZXE0Q407wFlcsBWvKja0+NvSiX3nb/oiVBWrUBV4AX5l7rLsTKW45OAIf/rxwEvGDjDa g5xQI9ZNGmYRbONb+IICo0vW7ouY1WImgnbua4VpEAh9T9sA8ctNKepoEuQ+j5PsoRl0 yOI/FEp1ooaM8YABKD6J5a+7lCZpCdH7DicN+HQxS7DNImRgzyLB4Q/GUHKFtPve8ceR whsQ== X-Gm-Message-State: APuU4Z9whM9Ok0Y4pe4diO5EGxciHstdIaBj3TwGmqy/DaGZ1VxAK7qM Zwt27nHqKuuQp9dxTYK/FzuUwXO5r7QQQK3JHjZr+fT67QVOr9LWaiiJ9aQA3xIadSo/3IEELev HPwrL X-Gm-Gg: AYBFou2liiiYruuw/llG/CrSUkc4SJlIN7SrRLIzVyp+uAOLk5Vz5xaiRY8wpadfQn6 29x1q7p4y7kOA9VmBpgLv45ctdmUAuyfnC3E/u7R0JE2RcrlrYVqlngX2JzFqvLhEFI6cI6W1R+ xJPR8bzT9n7dl1Fyp8gy6dqVWeuE45mPnSfIBYYKB+5ICZwThuZHIFr4L3tQxbBrjOTABgHRnTX BxbwFNeoHmUJEMg7SdYbaHa76TFsPeejoPQAeMnwrwCult9agTzyra8AsmB05jzE9Yi2rpEpsOx FAQU83uJKdkMyGGUXW3DdQgFdu3h7HN2vQr9VURXpK4J2Y2Cu1wFZ9Q+GKmR+Jm4JZGTE0Mhx1g 2dQTUxpTJNqpu6mdmtrdHPFJ8tA8nMjUZckkxNd1LeowhQxC0w511Pix28cwb9Ama9f+rmaVdmb 7ghE8lphGkV2Z5oZ3X8xVvK1dX+cwdGuAI8M6XCqaoUQSlaTlHExDbj+D9AVh3xzi8JCR2PWROy vwz4tJOWsG+2C8V1p2BiVlTgk6Rg56knlarbQXVcod2Et7+CodsJh1dKASm8xQt7xxWzpgQFd+6 7Yaam9wZORcPUO/uQq/Tzbqg3h6tEX05b7gK9AOvEeKJkIo1azjZnefpS0955iuwIcZjYX9IdhL TF8tr6ysNl2Xkchfk/91bToJRJ17zaYElP3WuJlY1x2iZoWgPfIeiyzABgMg/Faxg/7lO X-Received: by 2002:a05:600c:1da9:b0:4bb:52d8:73ef with SMTP id 5b1f17b1804b1-4bb7da534a0mr51304925e9.34.1795010842310; Wed, 18 Nov 2026 06:07:22 -0800 (PST) Received: from davidp-hailo.pitowers.org ([2a00:1098:3142:1f:2ecf:67ff:fe94:e2e6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb7d29c7b7sm55274085e9.5.2026.11.18.06.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 06:07:22 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Cc: David Plowman Subject: [PATCH v1 0/3] RPi: prepare for "pixel peeping" IPAs Date: Wed, 18 Nov 2026 13:15:16 +0000 Message-ID: <20261118140719.46849-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone This is a small preparatory set of patches for "pixel peeping" IPAs, meaning IPAs that want to have a look at some of the raw pixel data. There are 3 patches: 1. Pass the PixelFormat to the IPAs. I didn't turn the PixelFormat into a first class mojom object as it would have required me to write more code (!), but I could do that if we thought others might want to do the same at some point, or if anyone generally felt strongly about it. 2. Memory map raw buffers and track their fds. Naush - I've done this a bit differently to your original version, mostly to keep the extra mapping calls out of the platform files (vc4.cpp and pisp.cpp), and only in the shared files. Perhaps you could check you're still happy with this... 3. Pass raw buffer to IPAs. This is just an update to our prepare() methods to accept the raw buffer, even though no one is using it yet. I wanted to keep all this fluff out of the previous commit to make that one easier to digest. And in case folks are curious, one of the first possible IPAs on my hitlist might be a global motion detection algorithm. Thanks! David David Plowman (3): pipeline: rpi: Pass the raw buffer pixel format to the IPA ipa: rpi: Memory map raw stream buffers ipa: rpi: Pass the raw stream buffer to the control algorithms include/libcamera/ipa/raspberrypi.mojom | 2 + src/ipa/rpi/common/ipa_base.cpp | 16 ++++--- src/ipa/rpi/common/ipa_base.h | 2 + src/ipa/rpi/controller/algorithm.cpp | 3 +- src/ipa/rpi/controller/algorithm.h | 2 +- src/ipa/rpi/controller/camera_mode.h | 3 ++ src/ipa/rpi/controller/controller.cpp | 4 +- src/ipa/rpi/controller/controller.h | 11 ++++- src/ipa/rpi/controller/rpi/af.cpp | 3 +- src/ipa/rpi/controller/rpi/af.h | 2 +- src/ipa/rpi/controller/rpi/agc.cpp | 3 +- src/ipa/rpi/controller/rpi/agc.h | 2 +- src/ipa/rpi/controller/rpi/alsc.cpp | 3 +- src/ipa/rpi/controller/rpi/alsc.h | 2 +- src/ipa/rpi/controller/rpi/awb.cpp | 3 +- src/ipa/rpi/controller/rpi/awb.h | 2 +- src/ipa/rpi/controller/rpi/black_level.cpp | 3 +- src/ipa/rpi/controller/rpi/black_level.h | 2 +- src/ipa/rpi/controller/rpi/cac.cpp | 3 +- src/ipa/rpi/controller/rpi/cac.h | 2 +- src/ipa/rpi/controller/rpi/ccm.cpp | 3 +- src/ipa/rpi/controller/rpi/ccm.h | 2 +- src/ipa/rpi/controller/rpi/contrast.cpp | 3 +- src/ipa/rpi/controller/rpi/contrast.h | 2 +- src/ipa/rpi/controller/rpi/decompand.cpp | 3 +- src/ipa/rpi/controller/rpi/decompand.h | 2 +- src/ipa/rpi/controller/rpi/denoise.cpp | 3 +- src/ipa/rpi/controller/rpi/denoise.h | 2 +- src/ipa/rpi/controller/rpi/dpc.cpp | 3 +- src/ipa/rpi/controller/rpi/dpc.h | 2 +- src/ipa/rpi/controller/rpi/geq.cpp | 3 +- src/ipa/rpi/controller/rpi/geq.h | 2 +- src/ipa/rpi/controller/rpi/hdr.cpp | 3 +- src/ipa/rpi/controller/rpi/hdr.h | 2 +- src/ipa/rpi/controller/rpi/lux.cpp | 3 +- src/ipa/rpi/controller/rpi/lux.h | 2 +- src/ipa/rpi/controller/rpi/noise.cpp | 3 +- src/ipa/rpi/controller/rpi/noise.h | 2 +- src/ipa/rpi/controller/rpi/saturation.cpp | 3 +- src/ipa/rpi/controller/rpi/saturation.h | 2 +- src/ipa/rpi/controller/rpi/sdn.cpp | 3 +- src/ipa/rpi/controller/rpi/sdn.h | 2 +- src/ipa/rpi/controller/rpi/sharpen.cpp | 3 +- src/ipa/rpi/controller/rpi/sharpen.h | 2 +- src/ipa/rpi/controller/rpi/tonemap.cpp | 3 +- src/ipa/rpi/controller/rpi/tonemap.h | 2 +- .../pipeline/rpi/common/pipeline_base.cpp | 44 ++++++++++++++++++- .../pipeline/rpi/common/pipeline_base.h | 1 + 48 files changed, 133 insertions(+), 50 deletions(-)