From patchwork Mon Nov 9 09:49:35 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 28798 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 55644C3307 for ; Mon, 9 Nov 2026 09:50:03 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3876C691DB; Mon, 9 Nov 2026 10:50:00 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="RdfNhK3L"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3575668FD7 for ; Mon, 9 Nov 2026 10:49:58 +0100 (CET) Received: from pb-laptop.local (185.221.143.99.nat.pool.zt.hu [185.221.143.99]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A9698802 for ; Mon, 9 Nov 2026 10:47:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1794217656; bh=1o9ktKBPD84PrSqifWG/w6dxUm7GL+eGGKBo4vcd9dg=; h=From:To:Subject:Date:From; b=RdfNhK3LexepAPSzEcf04GiRgq+rsk/4gHfgf+2V+fLcoJd1bhcJ6OxO6FxgJskJx p+G2rVtKsVciiLGXD9DwWFXtVfK9P+WcTZOTX0KqNX8JSA/LGzygpA39kfNM9lLZjp 2Wrzoz4ngRq62iqfu7ZhDhgvRomwsDfMQxpoOGEM= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [PATCH v7 00/19] ipa: libipa: agc: Take exposure margin into account Date: Mon, 9 Nov 2026 10:49:35 +0100 Message-ID: <20261109094954.341480-1-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.56.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The maximum available exposure depends on the frame duration, but this is not considered by the current agc implementation, it fixes the maximum exposure time based on whatever configuration was used to configure the algorithm. This means that in certain situations the full exposure range might not be used, even in dark scenes. This a seventh attempt at adapting https://patchwork.libcamera.org/project/libcamera/list/?series=5590 on the current master branch. But now that the agc handling is largely unified, fewer changes are needed to make this work on every platform. So effectively only patch 7 is taken directly, but only the exposure margin introduction part of it. This was mainly tested on rkisp1+imx219, softisp+ov2740, rppx1+imx708. changes in v7: * drop "Maximize" * [2/22] add link to https://gitlab.freedesktop.org/camera/libcamera/-/work_items/373 * [6/22] keep `lastStageGain` but still restructure to avoid double clamp * drop "ipa: libipa: agc: Take parameters from active state for calculation" due to regression changes in v6: * rebase changes in v5: * [4/24] clarify that the stage gain only constrains the analogue gain * [6/24] adjust documentation as well * [6-7/24] split the moving of the tuning file parsing code * [10/24] avoid clamping the last stage params twice * [23/24] rename `hasExposureStages` -> `hasExposureModes` * [24/24] clamp manual exposure time when it is propagated to a frame and in `process()` changes in v4: * only add "maximize" exposure mode * it is "overridable" by the tuning file * only added implicitly if the tuning file has no stages * keep frame duration below 30 fps by default * keep frame duration above 15 fps by default if no stages are provided changes in v3: * last stage is hard limit * two new exposure modes: "maximize", "minimize" * no slower than 10 fps changes in v2: * report `FrameDurationLimits` in metadata * add exposure margin to more sensor helpers v6: https://patchwork.libcamera.org/cover/28735/ v5: https://patchwork.libcamera.org/cover/28666/ v4: https://patchwork.libcamera.org/cover/28617/ v3: https://patchwork.libcamera.org/cover/28367/ v2: https://patchwork.libcamera.org/cover/28367/ v1: https://patchwork.libcamera.org/cover/28111/ Barnabás Pőcze (18): ipa: libipa: exposure_mode_helper: Remove defaulted destructor ipa: libipa: exposure_mode_helper: Keep stage params together ipa: libipa: exposure_mode_helper: Remove limit getters ipa: libipa: agc: Move tuning file parsing ipa: libipa: agc: Split tuning data fallback handling ipa: libipa: exposure_mode_helper: Consider last stage as hard-limit ipa: libipa: agc: Do not report auto controls if not available ipa: libipa: agc: Keep frame duration limits ordered ipa: libipa: agc: Retrieve `FrameDurationLimits` earlier ipa: libipa: agc: Report `FrameDurationLimits` ipa: libipa: agc: Calculate vblank and frame duration sooner ipa: libipa: agc: Better respect frame duration limits libcamera: pipeline: Set vblank on more platforms ipa: libipa: agc: Rework frame duration limit calculation ipa: libipa: agc: Move control info map setup ipa: libipa: agc: Do not run faster than 30 fps by default ipa: libipa: agc: Do not run slower than 15fps by default ipa: libipa: agc: Take exposure margin into account Jacopo Mondi (1): ipa: camera_sensor_helper: Introduce exposure margin src/ipa/ipu3/algorithms/agc.cpp | 2 +- src/ipa/ipu3/ipu3.cpp | 3 +- src/ipa/libipa/agc.cpp | 614 +++++++++++++++---- src/ipa/libipa/agc.h | 22 +- src/ipa/libipa/agc_mean_luminance.cpp | 318 +--------- src/ipa/libipa/agc_mean_luminance.h | 22 +- src/ipa/libipa/camera_sensor_helper.cpp | 68 ++ src/ipa/libipa/camera_sensor_helper.h | 2 + src/ipa/libipa/exposure_mode_helper.cpp | 81 +-- src/ipa/libipa/exposure_mode_helper.h | 18 +- src/ipa/mali-c55/algorithms/agc.cpp | 2 +- src/ipa/mali-c55/mali-c55.cpp | 3 +- src/ipa/rkisp1/algorithms/agc.cpp | 2 +- src/ipa/rkisp1/rkisp1.cpp | 4 +- src/ipa/softisp/algorithms/agc.cpp | 2 +- src/ipa/softisp/softisp.cpp | 3 +- src/libcamera/pipeline/ipu3/ipu3.cpp | 1 + src/libcamera/pipeline/mali-c55/mali-c55.cpp | 1 + src/libcamera/pipeline/simple/simple.cpp | 1 + 19 files changed, 641 insertions(+), 528 deletions(-) --- 2.56.0