From patchwork Mon Feb 17 14:26:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 2840 Return-Path: Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3615461937 for ; Mon, 17 Feb 2020 15:28:14 +0100 (CET) Received: by mail-wm1-x32f.google.com with SMTP id q9so17338128wmj.5 for ; Mon, 17 Feb 2020 06:28:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id; bh=BhEpKTpqUjTTE5Ox1bsYk1sy+oLIUxNm5htRak7q+/Y=; b=iKYzgHZQ0A/lQjpBRzl9iEg3pxEbv1Yp0lLlhzYZGrNW5Fn7NFkwc1QZsCFqYU78X4 +eCBUaypSHuUvvkSKd8gg/OYUlH2J/F1MgnSOBYY2/v7DSBzu2aMghgcPzx5qHwZ3DQr vzudw//VBLaNtNgB0hYn8SYtD1O+zOcA1sjJyoQw1gaygiQSFK3vKghb0HF89KocK/IS 9gdkaPzfXCI/8TrvyG+FoXcXNgBlRVFrMmhjSwhZsy9xI5F+pZ4VekuvZQ7hVa6r6HXU tjkxn6ib+VveMEkyU/V595mUJksDNlK1Ei4nTQZxbznPs4TJswizAh/wcDTTi25C92kD MgIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=BhEpKTpqUjTTE5Ox1bsYk1sy+oLIUxNm5htRak7q+/Y=; b=eC2Taru+28yTGlKTcMLOXG1OiTy6NnT2Z/jCiO+awDU01pywecpF/YZnqfi1WcXpjB nLCEFckgfmWzrerfIZ5qlwly5UaEK4Tk3ah9eH3tVFH9xam+wdz8Y5dtqDviZlfsBVYM rU6LgYiYjKfN18PZtoxLK7fjQulhOlvVXSJDMTqk/8Os3X+0Rw1hsUUJrj1JftkelI7V 1HAMdwQFqXaD3y/YT/Ob8UrjyFvWR3ElPuErKLIGzSOzE9lNIHDX6D85DtUL+CHugD83 6VvqA8RpsjoCJEHgiDYIUA79bOWg2WqfO26mK08/lKASPQgFDs/dDMUTIDQ59kd1lP7x SuRQ== X-Gm-Message-State: APjAAAXcLO9Rwz7UIJL5CzPd2LxsEeNrScp2nH+O6CU0+oNoImGtjEaY HHPWclhh2ySRYc5c9fxvmQpzbUlRBA+nvQ== X-Google-Smtp-Source: APXvYqz2ilWPzs7Dsy1UgoQ2flTHro+NkZjMHpkqPDerwcoK0tiMphzkMLppphtArwXFB5djrmpxKA== X-Received: by 2002:a1c:3b87:: with SMTP id i129mr22133421wma.142.1581949693507; Mon, 17 Feb 2020 06:28:13 -0800 (PST) Received: from naushir-VirtualBox.pitowers.org (cust51-dsl50.idnet.net. [212.69.50.51]) by smtp.gmail.com with ESMTPSA id p15sm760960wma.40.2020.02.17.06.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2020 06:28:13 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Mon, 17 Feb 2020 14:26:06 +0000 Message-Id: <20200217142609.22837-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.17.1 Subject: [libcamera-devel] [PATCH 0/3] Patchset for libcamera controls X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Feb 2020 14:28:14 -0000 Hi, I would like to discuss the following patch set. In it are the following changes: 1) Add double and std::string ControlValue types. 2) Update units and types of existing controls. 3) Add new camera controls. There are two main points of discussion for (1). Firstly, I have not added any support for serialisation of these ControlValue types. I understand that the serialisation code is being revamped, so will wait for that to be completed before addressing this. Secondly, from eariler discussions, std::string ControlValue type may not be the most sutiable for AE/AWB modes. Instead we may want to use fixed enum values which makes things a little bit more restrictive. Thoughts? Regards, Naush Naushir Patuck (3): libcamera: controls: Add std::string and double ControlValue type. libcamera: controls: Specify manual gain units and change exposure units libcamera: controls: Add AE/AWB mode, manual and EV controls. include/libcamera/controls.h | 6 +++ src/libcamera/control_ids.yaml | 46 +++++++++++++++++++-- src/libcamera/controls.cpp | 72 ++++++++++++++++++++++++++++++++- test/controls/control_value.cpp | 26 ++++++++++++ 4 files changed, 146 insertions(+), 4 deletions(-)