From patchwork Wed Aug 19 14:15:13 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 27850 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by patchwork.libcamera.org (Postfix) with ESMTPS id CE58EC3308 for ; Thu, 20 Aug 2026 10:50:16 +0000 (UTC) Received: from monstersaurus.ideasonboard.com (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 716D88FD for ; Thu, 20 Aug 2026 12:48:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1787222935; bh=OzvAW3L5/QX0Gg1aamTiTzDkvPg20VuuuE/LjRdkIRQ=; h=From:To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=MAop7AFQUdOTsTSnp2mKdHztR76WWFQuN3Sbmk2DXvVvzWz3dimMvcbT/BsAmIpw4 2ySg1DvKHkUrgYqo+x1YnS/Ltro9tM7cGvJaOxxWnlWCITiUx/xjmBEZfRTUt4SBJ+ 9Z6507TW4+haGmo0PiztbpOV39HgD9/OMYyFsiRk= Received: by monstersaurus.ideasonboard.com (sSMTP sendmail emulation); Thu, 20 Aug 2026 11:50:14 +0100 Delivered-To: kbingham@ideasonboard.com Received: from perceval.ideasonboard.com by perceval.ideasonboard.com with LMTP id ALZpIUa6hWqHaBYA4E0KoQ (envelope-from ) for ; Wed, 19 Aug 2026 16:14:30 +0200 Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by perceval.ideasonboard.com (Postfix) with ESMTPS id F201BA25; Wed, 19 Aug 2026 16:14:29 +0200 (CEST) Authentication-Results: perceval.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.a=rsa-sha256 header.s=mail header.b=JCrew9tQ; dkim-atps=neutral Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CE2B868309; Wed, 19 Aug 2026 16:15:48 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="JCrew9tQ"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DB91E681A1 for ; Wed, 19 Aug 2026 16:15:46 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:84bc:8eb1:e39f:793f]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0069DA25; Wed, 19 Aug 2026 16:14:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1787148866; bh=OzvAW3L5/QX0Gg1aamTiTzDkvPg20VuuuE/LjRdkIRQ=; h=From:To:Cc:Subject:Date:From; b=JCrew9tQ740vG5x5TSH7LRRSPQzRmIUILH4GrOg3AFbu3MN5PhAggS1XmZjtuPOTC +R5cm+r3iF+cHJjs8iaO78MT2REotJfWciqiilPdeW+zJ1rV3BW8W3oNvnN7uKWur+ T9eatLXdx/lfA2WMhvh26K5M0pAsEWQl6ro1EAaM= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v2 0/3] Clarify rectangle behavior Date: Wed, 19 Aug 2026 16:15:13 +0200 Message-ID: <20260819141541.221617-1-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" X-TUID: Jnr6XA97xQYu Hi all, This series changes the behavior of PixelArraySize to represent the physical sensor area instead of the readable pixel area. The reasoning is explained in a bit more detail in patch 1. Patch 2 applies that idea to the IPA interface. Patch 3 adds an additional property for completeness sake which we could drop. With these patches applied I am able to draw proper bounding rectangles in camshark. An implemented is available in https://gitlab.freedesktop.org/camera/camshark/-/tree/sklug/next?ref_type=heads Best regards, Stefan Version 2 adds a lot of fixes and clarification from review. See the changelog on the patches for details. Stefan Klug (3): libcamera: Clarify meaning of PixelArraySize and other rectangles libcamera: ipa: core: Use native coordinates for IPACameraSensorInfo::analogCrop libcamera: ipa: core: Add IPACameraSensorInfo::pixelArraySize property include/libcamera/ipa/core.mojom | 25 +++- src/ipa/mali-c55/algorithms/lsc.cpp | 2 +- src/ipa/rkisp1/algorithms/lsc.cpp | 2 +- src/ipa/rpi/common/ipa_base.cpp | 13 +- src/libcamera/property_ids_core.yaml | 123 ++++++++++-------- src/libcamera/sensor/camera_sensor_legacy.cpp | 33 ++--- src/libcamera/sensor/camera_sensor_raw.cpp | 30 +++-- 7 files changed, 135 insertions(+), 93 deletions(-)