From patchwork Wed Aug 5 15:18:17 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bruce Allen X-Patchwork-Id: 27620 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D602DBDE4C for ; Wed, 5 Aug 2026 15:18:32 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CC18068112; Wed, 5 Aug 2026 17:18:31 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=googlemail.com header.i=@googlemail.com header.b="mQMueODa"; dkim-atps=neutral Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F8906805D for ; Wed, 5 Aug 2026 17:18:30 +0200 (CEST) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-498028b3d5eso10805445e9.1 for ; Wed, 05 Aug 2026 08:18:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20251104; t=1785943110; x=1786547910; darn=lists.libcamera.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=UJwhrH5+7/RFudWtYkVpy85KGL3t9fkFJDjBCyu5RhM=; b=mQMueODaQMbhhnW/2/8N0AcnmbxXHYWc7MbU/oVq+WJnn1cWQMq42l7qKjNDNibdIK uM7kiuHlh7AHqRzf4n/54THx3e2wkM01CJpwZ+IaIGWZS4hWbUIq8od6z603kN0KYxT4 UXwlmFE1TZFZPBsSp5gXFHjpACyYSi5fYHJ8xRMffTPSCEkapfPrOG9Sc4UUBfS4q9ds r9bWZJtHsN+aGCjs1/b+HEQAtkUQAr1XDrr9xZfyPIg4fOHqazmInVL+brHhi6IDsEPa AbAXMqy+7MufrrsHkr9/E9Dnw3/XIqpNgPN5U13rs1muAB3XkwqYooq8iBnXF2QuBIwN +/0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785943110; x=1786547910; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UJwhrH5+7/RFudWtYkVpy85KGL3t9fkFJDjBCyu5RhM=; b=fUuYJwnC0UTrzkH8usBMImBoBDXw0tkZMUfJ3+StrkrJ3Qmvnx+Cg6wEnXu7IihnjN 5T1ENm3zSKLOL38u4QasrhbePsA8ZgsRtPBn8yyfGGavrUwfxTtmEX2co3PszzUINl/u EUCn6IlNB5CvxpZ+izo2nVW0Cp0DDdlEsohpovWYYSwUPsqUwc9qJ1qlylQ2pALwIc8I 1A5S4gUFckF5Dku9fhaTRCsz62JDnVJj66RgfdXBnkGrYE6VnBndRNTiv8A6n0xCsjTY P+HMrFkXWwRm8EAiShwJxsoXpvEQsvRBg2XysxtkhbZUPIf9xRlOWYQSSn+wpzDRQzYi oksw== X-Gm-Message-State: AOJu0YwvJAWQYGr8z/MIN0tcf3QXjdnqYT4946wk565ksYb2lieSkjNB 5IcFP9Hr1GIUHP4XAP5TZUfnaevd8PlTnRVSpKlCJt50tt3ZvrI6WzwcNUCMlA== X-Gm-Gg: AR+sD10BM6mJymKbzPdg1/7FY4ZIYS/HXJZk1fHUJJoLCE4o4f8jaldK3BI3lBfaCsg OaJEz9GJBqwu10wqPaQBjfkadEy1YNSL0rVVgJfpBkCBItiUGMaiTJ9K4UWWbYtETOLeBikxvgB 4PnyNAihj+MbTZlxjErGpkev9wQ1b2+Gh3JeewIJaL/lJadPrK+X6lO5yq5gSDScAFBBv9PicHR svaFOSHMWS7LsoBSeqG8g571TF19nGTKA7Uepi8XY5sLWe6fJ1vVB9g+lfqnYgOBRzD8JdqxWCS EnNB9o5nYYzeUCATHex930nq82ZQl/itqWxpmyhNgqsKGtwUVdnIFAzuOQF9ENbCoQzHP0ddVFq PmwX3ffQ0j2pNxhUXT3vMY2zxKvaIQLx9b4CLXdoh9JXmUwxFJkGhM5iSGNnEgI9o4mr2XPFu32 +WhUjBFDy8LTijM826QNConCLdpdl7GThj7k72BB4M++IC4tG73KE4XJFlxTWKwc4tofYfPTRRX zDPkhe68hELlN4NiQW0mgKAucjT X-Received: by 2002:a05:600c:a597:b0:499:4d50:7230 with SMTP id 5b1f17b1804b1-4994e7d9c03mr62890695e9.18.1785943109815; Wed, 05 Aug 2026 08:18:29 -0700 (PDT) Received: from localhost.localdomain ([194.94.98.191]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994e52d819sm47193625e9.1.2026.08.05.08.18.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 08:18:29 -0700 (PDT) From: Bruce Allen To: libcamera-devel@lists.libcamera.org Cc: barnabas.pocze@ideasonboard.com Subject: [PATCH v3 0/2] libcamera: Add SensorSequence request metadata control Date: Wed, 5 Aug 2026 17:18:17 +0200 Message-ID: <20260805151819.16382-1-ballen4705@googlemail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260703224817.15650-1-ballen4705@googlemail.com> References: <20260703224817.15650-1-ballen4705@googlemail.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi Barnabás, Thank you for the review, v3 follows. These are documentation-only changes in response to your comments: - Request metadata is a subheading under Handle request completion events, just before Request queueing. - Metadata is described via ControlId::direction() / Direction::Out, not YAML. - Dropped the explicit template argument from the ControlList::get() example. I did NOT remove the static_cast calls in the pipeline code; if that is what you intended, I will do so in a follow-up. [Note that FrameMetadata::sequence is unsigned int whereas FrameMetadata::timestamp is already uint64_t.] - SensorSequence details moved into the SensorSequence control docs. - Documented stop/start: sequence restarts from 0 each session. - Documented presence: when SensorTimestamp is set on a successful frame, SensorSequence is also set. My opinion regarding fail-on-drop vs SensorSequence: I prefer not to fail requests on drops. That would break existing apps and force one policy on everyone. Drops matter in some use cases and not others. SensorSequence lets the application decide. Cheers, Bruce