From patchwork Thu Jun 18 12:38:17 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 26964 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2E6FBBF415 for ; Thu, 18 Jun 2026 12:38:52 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0DD27656CF; Thu, 18 Jun 2026 14:38:50 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="D+tFJGj3"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8379862988 for ; Thu, 18 Jun 2026 14:38:48 +0200 (CEST) Received: from pb-laptop.local (185.182.214.63.nat.pool.zt.hu [185.182.214.63]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 897702F8 for ; Thu, 18 Jun 2026 14:38:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1781786293; bh=VoUPeITHXWUs+a7MgV/CqqfUgdu3jd0Z3hyUw9Apg8s=; h=From:To:Subject:Date:From; b=D+tFJGj32zYO/GycYtsjR4WsqDkC0rWb/8M/NSAxreLjjmRwGs1vjO2rdW/svrq1r UExxuCi+nFe96dPtdKbqveva26e+6rccqE96yuiZeO/lP1B5PCdAWR/7DnAvR8qFgP gn0nZnF5tFAwHWJKcrPxLi1IsX6q2oTQQmMtZJ0Y= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 00/27] Misc. changes before request-buffer split Date: Thu, 18 Jun 2026 14:38:17 +0200 Message-ID: <20260618123844.656396-1-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This is a collection of miscellaneous, intended to be non-functional changes that I have made while working on the request-buffer split prototype. Some are requirements of that, and some are just random changes. But most of these should be easy to review. Barnabás Pőcze (27): apps: cam: Simplify buffer reuse libcamera: request: Inline `Private::hasPendingRequests()` libcamera: request: hasPendingBuffers(): Simplify libcamera: request: Disassociate buffer when cancelling libcamera: software_isp: Replace open-coded buffer cancellation libcamera: pipeline: Replace open-coded buffer cancellation libcamera: pipeline: imx8-isi: Use `completeBuffer()` return value libcamera: pipeline: imx8-isi: pipeFromStream(): Take `ISICameraData` libcamera: pipeline: ipu3: Remove `setRequest()` calls libcamera: pipeline: mali-c55: Add missing `` include libcamera: pipeline: rkisp1: Simplify dewarper configuration libcamera: pipeline: rpi: Remove `requestQueue_` libcamera: pipeline: virtual: Make copy of request's buffer map libcamera: camera: Add missing `span.h` include libcamera: request: completeBuffer(): Emit `bufferCompleted` here libcamera: pipeline_handler: completeBuffer(): Inline and `static` libcamera: pipeline_handler: Use `std::deque` py: examples: simple-continuous-capture: Fix comment py: cam: Remove unnecessary check gstreamer: allocator: get_pool_size(): Fix return value gstreamer: Use `FrameBuffer` cookie to associate with `GstBuffer` v4l2: v4l2_camera: Avoid a level of indirection v4l2: v4l2_camera: Use actually allocated buffer count v4l2: v4l2_camera: Use buffer cookie for indexing v4l2: v4l2_camera: Rename `Buffer` to `CompletedBuffer` v4l2: v4l2_camera: Always clear pending requests v4l2: v4l2_camera: Provide buffers one by one include/libcamera/camera.h | 1 + include/libcamera/internal/camera.h | 7 +- include/libcamera/internal/pipeline_handler.h | 7 +- include/libcamera/internal/request.h | 2 +- src/apps/cam/camera_session.cpp | 7 +- src/gstreamer/gstlibcameraallocator.cpp | 2 +- src/gstreamer/gstlibcamerasrc.cpp | 37 ++++---- src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 24 +++-- src/libcamera/pipeline/ipu3/cio2.cpp | 3 +- src/libcamera/pipeline/ipu3/cio2.h | 3 +- src/libcamera/pipeline/ipu3/frames.cpp | 3 - src/libcamera/pipeline/ipu3/ipu3.cpp | 16 +--- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 1 + src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +- .../pipeline/rpi/common/pipeline_base.cpp | 31 ++---- .../pipeline/rpi/common/pipeline_base.h | 2 - src/libcamera/pipeline/rpi/pisp/pisp.cpp | 6 +- src/libcamera/pipeline/rpi/vc4/vc4.cpp | 6 +- src/libcamera/pipeline/vimc/vimc.cpp | 7 +- src/libcamera/pipeline/virtual/virtual.cpp | 40 ++++---- src/libcamera/pipeline_handler.cpp | 15 +-- src/libcamera/request.cpp | 11 ++- src/libcamera/software_isp/software_isp.cpp | 6 +- src/py/cam/cam.py | 4 - src/py/examples/simple-continuous-capture.py | 2 +- src/v4l2/v4l2_camera.cpp | 79 +++++++-------- src/v4l2/v4l2_camera.h | 21 ++-- src/v4l2/v4l2_camera_proxy.cpp | 95 +++++++++---------- src/v4l2/v4l2_camera_proxy.h | 2 - 29 files changed, 188 insertions(+), 257 deletions(-) --- 2.54.0