From patchwork Tue Jun 16 12:08:13 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 26904 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4BECBC3261 for ; Tue, 16 Jun 2026 12:08:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 89B0E625CE; Tue, 16 Jun 2026 14:08:47 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ic+pfUzK"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E1E9B625B6 for ; Tue, 16 Jun 2026 14:08:45 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:f9ec:e24d:190b:e780]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5FF77448; Tue, 16 Jun 2026 14:08:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1781611692; bh=CWWxbIfUPYof2pfF4noz5U0omZ3K5g3EhA5UrWQT1B0=; h=From:To:Cc:Subject:Date:From; b=ic+pfUzKV85eU3EpDfreZagL6tEHMCtYgm8av17Cugv/jAmS04gHQH6DkG+rDLatv 4ql2F9qU1f3z1us8ASewsls5k0v+ZlEY095nvbFi+hI/3Y/WhnBG7SsLNB9wbCZ6va 1xXSfn1JoXF7K+SW0I2UjHoHINwcIWzKTzY15Ysk= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v1 0/2] Clarify rectangle behavior Date: Tue, 16 Jun 2026 14:08:13 +0200 Message-ID: <20260616120828.375547-1-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi all, This series changes the behavior of PixelArraySize to represent the physical sensor area instead of the readable pixel area. The reasoning is explained in a bit more detail in patch 1. Patch 2 is a small cleanup that also shows how limited the impact on the overall project is. With these patches applied I am able to draw proper bounding rectangles in camshark. An implemented is available in https://gitlab.freedesktop.org/camera/camshark/-/tree/sklug/next?ref_type=heads Best regards, Stefan Stefan Klug (2): libcamera: Clarify meaning of PixelArraySize and other rectangles libcamera: ipa: core: Rename IPACameraSensorInfo::activeAreaSize to pixelArraySize include/libcamera/ipa/core.mojom | 6 +- src/ipa/rkisp1/algorithms/lsc.cpp | 6 +- src/ipa/rpi/common/ipa_base.cpp | 4 +- src/libcamera/property_ids_core.yaml | 116 ++++++++++-------- src/libcamera/sensor/camera_sensor_legacy.cpp | 28 +++-- src/libcamera/sensor/camera_sensor_raw.cpp | 18 ++- 6 files changed, 96 insertions(+), 82 deletions(-)