From patchwork Thu May 7 21:37:18 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 26686 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by patchwork.libcamera.org (Postfix) with ESMTPS id D9699BDCBD for ; Fri, 8 May 2026 08:21:52 +0000 (UTC) Received: from monstersaurus.ideasonboard.com (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 342E9ABF for ; Fri, 8 May 2026 10:21:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1778228508; bh=Kl3dzpxkJ5yf1PNGE9T3VaqDhT1d+VE8PlUF/rEQtk8=; h=From:To:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:Resent-From:Resent-To:From; b=h3Q3T2TTwb6BSFtczTXoTF8ZYDh0+wDVHkZaLzqpdWMYS19nEhQckMrXeIwjj5U0J 99l9KbRNvK1XL0AshCpBnfMCj6id7wzojIfewqKNWvKG2G8Me//0x8GrQzykcm6Pox kUdZ7UP0x0sksHe6qbJc5KEXtHaab1uk77LRHgv8= Delivered-To: kbingham@ideasonboard.com Received: from perceval.ideasonboard.com by perceval.ideasonboard.com with LMTP id h86GBhMG/WmmahUA4E0KoQ (envelope-from ) for ; Thu, 07 May 2026 23:37:23 +0200 Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by perceval.ideasonboard.com (Postfix) with ESMTPS id 90FCE1E30; Thu, 7 May 2026 23:37:22 +0200 (CEST) Authentication-Results: perceval.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.a=rsa-sha256 header.s=mail header.b=wZzaUyoa; dkim-atps=neutral Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 537C763029; Thu, 7 May 2026 23:37:25 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="wZzaUyoa"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2561D62010 for ; Thu, 7 May 2026 23:37:23 +0200 (CEST) Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 737CA1121 for ; Thu, 7 May 2026 23:37:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1778189838; bh=Kl3dzpxkJ5yf1PNGE9T3VaqDhT1d+VE8PlUF/rEQtk8=; h=From:To:Subject:Date:From; b=wZzaUyoaIclTUQMwNNxOKq4KkEM4vLQyWkiFn05OJM8+wSAlK3hQ7xNVgjWEA4E1w xX7+eGpIa+Enh8hXT1xPRK5X6GuK+KgA4D4FDesS9Muz4ukfRzVXMgO7RaMIgqIgSk QuUKqYs5sadwi16v4cIII5SviVBSCTCEdjxRorgY= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Subject: [PATCH 0/3] ipa: libipa: Avoid code duplication in V4L2Params Date: Fri, 8 May 2026 00:37:18 +0300 Message-ID: <20260507213721.2137448-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" X-TUID: NPYFX67b/o4G Resent-From: Kieran Bingham Resent-To: parsemail@patchwork.libcamera.org Hello, This small patch series improves V4L2Params by sharing common code between specializations of the class template. Patch 1/3 is a small drive-by comment improvement. Patch 2/3 prepares for code sharing by turning a template-dependent function argument into a generic type, and patch 3/3 then moves code to a non-template base class. Laurent Pinchart (3): ipa: libipa: v4l2_params: Mention ISP in file one-line description ipa: libipa: v4l2_params: Enforce uint16_t for id_type underlying type ipa: libipa: v4l2_params: Move non-template code to new base class src/ipa/libipa/v4l2_params.cpp | 153 ++++++++++++++++++++++++--------- src/ipa/libipa/v4l2_params.h | 90 ++++++------------- src/ipa/mali-c55/params.h | 4 +- src/ipa/rkisp1/params.cpp | 3 +- src/ipa/rkisp1/params.h | 4 +- 5 files changed, 145 insertions(+), 109 deletions(-) base-commit: 39d8133fd17c1e963981490105a154d78eb6cb43