From patchwork Mon May 4 09:16:41 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Bretschneider X-Patchwork-Id: 26610 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 03B70BDCB5 for ; Mon, 4 May 2026 09:16:50 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id AF87D63024; Mon, 4 May 2026 11:16:49 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=protonmail.com header.i=@protonmail.com header.b="No286Fht"; dkim-atps=neutral Received: from mail-4325.protonmail.ch (mail-4325.protonmail.ch [185.70.43.25]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E84CA62DC4 for ; Mon, 4 May 2026 11:16:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1777886207; x=1778145407; bh=wubbBnVLOSzVo5rdG17QaliLf57kLlIXTgS1XckNOAc=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=No286Fht2Sdl1t23gMuLbxm58+V9a5OidikaU1gtftL5WS7qK7jxbaZgAQkN0mPML VZb2ScoXayoFmfKtLBcGnJ6s1dSWtowdQFUVSrPFe6GuXZrxF5Ez3D9Jl521m4DaO8 0qZE4GfGjx2ug6W7l2e4PkNVvbDK4gqNHEpBZnghvtqzE6lLPEMCKfLPMTLgLRFZRd YEmCCjKeaM4T2ERlIvw+NQE2jtxFuSxm1YFlV5MBE52J9e3CEz/1Z+SFGw9XaN0Jch K5pNjETK6uHhgNkDVZwEJV63h5riLuyqEdsw71FVeaUOAwvCCPp2VE9/O3P8sI7RR3 rmUmBybKnqEVA== Date: Mon, 04 May 2026 09:16:41 +0000 To: libcamera-devel@lists.libcamera.org From: maxbretschneider@protonmail.com Cc: Max Bretschneider Subject: [RFC PATCH v2 0/2] libcamera: pipeline: virtual: Add raw Bayer frame support Message-ID: <20260504091623.3354474-1-maxbretschneider@protonmail.com> In-Reply-To: <20260501105137.439519-1-maxbretschneider@protonmail.com> References: <20260501105137.439519-1-maxbretschneider@protonmail.com> Feedback-ID: 122687743:user:proton X-Pm-Message-ID: 2214dfea6da114fb29dd57c23f21cde21759f398 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Max Bretschneider Changes since v1: - Squashes config parser and Bayer format support into one commit in order to maintain the bisectability. The virtual pipeline handler currently only produces NV12 output, either from test patterns or JPEG files. This means that SoftISP, which processes raw Bayer data, cannot be tested without physical camera hardware. A first step to achieving this would be to support raw streams in the virtual pipeline handler. This series introduces a RawFrameGenerator that reads binary raw Bayer files from disk and serves them through the virtual pipeline. The introduced changes are opt-in through the YAML configuration. If virtual cameras are configured with raw_frames, the new code path is chosen, paths for the existing test_patterns and frames are unaffected. The SoftISP part of this patch's motivation is complemented by David Plowman's series, which introduced the CameraSensorMemory class (https://patchwork.libcamera.org/patch/25468/), since SoftISP needs an actual CameraSensor for correct construction. The idea is that in the future it can be used together to serve Raw frames through the virtual pipeline and process them with SoftISP, for example for CI tests or more easily reproducible benchmarks. Testing: I have used `dd` to create zero filled raw frames to test things such as format negotiation, buffer sizing, general frame flow, config parsing (both right/wrong, e.g. rejecting invalid input) and bit depth handling. I've written a small bash script to essentialy automate this for all n : { 8, 10, 12, 14, 16 } and the four Bayer formats in accordance to `src/libcamera/formats.yaml`. I then used numpy to test the generateFrame() functionality by generating a known frame with content, capturing it through the pipeline to disk with the cam application and then reading the output back again to verify that all the pixels match the expected values. I noticed that the pipeline handler components currently have no dedicated test coverage, if I missed them or if there is some preferred approach for adding additional testing I'd be open to any suggestions. For now I can also share my scripts if thats wanted. Ran `git clang-format` as well as the `checkstyle.py`. I've run the Meson tests both with and without the changes and get the same: Ok: 51 Expected Fail: 1 Fail: 1 Unexpected Pass: 0 Skipped: 29 Timeout: 0 Open questions: - The sensor properties set in match() are currently hardcoded, and I've left them with a \todo. Especially since we've also discussed adding controls such as Exposure and AnalogueGain in "[RFC] Decouple SoftwareISP from CameraSensor for virtual pipeline testing": Should I move these directly to the yaml as well or proceed differently? - I've written a lambda to derive the pixel format, but at this point it has gotten quite large. Maybe this could also be a 2D lookup table or something else that is cleaner. On that lambda also: all cases are covered I think, but the default case is 16, I wasn't sure if 16 should also be made an explicit case and something more sensible should be chosen for the default. - Between the raw_frames and the frames path, the file collection logic is now also duplicated. Should I add a helper here to change this? - Currently every frame is read into framesDatas_ immediately at startup. Depending on the number and the size of the raw files, this could take up quite a lot of memory. For the use cases I thought of (e.g. CI) this would be fine, since the number of files would probably be comparatively small there. Still I wanted to bring it up. - We weren't sure if the SPDX license header is fine like this. For the moment I've just placed my intern company mail, is this fine as is? Documentation: I've added documentation according to the coding-style.rst, if my comments are not sufficient I'd be happy to add more of course. AI Disclosure: I've used DeepWiki to familiarize myself with the libcamera repository and to point me at reference implementations and patterns to use as orientation. Thank you all for your time! Max Bretschneider (2): libcamera: pipeline: virtual: Add RawFrameGenerator libcamera: pipeline: virtual: Add raw_frames config and Bayer format support .../pipeline/virtual/config_parser.cpp | 100 ++++++++++++- src/libcamera/pipeline/virtual/meson.build | 1 + .../pipeline/virtual/raw_frame_generator.cpp | 131 ++++++++++++++++++ .../pipeline/virtual/raw_frame_generator.h | 47 +++++++ src/libcamera/pipeline/virtual/virtual.cpp | 123 +++++++++++++--- src/libcamera/pipeline/virtual/virtual.h | 3 +- 6 files changed, 382 insertions(+), 23 deletions(-) create mode 100644 src/libcamera/pipeline/virtual/raw_frame_generator.cpp create mode 100644 src/libcamera/pipeline/virtual/raw_frame_generator.h