From patchwork Fri Apr 24 20:02:46 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 26561 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id F3D96BE173 for ; Fri, 24 Apr 2026 20:03:09 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3241F62E6A; Fri, 24 Apr 2026 22:03:09 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="Z+MRdY9d"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 47E4562E6A for ; Fri, 24 Apr 2026 22:03:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777060985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GFsIf0hiaiZkuicR8YBjX+TP5FttM/2zZKzeBJLT/dU=; b=Z+MRdY9dBzYYrMMCH989AUL6z/iAXXDWzCSkvz5pmMXAL4NVXJOIFK/yAsxeF9ClHP5eSt Y/xIrxLTBC1895enFzuG+lTgT3hoKUbQiD7mYfsJZ9FE4JQkuPsImb7FL2r4raVh4oicf5 Q25PHN6nYYtJv+5AnBuKdBSfSmnZw/M= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-J50PTPOdOtKIWR02cCfHvw-1; Fri, 24 Apr 2026 16:03:03 -0400 X-MC-Unique: J50PTPOdOtKIWR02cCfHvw-1 X-Mimecast-MFC-AGG-ID: J50PTPOdOtKIWR02cCfHvw_1777060982 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 081901800451; Fri, 24 Apr 2026 20:03:02 +0000 (UTC) Received: from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.33]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 52CB430078C0; Fri, 24 Apr 2026 20:02:59 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Bryan O'Donoghue , Hans de Goede Subject: [RFC PATCH v3 0/7] LSC for SoftISP simple pipeline Date: Fri, 24 Apr 2026 22:02:46 +0200 Message-ID: <20260424200255.356798-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vyJdlPtU6Yoo1UKQGnWR7CcsId0uw7lIKgm_RXUFBUc_1777060982 X-Mimecast-Originator: redhat.com X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone, Over the last few months we (students from THUAS) have been working on adding LSC support to the SoftISP simple pipline. These patches are the result of those efforts. The project was under the supervision of Hans de Goede. There are patches to both the GpuISP and some scrips for generating the corrections tables. The changes to the GpuISP are integrated as an algorithm, including automatically choosing a correction table based on the measured colour temperature. The current version of the LSC textures make use of the type GLubyte instead of float. This is because we could not get floating points values to play nice with the shader. The result is that the LSC factors ranging from 1.0 to 4.0 are maped to 0 to 255. The last patch (HACK: Add test LSC to src/ipa/simple/data/uncalibrated.yaml) adds sample data to uncalibrated.yaml file for testing, and is a reference of how the tables should (currently) be structured. Regards, Xander Pronk, Rick ten Wolde, Derek Gielen, Aron Dosti. Taken over by Milan Zamazal: Changes in v3: - LSC scripts patch dropped due to missing licences. - DO_LSC -> APPLY_LSC - textureUniformLsc_ is assigned unconditionally now. - New constant DebayerParams::kLscBytesPerCell. - LSC values in the tuning file are floats now and converted to bytes internally. - Source code comments added to clarify the usage of the byte LUTs. Changes in v2: - Remaining issues from the reviews (hopefully) addressed. - Especially there is only a single texture now and LSC is fully conditional. - Major cleanup, hacks removed or replaced, typo fixes, cosmetic changes, making linters happy, etc. - See https://lists.libcamera.org/pipermail/libcamera-devel/2026-January/056883.html for an example how to add the grid data. It’s posted as RFC because: - It’s not yet completely tested although it seems to be working in my environment. - The GPU ISP is going to be changed to multipass soon, which may require changes in this patch series; similarly with the libipa effort. Milan Zamazal (2): ipa: simple: Introduce default temperature value libcamera: software_isp: Pass LSC availability to debayering Xander Pronk (5): libcamera: software_isp: egl: Add gl_scale_param to createTexture2D() libcamera: software_isp: Add LSC data to DebayerParams ipa: simple: Add LSC algorithm libcamera: shaders: Add LSC support libcamera: software_isp: debayer_egl: Add LSC support include/libcamera/internal/egl.h | 3 +- .../internal/software_isp/debayer_params.h | 7 ++ .../internal/software_isp/software_isp.h | 1 + include/libcamera/ipa/soft.mojom | 4 +- src/ipa/simple/algorithms/awb.cpp | 4 +- src/ipa/simple/algorithms/awb.h | 4 +- src/ipa/simple/algorithms/ccm.cpp | 5 +- src/ipa/simple/algorithms/lsc.cpp | 81 +++++++++++++++++++ src/ipa/simple/algorithms/lsc.h | 41 ++++++++++ src/ipa/simple/algorithms/meson.build | 1 + src/ipa/simple/ipa_context.h | 3 +- src/ipa/simple/soft_simple.cpp | 7 +- src/libcamera/egl.cpp | 8 +- src/libcamera/shaders/bayer_1x_packed.frag | 9 +++ src/libcamera/shaders/bayer_unpacked.frag | 9 +++ src/libcamera/software_isp/debayer.cpp | 24 ++++++ src/libcamera/software_isp/debayer.h | 3 +- src/libcamera/software_isp/debayer_cpu.cpp | 3 +- src/libcamera/software_isp/debayer_cpu.h | 3 +- src/libcamera/software_isp/debayer_egl.cpp | 34 +++++++- src/libcamera/software_isp/debayer_egl.h | 9 ++- src/libcamera/software_isp/software_isp.cpp | 5 +- 22 files changed, 247 insertions(+), 21 deletions(-) create mode 100644 src/ipa/simple/algorithms/lsc.cpp create mode 100644 src/ipa/simple/algorithms/lsc.h