From patchwork Fri Jan 23 12:59:02 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Vuillaumier X-Patchwork-Id: 25954 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 19084BDCBF for ; Fri, 23 Jan 2026 12:59:42 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 43A6C61FC9; Fri, 23 Jan 2026 13:59:41 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="Ne27ZxT6"; dkim-atps=neutral Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazlp170100001.outbound.protection.outlook.com [IPv6:2a01:111:f403:c201::1]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A9464615B2 for ; Fri, 23 Jan 2026 13:59:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=M8eDISAAwqJoHYwRM1DHegv3Q3jcu27x7is1o1PCnO11XA1VAw0Q/Uu8ELXRhcGvSgLkb1PtaFXAWoStbJb5lho4ENF5CxM3e2qxNvDNt0ChzTCe/mjDxf53U+WFzdt/lsO7QQoQ3WVC8JM8evUi5jHo2cHnvRbwZSBdTDa/qDVRpa7Dld1k8KHgkIOibjcUoaTbbjo0khfxUI0LkezxLqZguTa36x6ULawTc5uB1RCFZ2VWmAoRraw/dbxOcSLsIh5GtcCishtWXqRvH+xI+ykGxjJvN5fEeP2yDHjELE7BFp0d/qwQLmMIlBxohEAsjm3MfDfemMXilaIb8H4b2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1uTF/bsZXm+K/XY87G9qgsJM/ahc9hbWNJ44QbMYmMs=; b=LYP6nHnUTYfwk/Vd2KEPHnqAlABQETmiwyuTdUlRIR8BpPWOrKlspnSMvxSUMpOessx8sTkn6u6MmPenvNUS/wrm0Zyen6re7Aeqh+XAN/bJXk16Qrs/8y+epWGh87T2Oty+woSjvH91DOnTMAFjAMGSas9r+YRGvh5EIbAHtpSuONJDYc2yknp3+sI5GiqBffWVG6DAZCS47msIEHkkcRSVWYQkaMQ+GE3RJV8nXTtUCrH85Gg7H65UZDnfEJ4X3cfZg2TqDQ4oJ2tLeEFODqoSqGmS7Uditf4OhB4LRx8T9ZAVGauCm10aAyguTM3+D0mbRXxSvkugg5DSU7JPsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1uTF/bsZXm+K/XY87G9qgsJM/ahc9hbWNJ44QbMYmMs=; b=Ne27ZxT61Cg1oT8/PC1qpI1gLZ/0MHe6sO60KJhdn83RpzJLfpC6ZPHs7ryFNbwHYuWUrz1n9W0imK1pVFlzeZbjlhmFnaLkxJFm2wp6Fh69Y8ZThhYgjtoD1kzlvWV0GkqGj2oPEbSKSgFHHZt6bKQNMhZa33l94P3Pao7HPQUaAfs8c5qKbogmVi6QcX+qr+dg2dWEp5jodQ+F+9nXuDp0Bz6gv1/zKopeqtYajDynT9DIhdLra5egwjPqdNAJieqokhnRnAREgGJpUj3Cn73Iz7srXcIkbEOhD6nhgUxC2hUiQpgPhQnSURRzu4+wHXLJ0hy4YsyOHHlbinolZQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM9PR04MB8147.eurprd04.prod.outlook.com (2603:10a6:20b:3e0::22) by GVXPR04MB11690.eurprd04.prod.outlook.com (2603:10a6:150:2e5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.11; Fri, 23 Jan 2026 12:59:36 +0000 Received: from AM9PR04MB8147.eurprd04.prod.outlook.com ([fe80::b387:72c6:e33c:8656]) by AM9PR04MB8147.eurprd04.prod.outlook.com ([fe80::b387:72c6:e33c:8656%7]) with mapi id 15.20.9542.009; Fri, 23 Jan 2026 12:59:36 +0000 From: Julien Vuillaumier To: libcamera-devel@lists.libcamera.org Cc: Julien Vuillaumier Subject: [PATCH v2 0/1] libcamera: camera_sensor: Fix imageStream() for CameraSensorLegacy class Date: Fri, 23 Jan 2026 13:59:02 +0100 Message-Id: <20260123125903.2469016-1-julien.vuillaumier@nxp.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: AS4P189CA0069.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:659::7) To AM9PR04MB8147.eurprd04.prod.outlook.com (2603:10a6:20b:3e0::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR04MB8147:EE_|GVXPR04MB11690:EE_ X-MS-Office365-Filtering-Correlation-Id: f13cce13-412f-4bc6-bca0-08de5a7f42ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|19092799006|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: O3HNvWhiC8YV27kFc6mMDZO6ILqL3qXDQDHFf7pNvrmZ6AbGN96qQFtWOso9/AcRumlHgbBSBkEnJjIPA65ZZN1YJW2tNsojvnjuv6zOaGX2LsKkBl+QwmOcqBvji4wIyEaNpnHySp+13tkCZ5tPSkBg0p1nv5DZGOnP5jckKfI0hXsH3Vo/eHV+3UhWpkNg4jArm/olIcxbWYyfy6xpmP/XBgYIIihcOqfc1Syu4dCXQwfhPaunwmzazuWFRQJ4iVLbXOK4ZZzwRd6XD+ZTbm2M42Fe8iBouwUiYC86Yil6VppSrloTEEVtFzZKO2X7A4QO+YxQGpcFK8aKeW/6OcZkiTDzsPp3k69FXPvqpHEo2yrSOLivF2wNt+VH1YRhYNE3pO6fHwiJOwMP7ysoOi+6Z8f2RK+/FS8OQgfN0j+ciGxvJw5EPxkUkNzDXMmQBRpp0n8Fcda3kcia1+fRenptP3pm4kmHkEWbZY1n3Uj2HwJwQjRpxOB9cXVGT8yZLYMGNBV+F8AMk6IK4eLgr1IIydB3jArNMZga0Ff2WlByiuHxFZW4Zp9BoBjrPg6hbM8HP2y84R9pOEGtmw9mkeOYAnFq1YVt0qMSHKdxNnrDh+HyesRg3cuJsv/+X/uJ5wXrHEgOKk0PgiORuhONkLbYbfH/VcapHGmwNmn4cUNVCo3AEUEM/zjNQaWNLi+j+nC0r40O0Q9g1Iu3247pJNlHulvQ97ZL08Fi3YZdG8z8gC162tgg2K/nXRTqVYAIRrve/eRU3ECqEm+V1du26q/mi5E212RXpI2kg1VEvOH0euY6tqlcOIoTFdO8/SaldKtCn9B20WGD9WnMoYSln4E7Y7f1q/lt+/AhhJWnNT0NyKIHs4fg7Izg2OXKNMb9nxh+s2SZk1ib3ejAOzQAe+kZbqTuBUGwaGP+GaMgqe9rCv1xaEFNWHU2LO8SPWOmtFm3Hd0qsF9BYgmvyd84zXKTDHGBfXcn9S8DcKyopWP0B1T5AFhIyxDBkXhHCy9OgH2Rk/nQwUf3MspmL8GgLZZRWoLlxpLaIsY2pCgGDQ1n3ixVJcMucLtrpg2oo26hCEHRvOZtDorOJi8NSAhnWlnSkvEWljGSxd8t4ec5Ta+tjVJPZ+VrfbPNXT3x939b4PUJ16k0k3mpwEUEH2shw1lIno/JcvuCVIjs2VhRXerQHHiZ4UiuAEc8HP73QGwt5fZv5tZ3o1gcLsmt09e4OevHQy/jjmuTjXEDgEpF3L55H8VXF6XDMHkC3iLoiduQ5MEYjmD6w9yG6Eo1vbs52HN3Bx5zOtpO2QbO+cN83dUlXXqL6b/QTtaHVttcBBAY8RQ7z//tOPUc4BKPHfTmUIMjEjaygaHEmaKTk4VzgfwhnZ5vZCwj/8nNsOGqh+ngpDa/uaFyYIFABUh56QCBidtbr0NoTZ8IRpqRuQs+y9imvqh2Wn2I0PcYSxADUHx6d9AjzR4EjK4uzik8o7CQ+NV4EQ5nOdvgNHmctGGE1IMKhwd57WPtWsqYemaVQkZta3lyeVH0p0dsk54rHGwIpYdDerJW3+wdd/0z+vYXH24= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM9PR04MB8147.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(19092799006)(1800799024)(366016)(52116014)(376014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: STQazatWLDXOZynQrhN6zWFnoizrgGHXLig6HJYrJVlJwum89JQN5Xo9xT+DujX51RSwNZDCnbcQR1uoUuskrtW5TLQqpSbtjIs/ZPP7aVYlHHxXUT1KDY4cvADHHszlC15qXy9zZDif+nxWUV2GCItdnn2K1P2Hl5omw/wWQj6o4vmeijQIm6dLmXX+jY59PXQXsnvI7h1GSSO5ACvA7eBiLrgoMz+rqUp2tfeOOxitBU2F4GzODfqvVgmDZdqGksXfjS5+jwtZ0oCR5TPtauIKfhmcKiP7aOfBND/zf8qzNIAwcOTdDliYOlzo3e1i3HD/NZMy+izHKXWmx69Y8YcKDxT3FnUrXtoYI4OrLjbUUmrA/6qeHC7/YMLH2bTiJ/venfk0SGkowCN0uXWmESTqilZHxkYBDpGuvnaWtcPlt9pxb0DpW8CUPGHz6el5O8bkDUYHkKKEg0L+SUdFCSE+vM2BOjfpjIzPN6iN940jg589PYk85QX+67MAB511TKZsQV1zDC8YvG4UNS9uIboroaskNqjXx8A9e4jGcDEhSaoGW9/BB92gJmv+2HNqeZTWoyaKj90KlVFdyIlIb/Z3XMyQikq3GNuSB3kIVJQm/bSO5V85VNZeD+AjOgWzyblOeE0IiEnThyjvvRTcehgR6cWMJ7HOvMESSpd6RU3v/AQOg72Lw2SkSCOojpbclNX6HxHYLpDDFsH+8UUQVMr2shy0rc15ndnSVJL63KP6ak4lUdA/jmMLBKHHJlYJ04GHs8Bec2jhopBghboWQzHPQ0nxoHG2XdO8BYXShVYI8lxcvkXvzjNlhqzyTzLVuwfoyMruuMDBW2FZnTdtBN72o/R9DzMQsDo8cLhZufOBstmMy0KBg25NAgfwQyagJTVcpqjJkkNRkUK3eurAFYjEpLBlxJYMsnyo0p+GOQkAuAd6yM+ZRKn597HZCXE6dy7CCQ5IZHnqYjwEHYzAu02uKIuQInH1VAq9nL+0z6IDhUtmg/wv80QE8t7mBWt7TGov0nqCuHnWRg2DXGmFqAlmRNaIBFrwZcfdggjqimzzNSjlVL7FTsqlAvW+ggGmqL57cZ2EnO+7Oboh2a+PZUwD7ZKzPuxNb/26rPTb1I0QT5isE1ROT7FboftomYt6PvyTAzeglmkwXIYAu72PSGHq4rLKKPlFp2lu8JPWMpdpWQuk5x+A9m0Kie9AUfRSBo3KiLh/XiTw8kW/oTVky0dBWv1LQvAwwQ6pOzFbL0x1vlGd1LuLn0ZnXPCmNfHE4WBDEL5Hxez8ayQ0uXDa5quYQffuDM46Dnatf5rFJcsgs4b+vE2+SX9ajDUKGSqaiHnv7npD2CVPoTD7xySWHlZ1EwsBYd+3OGfaTQo5pFimezn688vl2Y7swn4zybdpPLsUZR/ARIaU+JZmj9yT9gUTPinPsKkIdWH2XNhRmF0OUwdeIUzwN014Bw6X8cSJJjw4ImbFO1dd/KH4xbFhAPY5xzFiM9lYSBlVOR9sOtNCYKW2O0JDOwyEnliQSQQ8rYXi5tbQqtQlvrUzDUgy2PUIsgPMN3yR5pjkf1EjO82x6VEB+gZgfIejzlAFSm4f8LgIcsuRrJ6u4sgW8Hqs8vmZ4O1UzirkWuAxOhFrBNpJo9eTWQh60kywRQoTmiYeI0sfsUzkgQjXGObRX8eBVJqzCmAB4aTVqLFtAKfWE445usL9LCvGGDuAsDyH+x3jH91IgGIBa9UyCMETNdgDfKAhHczi8FEyvSEkinaKprw= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f13cce13-412f-4bc6-bca0-08de5a7f42ee X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8147.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2026 12:59:36.4844 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jxR6xJZu5E/sC9QRqOQk1krIOhbQ98GYSkVt3DsBSpasm1nhxeTlEEhgXon/3vRrXCaJd0motoJlUXLCjMetw4Dtb3QCwYSofzSVh7YYD8s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB11690 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, This is an updated version of that patch, fixing the image source pad index reported by a legacy camera when it is not the pad 0. It may be the case when a raw sensor subdevice is linked to an external ISP, then the external ISP subdevice is acting as the sensor subdevice. As it has both sink and source pads, the image source pad may no longer be zero. Changes in v2: - Fixes the documentation warning Thanks [1] https://patchwork.libcamera.org/project/libcamera/list/?series=5507 Julien Vuillaumier (1): libcamera: camera_sensor: Fix imageStream() for CameraSensorLegacy class include/libcamera/internal/camera_sensor.h | 2 +- src/libcamera/sensor/camera_sensor.cpp | 5 +---- src/libcamera/sensor/camera_sensor_legacy.cpp | 6 ++++++ 3 files changed, 8 insertions(+), 5 deletions(-)