From patchwork Thu Dec 18 12:31:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 25601 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2722FBD7D8 for ; Thu, 18 Dec 2025 12:35:34 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 16E1B61AA8; Thu, 18 Dec 2025 13:35:33 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="nwblTTZs"; dkim-atps=neutral Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BB23F61603 for ; Thu, 18 Dec 2025 13:35:31 +0100 (CET) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-47928022b93so1320125e9.0 for ; Thu, 18 Dec 2025 04:35:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1766061331; x=1766666131; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ygQYMov/C/Gup2/jN2wTz9BaA9TotbSoNj7nn4tBTUU=; b=nwblTTZsK7yCoyhzrew2DwV7GTxGqSMFVmo6R9zqVYi61aYWN/hz3EYSlbBKppLwG7 vXW02Y4B333ej0+0ppAYeZkuFoR+IodtXT6HAgr1PPVZjiXOQOkwEdTu8TUkeG7vrlux 7ky8JhymQg64Gk1y21Ey4PwqjY1jNiPAijyf2mSYxOO5dvXB1Ad8qwhybvEStOxtM7z/ oob7Bdhd/juIaDcDOBS29+8RgNd6ZkB9qfdbF0TRpTcZEnIcplZ+DEoW59OWDufliyCS Z9ddrvvEWT9g5z0yr2EaShi/lQs5wF7GaM2O85HkKK7AZa52JSA5XQ/poV5EcCPH7B3W iVfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766061331; x=1766666131; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ygQYMov/C/Gup2/jN2wTz9BaA9TotbSoNj7nn4tBTUU=; b=WI77ScryNoxu7J0603lyyhxl9AhTUF97QY5cflHcZBwc4JpGu5jW4EreQy7HUKXnrb rFXa8evWPvOiY9Hw2BYeGp3pyjkyLalOyVcGnbvx5rqaO9LDvmxfHxM4DqE5wTV0oT4i UCccoPDixbyh813MkPMtIo1J0EXBxJ9K6kf3i0lXz9/sDem17A4h0flzIrH8cNqmp5tn RmCmTDPfN28bm2xcu8tUTbo0LT9IyWGz3M+X5lH8Mu2eqXryo9I8MvEmEGhd+dapedWD CeQ6m2PQnfE1LDz7msrwxELtsDQmU54sBLOo629UExIoSHEKrbKoY2bQEwbUSIUSwig0 Cmng== X-Gm-Message-State: AOJu0Yy72aAk1tNiy9bbWKJDMrtqzVVAzAe83QDwBL4y7EIN5jcOwvWB p8d9r9GX9s5EWSKGu/YJVA0h+0M2HAHxQzScuVo4yLBNTLLR9nhGW9eL932PCYmApeEiTYWeW7r +vaQR X-Gm-Gg: AY/fxX7fSAAGIbDEwtPX9c1R44uHZRgRRGj3UuUpdccDc7c8dlTnHJ+OyfzYE6+aw5M sptKoif2c1CPG2Y8IZvcyBdZSuzuTwVCbJN1+exiJVQUkEb2ktiU+T38dCneFs/px37KL3OGXBs GWfHuVJfV0osuRv639AjAjtjDXswOzADmI4W9sX1dORmS/NjtU/joR+iu8rj1N25ILrJuQoL61u EYO4wbZN7PGQHEqbu/PO09VmiDdIvIYg97lq5dH6lTk/lQJlruP/ETucgDKmC27D7fkbiF69NZ9 IKE6EJs99PHebhnnS2fRAsng2ZnBfpIdbCPkezpfEEFaCLynVs4ygbGBww0ytAwyChyScMQMVby Rpj6J9xP+5Z8UCOR6GgQdFkuapGTIxEXJNukAbTxrD4gEwOu7ejJWVuZomlBDBh+p+nEADBqQMS b/wpKWjBHX+gmh+q2jCWONLUaDD4SC3iI= X-Google-Smtp-Source: AGHT+IHFy6Yx6LKW/0n+9RvCxs8ZpKGvjcJwPptJZz6J1xpYHbDNIIj09lFxZBGkgYRruH5ORjqEkQ== X-Received: by 2002:a05:600c:4e8a:b0:477:a6f1:499d with SMTP id 5b1f17b1804b1-47ce8776b26mr9499025e9.3.1766061330940; Thu, 18 Dec 2025 04:35:30 -0800 (PST) Received: from naush-dell.pitowers.org ([2a00:1098:3142:1f:1670:643a:b830:51f7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324493fd73sm4769434f8f.13.2025.12.18.04.35.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 04:35:30 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , Naushir Patuck Subject: [PATCH v2 0/2] RPi: Internal buffer alloaction rework Date: Thu, 18 Dec 2025 12:31:22 +0000 Message-ID: <20251218123524.130886-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, No code changes in v2, only tags added. Jacopo, I thought it would be a trival change to address your comment regarding calling importBuffers() unconditionally for disabled nodes. Turns out it's not, and will need a bit of quite annoying plumbing since the base pipeline handler class knows nothing about TDN and Sitch device nodes which are PiSP specific. In the interest of getting this merged quickly I suggest we keep this as-is as the unconditional call only does allocation of v4l2 slots, so is not a big deal. If you are ok with that, we can go ahead and merge this. Regards, Naush Naushir Patuck (2): pipeline: rpi: Rename Stream::prepareBuffers to Stream::allocateBuffers pipeline: rpi: Rework internal buffer allocations .../pipeline/rpi/common/pipeline_base.cpp | 10 ++++++-- .../pipeline/rpi/common/pipeline_base.h | 2 +- .../pipeline/rpi/common/rpi_stream.cpp | 25 ++++++------------- .../pipeline/rpi/common/rpi_stream.h | 3 +-- src/libcamera/pipeline/rpi/pisp/pisp.cpp | 6 ++--- src/libcamera/pipeline/rpi/vc4/vc4.cpp | 6 ++--- 6 files changed, 24 insertions(+), 28 deletions(-)