From patchwork Thu Jan 17 20:20:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 256 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B815560B2D for ; Thu, 17 Jan 2019 21:20:48 +0100 (CET) Received: from localhost.localdomain (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2866A53E; Thu, 17 Jan 2019 21:20:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1547756448; bh=G6M6iaGQ8w5idYIkKozMko91Q3q8Q4BsLvOQ/vG6U6Q=; h=From:To:Cc:Subject:Date:From; b=EfhpAmnqDTRZtRFVptILqkDJvAZOMMAkZZn+5sWJsAuY0G8Qh3HEQnGk6VOFLX+jR DLTJrpVvMjs722ctzugeB7j2dg6DVpeZZH4gdLCH0dZ/VICX8O/Y1Mi+gJroVHtDkp GxjdtqBXP/+Qxy0vuifr1nF1vFo2Wfc6QuBHr074= From: Kieran Bingham To: LibCamera Devel Date: Thu, 17 Jan 2019 20:20:38 +0000 Message-Id: <20190117202043.21420-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.17.1 Subject: [libcamera-devel] [PATCH 0/5] General fixes X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 20:20:48 -0000 Heya, Here's a few miscellaneous patches I've collected this week while developing. The first three patches tackle the Timer class, after I hit an issue where timers longer than 4.29 seconds fail, due to the internals wrapping at 32 bits. The first patch ensures that all member variables are initialised as this was generating a warning in my IDE static analyser. Then we add a test which fails, and follow that by a patch to introduce the fix allowing the test to pass. Patch 4 fixes up some warnings that our checkstyle.py script complained about in the log class, and I caught a /really/ trivial spelling error in event_dispatch_poll. Kieran Bingham (5): test: timer: Initialise all variables test: timer: Add a 32 bit wraparound test libcamera: timer: Fix 32 bit wrap libcamera: log: Fix coding style warnings libcamera: event_dispatcher_poll: Fix trivial spelling src/libcamera/event_dispatcher_poll.cpp | 2 +- src/libcamera/include/log.h | 6 +++--- src/libcamera/log.cpp | 2 +- src/libcamera/timer.cpp | 3 ++- test/timer.cpp | 16 +++++++++++++++- 5 files changed, 22 insertions(+), 7 deletions(-)