From patchwork Tue Dec 2 01:50:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rui Wang X-Patchwork-Id: 25282 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7E868C3257 for ; Tue, 2 Dec 2025 01:50:46 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 78F3E60C6B; Tue, 2 Dec 2025 02:50:45 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="NA66SOYj"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 12209606E6 for ; Tue, 2 Dec 2025 02:50:44 +0100 (CET) Received: from rui-Precision-7560.local (unknown [209.216.103.65]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5CA30A06; Tue, 2 Dec 2025 02:48:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1764640108; bh=KnRyxlWiYmitQ1tAEkHqz9bq2NDqcaHpHmYcf0N+xgI=; h=From:To:Cc:Subject:Date:From; b=NA66SOYjcfVhIlIUb0rmTNDc3aWKdtrv18zLMqbe4SV5Xzubqf88AzE69rovmFT5w wO1wJJMNbF9Ryi4uzL7SWR9+vUmER3LpedSw+vM1FhVEnqlm7DBLXf4IxrRiYDuGCb jOGyvOaFfW8HBrwZMivkc7dlfaQK/X1EGh1LoKmI= From: Rui Wang To: linux-media@vger.kernel.org, dafna@fastmail.com, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, heiko@sntech.de, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: libcamera-devel@lists.libcamera.org, Rui Wang Subject: [PATCH v1 0/1] Fix filter mode register issue Date: Mon, 1 Dec 2025 20:50:24 -0500 Message-ID: <20251202015025.601549-1-rui.wang@ideasonboard.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, This series contains a single patch that fixes an issue in the rkisp1 filter mode configuration logic. The rkisp1_flt_config() function performs a direct write to the FILT_MODE register before the read/modify/write update. This write does not include the RKISP1_CIF_ISP_FLT_ENA bit, which clears the enable bit in hardware. After that, the read/modify/write sequence cannot restore the original enable state, causing the filter to be disabled unintentionally. The patch removes the redundant direct write. The remaining read/modify/write sequence correctly updates the mode fields while preserving the existing enable bit. Please review. Thanks, Rui Wang Rui Wang (1): media: rkisp1: Fix filter mode register configuration drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 6 ------ 1 file changed, 6 deletions(-)