From patchwork Mon Nov 24 16:43:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 25159 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 03BC0C32E0 for ; Mon, 24 Nov 2025 16:44:05 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DF84360A86; Mon, 24 Nov 2025 17:44:03 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="bjv8ku3t"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AE7D76096B for ; Mon, 24 Nov 2025 17:44:02 +0100 (CET) Received: from [192.168.0.172] (mob-5-90-137-64.net.vodafone.it [5.90.137.64]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0F3BB741; Mon, 24 Nov 2025 17:41:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1764002514; bh=TINOl6HxpoxWlzHuxUK1c/B1l75OEV1ef7T4J4TzxCE=; h=From:Subject:Date:To:Cc:From; b=bjv8ku3tjQwzxIKiHDfrtwBYmrIKnlJ5vRIiCAE0RXGG0I3Zqa5YzsrBS51JpaAuL Ti/1l/o1U9soJcWqJJna3Txx2oJIEaiQ3gOnwpYTAjIEgowMOPY9FPw+YlLgLDBdAK D5LZ+1QGZxv8RIhYk/qPum6TZxM6FT8etya/i4s8= From: Jacopo Mondi Subject: [PATCH 0/2] libcamera: ipc: ControlLists without valid idmap break IPC Date: Mon, 24 Nov 2025 17:43:43 +0100 Message-Id: <20251124-cam-control-override-v1-0-dfc3a2f3feee@ideasonboard.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAD+LJGkC/x3MSwqAMAwA0atI1gaa+gOvIi60Rg1oK6mIIN7d4 vItZh6IrMIR2uwB5UuiBJ9AeQZuHfzCKFMyWGMrIluiG3Z0wZ8aNgwXq8rEWJGpi2Z0diQDKT2 UZ7n/bde/7wevKI7CZgAAAA== X-Change-ID: 20251124-cam-control-override-510637bc2b10 To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=995; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=TINOl6HxpoxWlzHuxUK1c/B1l75OEV1ef7T4J4TzxCE=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpJItR4/fGR4jbzb0pj4No1bYST3r881N3GEDiE bOZ5/rrZK6JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaSSLUQAKCRByNAaPFqFW PBqGD/95oYx1Kq3E4fUckjNPzvXzw5LNaRKXTp+2c8RDsvvE7wwLPN6vbuRpIc3+l36e6hHNg8u eYoh5fhIRh3XWp/vIglZTFQFHsxu18o6CvGO1pBbIuvx5VeeUdfTKyZiJp6jaj+qg49Pl2mh4Ta IAcgqxNBvgRUndrzo4oZ5kUCu4RL9XyOtBVL9rxMkA1fAlzZ/DHoNtAkoekQ5Dmy4YZ6PK8NHEG pMe7irgp184ywycTv1hFOIKH8wfNFLt1FrIAIpO7WIgLMPWlBE4HrPbIUAjnAyvsSaH+Jb84xot W6m7O1F5i+6izq1zby7AdA2lacQinjvaaZia7NZyhdBWc7ow68SkSFGyHKFFXHTs+EYZRWVqB8n w4+YLkEzKYab1ZyYbxQokl7UrICuXS4H5lQQU4zhTX/JuPDva78oOx138y0YzLhoGfPcOiO7b6u TZx580W5QUdqGNMOiNQwUWDMbdad3jFbsz1O+95QqSekf2HJ8vuEP0ViuVTAbDMdUjY/yjaf5c5 L6cQjOwjonXEAZtUjBXOh/2HqSc/uEYZNe/34lvKCbxncDjcFaBMEU/JSCGSvmE7+uZCHvZEnSu YEZTllj+prs82mPcePqCHQkomvpqrsIaiCFyxYTrvjsY95V1L2ufUWRFAEwvAgKdCZE8UYi34Fk J803hmROQ+zn0yg== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" https://gitlab.freedesktop.org/camera/libcamera/-/issues/295 This is first fix for the most visible issue, but I guess the real fix should be designing an API for the Request class that doesn't allow applications to overwrite the ControlList associated with a Request. What do people think ? Also, an RFC patch for something that seems trivial to me, but I suspect if it was -that- trivial, it would have been done like this from the very beginning. Signed-off-by: Jacopo Mondi --- Jacopo Mondi (2): apps: cam: Do not override Request::controls() [RFC] libcamera: request: Create control list with Camera info map src/apps/cam/camera_session.cpp | 2 +- src/libcamera/request.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- base-commit: 5a33bc10e9d3bc3a7cb1ead66c7ec0a413083d91 change-id: 20251124-cam-control-override-510637bc2b10 Best regards,