From patchwork Thu Nov 13 12:24:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 25014 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D1E77C3263 for ; Thu, 13 Nov 2025 12:24:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8B05B60A80; Thu, 13 Nov 2025 13:24:55 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="q+LEogQJ"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3916F609E0 for ; Thu, 13 Nov 2025 13:24:54 +0100 (CET) Received: from Monstersaurus.infra.iob (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F8CF5B2; Thu, 13 Nov 2025 13:22:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1763036574; bh=6iOoft9B1QKJICy7YXXbFL0ate3d5fTzrpa5EXFelwE=; h=From:To:Cc:Subject:Date:From; b=q+LEogQJTIMQ326kqDLiZ+eFOHSQzorvllgIirrB72FcUXdd546ctr0Kqj/1lmMgR eyhPyPePEAFIOKrfEx32ktLQpEIjdnF/g7stEF7QjYGavm8CE0Fq7CodRSZSiKLYyF ZFyG3x0P71ddTlMwVItUGU8XNA4atGLx9etXDUbw= From: Kieran Bingham To: libcamera devel Cc: Kieran Bingham Subject: [PATCH v3 00/14] libipa: Introduce a Quantized type Date: Thu, 13 Nov 2025 12:24:35 +0000 Message-ID: <20251113122450.287633-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This series superceeds [0] "rkisp1: cproc - Metadata and Hue developments" by introducing a new base type for libipa to be able to maintain values which are quantized for hardware. These data values often need to be converted, perhaps to a fixed-point format for configuration of hardware, but also then back to a floating point for returning as metadata. In particular this series builds to solve the review comment that blocked the original series at [1] The Quantized type provides a storage mechanism to make both of these storage representations visible to code that wishes to utilise the specific values. The series then re-introduces the proposed updates to cproc using the new Q types by supplying Fixed Point types and a scaled fixed point type for the Hue control. Tests and documentation are provided throughout. [0] https://patchwork.libcamera.org/project/libcamera/list/?series=5245 [1] https://patchwork.libcamera.org/patch/23645/#34626 Running the tests directly shows the following output (all passing) test/ipa/libipa/quantized Quantised tests passed successfully. test/ipa/libipa/fixedpoint Q1_7(-1 .. 0.992188) Min: [0x80:-1] -- Max: [0x7f:0.992188] Step:0.0078125 Checking -1 == [0x80:-1] Checking -0.992 == [0x81:-0.992188] Checking -0.006 == [0xff:-0.0078125] Checking 0 == [0x00:0] Checking 0.008 == [0x01:0.0078125] Checking 0.992 == [0x7f:0.992188] UQ1_7(0 .. 1.99219) Min: [0x00:0] -- Max: [0xff:1.99219] Step:0.0078125 Checking 0 == [0x00:0] Checking 1 == [0x80:1] Checking 1.992 == [0xff:1.99219] Q4_7(-8 .. 7.99219) Min: [0x0400:-8] -- Max: [0x03ff:7.99219] Step:0.0078125 Checking -8 == [0x0400:-8] Checking -0.008 == [0x07ff:-0.0078125] Checking 0 == [0x0000:0] Checking 0.008 == [0x0001:0.0078125] Checking 7.992 == [0x03ff:7.99219] Checking 0.2 == [0x001a:0.203125] Checking -0.2 == [0x07e6:-0.203125] Checking -0.8 == [0x079a:-0.796875] Checking -0.4 == [0x07cd:-0.398438] Checking -1.4 == [0x074d:-1.39844] Q5_4(-16 .. 15.9375) Min: [0x0100:-16] -- Max: [0x00ff:15.9375] Step:0.0625 Checking -16 == [0x0100:-16] Checking 15.94 == [0x00ff:15.9375] Q12_4(-2048 .. 2047.94) Min: [0x8000:-2048] -- Max: [0x7fff:2047.94] Step:0.0625 Checking 0 == [0x0000:0] Checking 7.5 == [0x0078:7.5] UQ12_4(0 .. 4095.94) Min: [0x0000:0] -- Max: [0xffff:4095.94] Step:0.0625 Checking 0 == [0x0000:0] Checking 7.5 == [0x0078:7.5] Range validation: Checking -100 == [0x80:-1] Checking 100 == [0x7f:0.992188] Checking -100 == [0x00:0] Checking 100 == [0xff:1.99219] Scaled Fixed-Point Quantizer tests: HueQ (Scaled Q1_7 * 90) (-90 .. 89.2969) Min: [0x80:-90] -- Max: [0x7f:89.2969] Step:0.703125 Checking -90 == [0x80:-90] Checking -45 == [0xc0:-45] Checking 0 == [0x00:0] Checking 45 == [0x40:45] Checking 90 == [0x7f:89.2969] Checking -99 == [0x80:-90] Checking 99 == [0x7f:89.2969] CPROC Fixed-Point Quantizer conversion tests: Checking [0x80:-1] == [0x80:-1] Checking [0x7f:0.992188] == [0x7f:0.992188] Checking [0x00:0] == [0x00:0] Checking [0xff:1.99219] == [0xff:1.99219] Kieran Bingham (13): ipa: libipa: Provide a Quantized data type support test: libipa: Add tests for Quantized types ipa: libipa: Provide fixed point quantized traits test: libipa: Provide FixedPoint Quantized tests ipa: libipa: fixedpoint: Fix unsigned usage test: libipa: Add Q4.7 type and tests to match existing use case tests ipa: libipa: Provide Q5.4 FixedPoint support ipa: libipa: fixedpoint: Provide a ScaledFixedPoint type test: libipa: Provide ScaledFixedPoint tests ipa: rkisp1: cproc: Convert to use Quantized types ipa: rkisp1: cproc: Report metadata ipa: rkisp1: cproc: Provide a Hue control DNI: test: libipa: fixedpoint: Validate extra types van Veen, Stephan (1): libcamera: controls: Define a new core Hue control src/ipa/libipa/fixedpoint.cpp | 182 ++++++++++++++++++++ src/ipa/libipa/fixedpoint.h | 72 ++++++++ src/ipa/libipa/meson.build | 2 + src/ipa/libipa/quantized.cpp | 134 +++++++++++++++ src/ipa/libipa/quantized.h | 78 +++++++++ src/ipa/rkisp1/algorithms/cproc.cpp | 66 +++++--- src/ipa/rkisp1/algorithms/cproc.h | 4 + src/ipa/rkisp1/ipa_context.h | 22 ++- src/libcamera/control_ids_core.yaml | 13 ++ test/ipa/libipa/fixedpoint.cpp | 247 +++++++++++++++++++++++++++- test/ipa/libipa/meson.build | 1 + test/ipa/libipa/quantized.cpp | 130 +++++++++++++++ 12 files changed, 916 insertions(+), 35 deletions(-) create mode 100644 src/ipa/libipa/quantized.cpp create mode 100644 src/ipa/libipa/quantized.h create mode 100644 test/ipa/libipa/quantized.cpp