From patchwork Sat Oct 11 16:03:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 24588 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 27902BE080 for ; Sat, 11 Oct 2025 16:03:45 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E6DD46043D; Sat, 11 Oct 2025 18:03:43 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="H/e/3qHm"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 706DA603DF for ; Sat, 11 Oct 2025 18:03:42 +0200 (CEST) Received: from charm.hippo-penny.ts.net (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B0BAB82A; Sat, 11 Oct 2025 18:02:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1760198525; bh=+6GmHzvWmRUZixe19LFREM2JNzbeUaFpm/uZFejF2lc=; h=From:To:Cc:Subject:Date:From; b=H/e/3qHmld8DPwfMyNaVBPeaVe/Didply5XAZCYUXMDzPH2hAVukz5YBw0mdkWsrS EV8XAu8BQ56IpLldAYl003VfnCdQSFbOOqRKLMY+zNYDmvx73qMVuFlNhi20ldInsq MfQxEaLLyMJTQBhvIVjRT9hCOpHHjH3Rz7CS2a7Y= From: Kieran Bingham To: libcamera devel Cc: Kieran Bingham Subject: [RFC PATCH 0/7] Preparatory cleanup for libipa rework. Date: Sat, 11 Oct 2025 17:03:28 +0100 Message-ID: <20251011160335.50578-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" I'm continuing to work on aligning the SoftIPA to use more of the libipa processing and modularise components, and reduce code duplication throughout the IPAs. That's all ongoing, but these patches so far seem to hold up on their own. Sending for early review to see if the stars are aligned, before moving on to more global updates. Kieran Bingham (7): ipa: mali-c55: blc: mark offset member variables ipa: mali-c55: Move CameraHelper to context ipa: mali-c55: Confine blacklevel config ipa: softipa: Extend configure operation to pass controls ipa: softipa: Pass IPACameraSensorInfo to configure ipa: softipa: Move camhelper to context ipa: softipa: Confine black level configuration .../internal/software_isp/software_isp.h | 3 +- include/libcamera/ipa/soft.mojom | 3 +- src/ipa/mali-c55/algorithms/blc.cpp | 52 +++++++++++-------- src/ipa/mali-c55/algorithms/blc.h | 8 +-- src/ipa/mali-c55/ipa_context.h | 5 +- src/ipa/mali-c55/mali-c55.cpp | 33 ++++-------- src/ipa/simple/algorithms/blc.cpp | 11 ++++ src/ipa/simple/ipa_context.h | 3 ++ src/ipa/simple/soft_simple.cpp | 33 +++++------- src/libcamera/pipeline/simple/simple.cpp | 12 +++-- src/libcamera/software_isp/software_isp.cpp | 5 +- 11 files changed, 89 insertions(+), 79 deletions(-)