From patchwork Mon Sep 29 20:19:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 24488 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B3189C324C for ; Mon, 29 Sep 2025 20:19:40 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7D5F06B5F9; Mon, 29 Sep 2025 22:19:39 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="GXn1LIak"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E5FB6B599 for ; Mon, 29 Sep 2025 22:19:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759177176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=19eNsRmCnbxhvyKAGijUd+SkiKPIZAeJs0Z87EEchMg=; b=GXn1LIakMBaW3o7ip87e7ACP6MkkE11EzfYmlLwKc9bUVps5bsvKjx+m+lW7VA1wxPiJpU s/CWHNlFrqXNm1d49aY/OWi+TZ/0Vj0O6tDXTJoofdi1PHBForxLUYKuLTIGQwylaSp0XH BbJ/badg2JxikfONclz/JOnbGs0rwFA= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-157-irDkd9NRPPuZze8zC2eMRg-1; Mon, 29 Sep 2025 16:19:34 -0400 X-MC-Unique: irDkd9NRPPuZze8zC2eMRg-1 X-Mimecast-MFC-AGG-ID: irDkd9NRPPuZze8zC2eMRg_1759177173 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 51AB1195609E; Mon, 29 Sep 2025 20:19:32 +0000 (UTC) Received: from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.35]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 79E7F19560B4; Mon, 29 Sep 2025 20:19:29 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , pobrn@protonmail.com, mail@maciej.szmigiero.name, hansg@kernel.org, Robert Mader Subject: [PATCH v5 0/7] Fix stats related problems in software ISP Date: Mon, 29 Sep 2025 22:19:17 +0200 Message-ID: <20250929201924.45019-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PrOjRD4WUoWeUB4H-4kqFtkb53qZ1GroZR10r-SSUjE_1759177173 X-Mimecast-Originator: redhat.com X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Fixes of https://bugs.libcamera.org/show_bug.cgi?id=280 and the related problems discussed there. Tested-by: Maciej S. Szmigiero Tested-by: Robert Mader Changes in v5: - Docstring changes as suggested by Barnabás. - Assertion on non-negative window corner values in SwStatsCpu::setWindow() added. - Cosmetic code changes in debayer_cpu.cpp suggested by Hans. - “Check processed window size alignment” patch dropped (the requirement is already enforced elsewhere.) - Minor code change in awb.cpp suggested by Barnabás. - New patch fixing the initial value type in std::accumulate(). Changes in v4: - unsigned int underflow in SwStatsCpu::setWindow eliminated. - Window adjustment clarified in SwStatsCpu::setWindow. Changes in v3: - Possible uint64_t underflow eliminated. Changes in v2: - An extra semicolon removed. - A note about the debayering alignment being an implementation limitation added. - A check for division by zero in AGC added. Milan Zamazal (7): libcamera: software_isp: Fix width adjustment in SwStatsCpu::setWindow libcamera: software_isp: Clarify SwStatsCpu::setWindow use libcamera: software_isp: Pass correct y-coordinate to stats ipa: simple: awb: Avoid incorrect arithmetic in AWB ipa: simple: awb: Use correct type in std::accumulate ipa: simple: blc: Prevent division by zero in BLC ipa: simple: agc: Prevent division by zero in AGC src/ipa/simple/algorithms/agc.cpp | 6 +++++ src/ipa/simple/algorithms/awb.cpp | 10 +++++---- src/ipa/simple/algorithms/blc.cpp | 5 +++++ src/libcamera/software_isp/debayer_cpu.cpp | 18 ++++++++++----- src/libcamera/software_isp/swstats_cpu.cpp | 26 +++++++++++++++++++++- 5 files changed, 54 insertions(+), 11 deletions(-) Tested-by: Hans de Goede