From patchwork Fri Sep 19 17:37:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 24429 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 677EEBE173 for ; Fri, 19 Sep 2025 17:37:24 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5C12862C3B; Fri, 19 Sep 2025 19:37:23 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="WhPSmmlW"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3905562C35 for ; Fri, 19 Sep 2025 19:37:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758303440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SdMuGNHQoMw9HxbsYDPTsXhn147i2SRKT1e2REed81I=; b=WhPSmmlWT2b+XF5lliBvXFnQEupNJkvXkU10LNVmQKgWctFw2S2pJIlxQnhyWX2yVzAO6T eY3Ppg844XjNKmf1ujWC91ur6I9ZlAg5ATGFaY0RquEDO041FV7oUc8wiXGLIyd8jhPKRd 8HAe47Y4NhiXzZ78Tc3Ct18IR+574NI= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-394-YQE2_FqtMZSspWtdT-niNQ-1; Fri, 19 Sep 2025 13:37:18 -0400 X-MC-Unique: YQE2_FqtMZSspWtdT-niNQ-1 X-Mimecast-MFC-AGG-ID: YQE2_FqtMZSspWtdT-niNQ_1758303436 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 90C37180048E; Fri, 19 Sep 2025 17:37:15 +0000 (UTC) Received: from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.9]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 028371800451; Fri, 19 Sep 2025 17:37:12 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , pobrn@protonmail.com, mail@maciej.szmigiero.name, Robert Mader Subject: [PATCH v3 0/6] Fix stats related problems in software ISP Date: Fri, 19 Sep 2025 19:37:03 +0200 Message-ID: <20250919173709.220881-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pXKmNCTnr0agz78trhRSzTPseFVhHnf3yzaPBPq3PRU_1758303436 X-Mimecast-Originator: redhat.com X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Fixes of https://bugs.libcamera.org/show_bug.cgi?id=280 and the related problems discussed there. Tested-by: Maciej S. Szmigiero Tested-by: Robert Mader Changes in v3: - Possible uint64_t underflow eliminated. Changes in v2: - An extra semicolon removed. - A note about the debayering alignment being an implementation limitation added. - A check for division by zero in AGC added. Milan Zamazal (6): libcamera: software_isp: Clarify SwStatsCpu::setWindow use libcamera: software_isp: Pass correct y-coordinate to stats libcamera: software_isp: Check processed window size alignment libcamera: simple: Avoid incorrect arithmetic in AWB ipa: simple: blc: Prevent division by zero in BLC ipa: simple: agc: Prevent division by zero in AGC src/ipa/simple/algorithms/agc.cpp | 6 +++++ src/ipa/simple/algorithms/awb.cpp | 10 +++++---- src/ipa/simple/algorithms/blc.cpp | 5 +++++ src/libcamera/software_isp/debayer_cpu.cpp | 26 +++++++++++++++++----- src/libcamera/software_isp/swstats_cpu.cpp | 16 +++++++++++++ 5 files changed, 53 insertions(+), 10 deletions(-)