From patchwork Thu Sep 11 13:51:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 24321 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AE5C0C324E for ; Thu, 11 Sep 2025 13:52:04 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A815169367; Thu, 11 Sep 2025 15:52:03 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="Jo4JLkdt"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CB8D769367 for ; Thu, 11 Sep 2025 15:51:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757598718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YygQCl2/c3KKdTMKGpplBY0JO+13bC2zEPlQ4CGdCwM=; b=Jo4JLkdt+NwmCEsu8UeiOY4GeLJV/lWbsNeuJY2K1X7qcvfjUNJFq0ALs3iinMxm6uHyJL bjIIj2TRCtwmBk3R5KCDYSgEumsZLge9pQpAL9/z6j3eLd9M0svOmJFDp36pjFttr+xdRK +K4GxK4jtsEIoIEhqtBit5ZmQ/vZqi8= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-4Rl3PpCnPh2XCGmBFUvZrA-1; Thu, 11 Sep 2025 09:51:55 -0400 X-MC-Unique: 4Rl3PpCnPh2XCGmBFUvZrA-1 X-Mimecast-MFC-AGG-ID: 4Rl3PpCnPh2XCGmBFUvZrA_1757598714 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D51A3180ACE1; Thu, 11 Sep 2025 13:51:49 +0000 (UTC) Received: from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.98]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 949AC1800578; Thu, 11 Sep 2025 13:51:47 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , pobrn@protonmail.com, mail@maciej.szmigiero.name, Robert Mader Subject: [PATCH v2 0/6] Fix stats related problems in software ISP Date: Thu, 11 Sep 2025 15:51:38 +0200 Message-ID: <20250911135144.56586-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cEapHjQeSI5QTr2BQLjviF4iltreJmwt1nqhqaFgzvQ_1757598714 X-Mimecast-Originator: redhat.com X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Fixes of https://bugs.libcamera.org/show_bug.cgi?id=280 and the related problems discussed there. Tested-by: Maciej S. Szmigiero Tested-by: Robert Mader Changes in v2: - An extra semicolon removed. - A note about the debayering alignment being an implementation limitation added. - A check for division by zero in AGC added. Milan Zamazal (6): libcamera: software_isp: Clarify SwStatsCpu::setWindow use libcamera: software_isp: Pass correct y-coordinate to stats libcamera: software_isp: Check processed window size alignment libcamera: simple: Avoid incorrect arithmetic in AWB ipa: simple: blc: Prevent division by zero in BLC ipa: simple: agc: Prevent division by zero in AGC src/ipa/simple/algorithms/agc.cpp | 6 +++++ src/ipa/simple/algorithms/awb.cpp | 8 ++++--- src/ipa/simple/algorithms/blc.cpp | 5 +++++ src/libcamera/software_isp/debayer_cpu.cpp | 26 +++++++++++++++++----- src/libcamera/software_isp/swstats_cpu.cpp | 16 +++++++++++++ 5 files changed, 52 insertions(+), 9 deletions(-)