From patchwork Wed Sep 10 09:35:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 24299 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D8F6BBDB13 for ; Wed, 10 Sep 2025 09:35:52 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 00E3369369; Wed, 10 Sep 2025 11:35:52 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="obNIEynI"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id ED9DD613A5 for ; Wed, 10 Sep 2025 11:35:49 +0200 (CEST) Received: from neptunite.hamster-moth.ts.net (unknown [IPv6:2404:7a81:160:2100:e06d:abb0:39cf:8f3a]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 34B4DDAB; Wed, 10 Sep 2025 11:34:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1757496875; bh=2QMbo5UHWpDc5aHgX2+iyh41QNJNaoEyk1Lzx10XwRc=; h=From:To:Cc:Subject:Date:From; b=obNIEynIhjE1ymr3CID411Nq2PJreW9+zNfQNt06mamGzqQDhmmo9Swm3beX7EJH0 Ll6NjWYdwoduu2nEJIfLKIGfm6zZ5XzGa8TedOC/KDI6tx3Xd8pvxLG9V3rWRFo2IW Ikf3yOydFwBLOvsKsM8BWopOR5rrCJtTvJFGVrsk= From: Paul Elder To: libcamera-devel@lists.libcamera.org Cc: Paul Elder Subject: [PATCH 0/2] Fix ControlSerializer deserializing array controls Date: Wed, 10 Sep 2025 18:35:17 +0900 Message-ID: <20250910093539.3216782-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This series fixes bug 285 [0] where running IPAs in isolation with array controls would cause the control deserialization to fail, since the deserializer didn't properly deserialize array controls. This is fixed by making the deserializer properly deserialize array controls. As a side effect, array controls that didn't report default array values must now report default array values, so the second patch does that. [0] https://bugs.libcamera.org/show_bug.cgi?id=285 Paul Elder (2): libcamera: control_serializer: Deserialize array ControlInfos ipa: ipu3, mali-c55, rkisp1, rpi: Fix reporting non-scalar controls include/libcamera/internal/control_serializer.h | 3 ++- src/ipa/ipu3/ipu3.cpp | 4 +++- src/ipa/mali-c55/mali-c55.cpp | 5 ++++- src/ipa/rkisp1/algorithms/awb.cpp | 5 ++++- src/ipa/rkisp1/rkisp1.cpp | 4 +++- src/ipa/rpi/common/ipa_base.cpp | 7 ++++++- src/libcamera/control_serializer.cpp | 9 ++++++--- 7 files changed, 28 insertions(+), 9 deletions(-)