From patchwork Fri Aug 15 10:29:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 24110 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 988F8BDCC1 for ; Fri, 15 Aug 2025 10:29:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 360B669257; Fri, 15 Aug 2025 12:29:54 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="iyOXvxb/"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B26F61443 for ; Fri, 15 Aug 2025 12:29:52 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:83d1:ae5d:93a6:6837]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 9328A56D; Fri, 15 Aug 2025 12:28:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1755253737; bh=j4Fiq/Uh0jI/8In43aIBg2nFGhIcw7tf+4tpyxSDpwc=; h=From:To:Cc:Subject:Date:From; b=iyOXvxb/AFf9bBZEIU8PldNQctjkDRjeuz6NTpX+zEUlv/VTOxtahw6Qx/koURCWq 1zvakmhLleY6pyQdbduAfUjYbKoNvCB9wxeqlxCg9RCRb1rYm0NpGucesN/aPyejl0 Eowolc/WdcVZ3U2L9E3qI5Yjc5Zq4bjyao/gTJ8c= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v3 00/19] Implement WDR algorithm Date: Fri, 15 Aug 2025 12:29:20 +0200 Message-ID: <20250815102945.1602071-1-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi all, This series implements a global tone mapping algorithm for rkisp1. The details of the algorithms are explained in patch 15/16, so I won't repeat them here. v1 of the series was here: https://patchwork.libcamera.org/project/libcamera/list/?series=5122 v2 was here: https://patchwork.libcamera.org/project/libcamera/list/?series=5364 Changes in v3: I hope I addressed all points from the last review. Some feedback got me thinking and that lead to the WDR algorithm being reworked a bit. Basically I replaced the formar regulation loop + WDR-exposure-value with a additional constraint in the AGC regulation. That allowed me to ditch the PID controller (for now). I believe the structure is easier now. For that to work I needed a way to add constraints to the AGC at runtime. The current implementation is in patch 16. I'm not ebtirely happy with that due to dynamic allocations in the scope of the frame context. So maybe we have to come up with a neater way there. Changes in v2: Compared to v1 of the series there were quite some changes. The old series contained mitigation for exposure quantization using the AWB gains. During my work on HDR stitching support it got clear that we need to use the compression curve from the companding block of the imx8mp. That curve can serve as a way better gain than the AWB gains, so I added a compression algorithm (patches 1-2) which then is used for the quantization correction. The quantization correction was generalized to support exposure and gain quantization effects (patches 3-9). Patch 10 spilled over from the WDR preparation series and now has a (possibly) better commit message. The rest is the actual WDR implementation that was mostly there in v1. I fixed a few bugs and included changes from review (thanks Paul). The details are in the individual patches. Best regards, Stefan Stefan Klug (19): ipa: rkisp1: Add basic compression algorithm tuning: rksip1: Add a static Compress entry libipa: camera_sensor_helper: Add quantizeGain() function libipa: exposure_mode_helper: Take exposure/gain quantization into account libipa: exposure_mode_helper: Remove double calculation of lastStageGain libipa: exposure_mode_helper: Remove unnecessary clamp calls libipa: agc_mean_luminance: Fix constraint logging libipa: agc_mean_luminance: Configure the exposure mode helpers libipa: exposure_mode_helper: Calculate quantization gain in splitExposure() ipa: rkisp1: agc: Add correction for exposure quantization pipeline: rkisp1: Add error log when parameter queuing fails include: linux: Partially update linux headers from v6.16-rc1-310-gd968e50b5c26 ipa: rkisp1: Switch histogram to RGB combined mode pipeline: rkisp1: Query kernel for available params blocks libipa: agc_mean_luminance: Introduce effectiveYTarget() accessor libipa: agc_mean_luminance: Add support for additional constraints rkisp1: agc: Agc add yTarget to frame context ipa: rkisp1: Add WDR algorithm tuning: rksip1: Add a static WideDynamicRange entry include/libcamera/ipa/rkisp1.mojom | 2 +- include/linux/rkisp1-config.h | 108 ++++- include/linux/v4l2-controls.h | 6 + src/ipa/ipu3/algorithms/agc.cpp | 6 +- src/ipa/libipa/agc_mean_luminance.cpp | 58 ++- src/ipa/libipa/agc_mean_luminance.h | 8 +- src/ipa/libipa/camera_sensor_helper.cpp | 23 ++ src/ipa/libipa/camera_sensor_helper.h | 1 + src/ipa/libipa/exposure_mode_helper.cpp | 108 +++-- src/ipa/libipa/exposure_mode_helper.h | 12 +- src/ipa/mali-c55/algorithms/agc.cpp | 7 +- src/ipa/rkisp1/algorithms/agc.cpp | 67 ++- src/ipa/rkisp1/algorithms/compress.cpp | 102 +++++ src/ipa/rkisp1/algorithms/compress.h | 30 ++ src/ipa/rkisp1/algorithms/meson.build | 2 + src/ipa/rkisp1/algorithms/wdr.cpp | 493 +++++++++++++++++++++++ src/ipa/rkisp1/algorithms/wdr.h | 58 +++ src/ipa/rkisp1/ipa_context.h | 28 ++ src/ipa/rkisp1/params.cpp | 1 + src/ipa/rkisp1/params.h | 2 + src/ipa/rkisp1/rkisp1.cpp | 20 +- src/libcamera/control_ids_draft.yaml | 62 +++ src/libcamera/pipeline/rkisp1/rkisp1.cpp | 38 +- utils/tuning/rkisp1.py | 8 +- 24 files changed, 1175 insertions(+), 75 deletions(-) create mode 100644 src/ipa/rkisp1/algorithms/compress.cpp create mode 100644 src/ipa/rkisp1/algorithms/compress.h create mode 100644 src/ipa/rkisp1/algorithms/wdr.cpp create mode 100644 src/ipa/rkisp1/algorithms/wdr.h