From patchwork Fri Aug 8 14:12:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 24071 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C317DBDCC1 for ; Fri, 8 Aug 2025 14:13:45 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7E3146921E; Fri, 8 Aug 2025 16:13:44 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Yntbjr3C"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 822D96084D for ; Fri, 8 Aug 2025 16:13:43 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:3ea1:35ac:90da:a221]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 731EF185B; Fri, 8 Aug 2025 16:12:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1754662373; bh=ZC/GjiRbqY0GiqLHlG66BwYm3aV5p9K2rxbnCAfaOIk=; h=From:To:Cc:Subject:Date:From; b=Yntbjr3CbsChST1T7YBnbdPoGEWhOd/mYGNqJvEnh0MXAA8uA5XSzQh3497+/L/b7 zPtmwkwR5ueaofdSY+9ZLjhDx1TnAn5Z9wZg/EULjFlD29g6Fwzdpmac4JCXbYL0l+ 7byCjBshCFH0A3j32H6GT4+OoX1uy2D4c8oYAU30= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v2 00/16] Implement WDR algorithm Date: Fri, 8 Aug 2025 16:12:38 +0200 Message-ID: <20250808141315.413839-1-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi all, This series implements a global tone mapping algorithm for rkisp1. The details of the algorithms are explained in patch 15/16, so I won't repeat them here. v1 of the series was here: https://patchwork.libcamera.org/project/libcamera/list/?series=5122 Compared to v1 of the series there were quite some changes. The old series contained mitigation for exposure quantization using the AWB gains. During my work on HDR stitching support it got clear that we need to use the compression curve from the companding block of the imx8mp. That curve can serve as a way better gain than the AWB gains, so I added a compression algorithm (patches 1-2) which then is used for the quantization correction. The quantization correction was generalized to support exposure and gain quantization effects (patches 3-9). Patch 10 spilled over from the WDR preparation series and now has a (possibly) better commit message. The rest is the actual WDR implementation that was mostly there in v1. I fixed a few bugs and included changes from review (thanks Paul). The details are in the individual patches. Best regards, Stefan Stefan Klug (16): ipa: rkisp1: Add basic compression algorithm tuning: rksip1: Add a static Compress entry libipa: camera_sensor_helper: Add quantizeGain() function libipa: exposure_mode_helper: Take exposure/gain quantization into account libipa: exposure_mode_helper: Remove double calculation of lastStageGain libipa: exposure_mode_helper: Remove unnecessary clamp calls libipa: agc_mean_luminance: Configure the exposure mode helpers libipa: exposure_mode_helper: Calculate quantization gain in splitExposure() ipa: rkisp1: agc: Add correction for exposure quantization pipeline: rkisp1: Add error log when parameter queuing fails include: linux: Partially update linux headers from v6.16-rc1-310-gd968e50b5c26 libcamera: Add PID controller class ipa: rkisp1: Switch histogram to RGB combined mode pipeline: rkisp1: Query kernel for available params blocks ipa: rkisp1: Add WDR algorithm tuning: rksip1: Add a static WideDynamicRange entry include/libcamera/internal/meson.build | 1 + include/libcamera/internal/pid_controller.h | 46 ++ include/libcamera/ipa/rkisp1.mojom | 2 +- include/linux/rkisp1-config.h | 108 ++++- include/linux/v4l2-controls.h | 17 +- src/ipa/ipu3/algorithms/agc.cpp | 4 +- src/ipa/libipa/agc_mean_luminance.cpp | 22 +- src/ipa/libipa/agc_mean_luminance.h | 3 +- src/ipa/libipa/camera_sensor_helper.cpp | 23 + src/ipa/libipa/camera_sensor_helper.h | 1 + src/ipa/libipa/exposure_mode_helper.cpp | 103 ++-- src/ipa/libipa/exposure_mode_helper.h | 12 +- src/ipa/rkisp1/algorithms/agc.cpp | 35 +- src/ipa/rkisp1/algorithms/compress.cpp | 100 ++++ src/ipa/rkisp1/algorithms/compress.h | 33 ++ src/ipa/rkisp1/algorithms/meson.build | 2 + src/ipa/rkisp1/algorithms/wdr.cpp | 510 ++++++++++++++++++++ src/ipa/rkisp1/algorithms/wdr.h | 64 +++ src/ipa/rkisp1/ipa_context.h | 23 + src/ipa/rkisp1/params.cpp | 1 + src/ipa/rkisp1/params.h | 2 + src/ipa/rkisp1/rkisp1.cpp | 20 +- src/libcamera/control_ids_debug.yaml | 7 +- src/libcamera/control_ids_draft.yaml | 70 +++ src/libcamera/meson.build | 1 + src/libcamera/pid_controller.cpp | 172 +++++++ src/libcamera/pipeline/rkisp1/rkisp1.cpp | 38 +- utils/tuning/rkisp1.py | 9 +- 28 files changed, 1364 insertions(+), 65 deletions(-) create mode 100644 include/libcamera/internal/pid_controller.h create mode 100644 src/ipa/rkisp1/algorithms/compress.cpp create mode 100644 src/ipa/rkisp1/algorithms/compress.h create mode 100644 src/ipa/rkisp1/algorithms/wdr.cpp create mode 100644 src/ipa/rkisp1/algorithms/wdr.h create mode 100644 src/libcamera/pid_controller.cpp