From patchwork Mon Aug 4 16:38:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 24047 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5EE6CBDCC1 for ; Mon, 4 Aug 2025 16:38:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 650CE6921D; Mon, 4 Aug 2025 18:38:26 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="Jvhf8c7b"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 878266920D for ; Mon, 4 Aug 2025 18:38:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754325503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3Ck5qLVpcA+1PYF3Lm+Cen6ZlIu0QEaqy0tfbcYp3zI=; b=Jvhf8c7bmDoWIfmM0p21EPe4dxp1+KB7eZ0CidhpOBWYRymWMZEVgJPkIBB7BAxBOMwcv7 ZG44XXmMSx8D37/EqGIhgVhPw8M8/iyAuX2c0BF/NdVjMjcG5WVmMCNzTqoxYjilMD8mnJ CTOQMxSs8N+/SAsjFK9wKWRx+vdvmyU= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-384-XQ8cN2xmMwaKmXcEgU0iTA-1; Mon, 04 Aug 2025 12:38:20 -0400 X-MC-Unique: XQ8cN2xmMwaKmXcEgU0iTA-1 X-Mimecast-MFC-AGG-ID: XQ8cN2xmMwaKmXcEgU0iTA_1754325499 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E41331955DA4; Mon, 4 Aug 2025 16:38:18 +0000 (UTC) Received: from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.17]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C0DDD1800D8A; Mon, 4 Aug 2025 16:38:15 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Laurent Pinchart , Kieran Bingham , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= , Paul Elder , Umang Jain Subject: [PATCH v12 0/8] Enable raw streams with software ISP Date: Mon, 4 Aug 2025 18:38:03 +0200 Message-ID: <20250804163812.126022-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mSW0Kyr2Zt9X8dGQQzLXKLWKfMhuTWqdkfzYH2iV2xo_1754325499 X-Mimecast-Originator: redhat.com X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This makes raw streams working again in ‘simple’ pipeline when software ISP is enabled for the given device. At most one raw stream and one processed stream (possibly both at once) are supported. An example ‘cam’ invocation requesting a raw stream rather than a debayered stream: cam -c1 -C8 -s role=raw,width=1920,height=1080 -Ffile#.raw Or for both raw and processed streams: cam -c1 -C8 -Ffile# \ -s role=viewfinder,width=1920,height=1080,pixelformat=RGB888 \ -s role=raw,width=3280,height=2464,pixelformat=SRGGB8 When only a raw stream is requested, there are no exposure/gain adjustments applied. This could be improved in future, once software ISP gets a mechanism to gather image statistics without processing and using them to make the adjustments, or once manual exposure controls are added to software ISP. In the meantime, exposure must be changed externally. Changes in v12: - Formatting change suggested by Laurent. - The patch setting the number of software ISP streams moved after the patches enabling raw streams. - Colour spaces are set and validated according to the pixel format and only pixel format. Changes in v11: - Use rawStream_ pointer to a raw stream rather than rawRequested_ and processedRequested_ flags, as suggested by Umang. - Selection of pipeline configurations reworked, partially incorporating Umang’s ideas and permitting adjustments of raw stream configurations if they don’t match the processed stream or what’s available from the sensor. - Tested-by tags removed from here because the changes are substantial. v11 works better for me than both v10 and Umang’s RFC but it requires independent testing. Changes in v10: - Missing initialisation of swIspEnabled_ added. - "Add plain output configurations" patch dropped. Raw configurations can be built implicitly from capture parameters. Related adjustments in "Validate raw stream configurations". - "Identify requested stream roles" patch dropped and merged into followup patches; camera configuration is updated in validate() and not in generateConfiguration() now. - A commit title improved as suggested by Umang. Changes in v9: - Fix of calling a wrong output buffer allocator when both raw and processed streams are used. Changes in v8: - A missing `status = Adjusted' added to SimpleCameraConfiguration::validate. - Code comments regarding raw colour space for raw requested roles added. - Dropped raw format helpers. Changes in v7: - Rebased on current master. Changes in v6: - An unnecessary copy of formats avoided. - rawRequested_ and processedrequested_ set to false when there are no roles. - rawRequested_ and processedrequested_ updated in SimpleCameraConfiguration::validate(). Changes in v5: - Possible temporary segfault in the patch adding plain output configurations avoided. - PixelFormatInfo::isRaw() helper added. - SimplePipelineHandler::setUpFormatSizes replaced with a lambda function. - SimpleCameraData::{rawRequested_,processedRequested_} are set in SimpleCameraConfiguration first and copied to SimpleCameraData only after successful configure(). Changes in v4: - Broken range pruning due to passing a value rather than a reference fixed. - New common function isFormatRaw introduced. - The patch assigning colour spaces in the simple pipeline, previously posted separately, included in this series, as the first patch. It can still be handled separately; in any case the rest sort of depends on it. - Setting metadataRequired to false where needed to prevent freezes and assertion errors; related to metadata reporting support merged to master since v3. Changes in v3: - Significantly reworked, with both functional and clarity improvements. The level of guesswork and confusion is hopefully reduced enough now to drop the RFC prefix. - The number of streams is set to 2 only with software ISP. - SimpleCameraData::pipeConfig_ nullptr check patch dropped. - PPM/raw file output patch dropped from this series. Let’s handle this separately as the patch series is already complex enough. Changes in v2: - Completely reworked. - Extended to be able to produce a raw stream together with a processed stream. Milan Zamazal (8): libcamera: software_isp: Assign colour spaces in configurations libcamera: simple: Exclude raw configurations from output conversions libcamera: simple: Handle processed and raw formats separately libcamera: simple: Validate raw stream configurations libcamera: simple: Don't enforce conversion with an added raw stream libcamera: simple: Set the number of software ISP streams to 2 libcamera: simple: Require metadata only when software ISP is used libcamera: simple: Make raw streams working src/libcamera/pipeline/simple/simple.cpp | 276 +++++++++++++++++------ 1 file changed, 213 insertions(+), 63 deletions(-)