From patchwork Mon Jul 21 07:47:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 23859 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 72BACBDCC1 for ; Mon, 21 Jul 2025 07:49:00 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C299868FCC; Mon, 21 Jul 2025 09:48:58 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="MvTL4CJw"; dkim-atps=neutral Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 42A4261509 for ; Mon, 21 Jul 2025 09:48:56 +0200 (CEST) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3b39c46e1cfso628331f8f.3 for ; Mon, 21 Jul 2025 00:48:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1753084135; x=1753688935; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Tf4tCcQYYwRkQGvbtTyEZ5enC/L+9eiBi4mJxGqW1KY=; b=MvTL4CJwrtBtw9hP0Fym9WYq62wX15KKJBq+0jINoZLHT+gHN6YOLoR6QUItJuWR0Y mrHUR+YQ59GRbpWHrmDfWSOjRghZO4dfXNyTaAJjVKBWWGwoLiarabyWr/TBnp2yJ/dY qW1YCFOYYavwXzUpjYHGuVc+IxhaRLi8Q/3U9UblBvZtojto3ldYBqtJa6JccBZUhQET e7pAxSNAOsjRsIn9ebJLQyzvzcfXs+koCveJbGhD+av2PT5Z5ZaMSAGy5KAwn5QFK8gf Cn32AQ8bpR0pnBpvqJbUZsNQfXcGiLasch8wqLPVuzfW4p6R0ES5faIhECtQ4F2dgkkI itVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753084135; x=1753688935; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Tf4tCcQYYwRkQGvbtTyEZ5enC/L+9eiBi4mJxGqW1KY=; b=krCnBhACRgui2OMiNwOV2sURB3TPzt1Xu+LnLoZ833K9EnBVy9WxCXsHUhJLMLp82w 5c7mOeUw65QVqlCteYeVB4gUNOszSjG4nPgm0BLP80+3NFvg+XziBZyO7btEun+7/ZDE GbMva/PlV3aQ9QyOplHtAYWZpsp8VmMmQNLLAMMD4EKp9ZRYhdn4Su9vu08aqbOndwIC dd3QBTPM+tHFzdAdsuLxKEFbnprfTnO1BMyi6HL63DE7FFxfO11qspKnjEZzw2kTR+Th s9/KWPRhNy0bJOy3OhTvKRM8rV8w0vn+ixVFU6a53GxZYDEnwmZpEcN9zu6k8cZ+qDO1 WPhQ== X-Gm-Message-State: AOJu0YxoFsrzTzq1aOBwgYqa3+apb3YLpM4nTuRAos9ITkfPNCQgXh2E 0gC2/8bqOzHYqyEUadXm9baeBg8siKHhpDolHVGrsF2OlsXYqGl39stF5O0aBIbDbKnd2cJ5VPz 4HWHGIfU= X-Gm-Gg: ASbGnctG9HzjapOVmWtzmwvGJqwFwl71xYrHieO6vs9ADkU41iTXER/TCWLMJFJrEUf 8qgTV6YGt7veHePJnLAq0pAC8f9bwgn0RbGB6y3ESYgHDBe0PoamRbrPjEoK6hcu7V6SuTDn4LB FY7TzVfM3BJsw17rifTrW7FHWpMsGk6U5GSYyk8/LY+iaeZUaQg8vWzT6PSqnUO73rq2h3zXA/x 50VRJTw8nA0yN8+gZgUnN5jS4nPbCVZ0uVaWG5sJCJBUJy+qcO1hN9nQNmEzLKFQuJ/LOlXHFxc YPxySmmFWFzg82/VuwGIjTUVOti40IRkxzP3Cs0NrtJhG0DCs1yESc58eNO8BB6/Eh6a5JhwCnw 2HWbJ3TkOywWRX7VssJ+ohG79kQiWp3PREZm52CMpWk715AgSwK7o X-Google-Smtp-Source: AGHT+IGcfvRQPdYDFJ1ngA7ODjck5M0ZpA/p4O0xtKNFUFppZY0lKzqzl7dnpgk8ew71fJ2ORghGsg== X-Received: by 2002:a05:6000:240d:b0:3a4:e0e1:8dbd with SMTP id ffacd0b85a97d-3b60dd78ceamr6283347f8f.11.1753084135347; Mon, 21 Jul 2025 00:48:55 -0700 (PDT) Received: from NAUSH-P-DELL.pitowers.org ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4562e802afasm151101765e9.12.2025.07.21.00.48.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jul 2025 00:48:55 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck Subject: [PATCH v2 0/7] Raspberry Pi AEC/AGC update Date: Mon, 21 Jul 2025 08:47:20 +0100 Message-ID: <20250721074853.1463358-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, As requested, here is v2 of The AGC changes originally submitted by David. I've rebased to the top of master and added my tags, but no other functional changes made. Thanks! Naush David Plowman (7): ipa: rpi: agc: Change handling of colour gains less than 1 ipa: rpi: agc: Make the maximum digital gain configurable ipa: rpi: agc: Rename "analogue gain" to "gain" where appropriate ipa: rpi: Advance the delay context counter even when IPAs don't run ipa: rpi: agc: Calculate digital gain in process() ipa: rpi: Update digital gain handling in IPA base and derived classes ipa: rpi: agc: Remove digital gain from AgcPrepareStatus src/ipa/rpi/common/ipa_base.cpp | 71 ++++--- src/ipa/rpi/common/ipa_base.h | 6 +- src/ipa/rpi/controller/agc_algorithm.h | 2 +- src/ipa/rpi/controller/agc_status.h | 4 +- src/ipa/rpi/controller/rpi/agc.cpp | 6 +- src/ipa/rpi/controller/rpi/agc.h | 4 +- src/ipa/rpi/controller/rpi/agc_channel.cpp | 236 +++++++++------------ src/ipa/rpi/controller/rpi/agc_channel.h | 6 +- src/ipa/rpi/pisp/pisp.cpp | 81 ++++--- src/ipa/rpi/vc4/vc4.cpp | 42 +++- 10 files changed, 248 insertions(+), 210 deletions(-)