From patchwork Mon Jul 7 08:55:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 23749 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4636BC3237 for ; Mon, 7 Jul 2025 08:55:38 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BD6A368E85; Mon, 7 Jul 2025 10:55:36 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Yvv8nvxH"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CEC7568E66 for ; Mon, 7 Jul 2025 10:55:34 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:c79f:85df:e7f5:4c31]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id DCCF6190D; Mon, 7 Jul 2025 10:55:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1751878508; bh=N+C2OolqJpyDO3A0IsfOjMFQJC5tbsLzTdcgtfhoy2E=; h=From:To:Cc:Subject:Date:From; b=Yvv8nvxHSBqpCRCdQafadLMpJSl6jmSRnjcmpSjS0WIZf99Jm2sCODIgjwMbxsLbn AJy+4hTTUzO87e1wPeoq07M618rK8f244U/l0JZTMQe0FOlZ8Ay0uu6ezY+Sdqetgn zb/QGQew21GWYTmvYpZVavY0ki3ZwyRG6/u89rJk= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v3 0/9] Wdr preparations Date: Mon, 7 Jul 2025 10:55:03 +0200 Message-ID: <20250707085520.39777-1-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi all, This is v3 of the wdr preparation series. I hope it is ready to go. Most of the patches have 2 rby tags. I repost because patch 6 and 7 were reworked. Patch 6 contains the error message when queuing parameter buffers fails. The functionality to check for available parameter types was pulled into linux 6.17. I therefore reduced the error message in patch 6 to a generic "Failed to queue parameter buffer" as this might still be valuable information even though it is not expected to happen regularly. Patch 7 was simplified as result of the reviews and therefore misses the rby tags. Best regards, Stefan --- Old cover letter below. This v2 fixes a few minor errors found in v1. The main reason for the repost is to create a basis for the upcoming WDR series. The rest of the text here is unmodified (the changelogs are in the patches). This patch series does a bit of preparatory work for the upcoming WDR support. The patches are a mix of topics but as they are all quite small, I thought that a small series might be the best fit. Patches 1-3 are tiny improvements in gen-debug-controls that ease the day to day work. Patches 4 and 7 add a bit of debug logging. Patches 5-6 fix a bug in the rkisp1 parameters handling. Patches 8-9 add support for exposure compensation in rkisp1. I hope you all like it :-) Best regards, Stefan Stefan Klug (9): utils: gen-debug-controls: Remove line number from control description utils: gen-debug-controls: Fix handling of controls that appear multiple times utils: gen-debug-controls: Improve log output libipa: agc_mean_luminance: Add debug logging ipa: rkisp1: params: Check for empty parameters pipeline: rkisp1: Add error log when parameter queuing fails pipeline: v4l2_subdevice: Add color space to format string representation libipa: agc_mean_luminance: Add exposure compensation support ipa: rkisp1: agc: Implement ExposureValue control src/ipa/libipa/agc_mean_luminance.cpp | 36 +++++++++++++++++++++--- src/ipa/libipa/agc_mean_luminance.h | 6 ++++ src/ipa/rkisp1/algorithms/agc.cpp | 10 +++++++ src/ipa/rkisp1/ipa_context.h | 2 ++ src/ipa/rkisp1/params.cpp | 3 ++ src/ipa/rkisp1/params.h | 3 ++ src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 +++++- src/libcamera/v4l2_subdevice.cpp | 2 ++ utils/gen-debug-controls.py | 28 +++++++++++++++--- 9 files changed, 90 insertions(+), 9 deletions(-)