From patchwork Wed May 21 12:53:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 23410 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id F1CC1C31E9 for ; Wed, 21 May 2025 12:53:34 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BFA0468D94; Wed, 21 May 2025 14:53:33 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="QhZnYZA/"; dkim-atps=neutral Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id F150868C91 for ; Wed, 21 May 2025 14:53:30 +0200 (CEST) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-3a365a6804eso2662920f8f.3 for ; Wed, 21 May 2025 05:53:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1747832010; x=1748436810; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=M3QoAdOlM/W8YOyXRP6oBRewxj7wKzbiTjsS8D7ee7c=; b=QhZnYZA/Lo9UmWfheNaJn8jq1SJRssniPxG5b6sy1cT7HPFgk8I1YKKjXExqvyFYdE QojbVlxQXWpcgWo4Pzk5nYsHSBuA5R2lR5p76+ZQMx/pt/YIAIzMEOpXBNJNT1txROkx 7kdjLOs8RvFmvTJA3jTsTjXpZdmNJW3ILs9yq4x3tkRMULMq9DO8h8X37xaCU2Ng7XNr LeOk0WvgO/FTYt6TffVL+xYxX7FWVRdt557Z++oIPqb1sXgRQrSB583ThuADAyQ/tE+P zYt/o+LTA2Vrq4uLv1myM/4cKRh2Q0xXzettz+P3pzndK7AqD1nYg7LzSGPBv5K7CHWz ztFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747832010; x=1748436810; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M3QoAdOlM/W8YOyXRP6oBRewxj7wKzbiTjsS8D7ee7c=; b=gRFuSbrLMC0hJsSyyKYaD6kVKEF+bqOByKoKXVECZP9SY82YodIfVJMZgx28G2mtrd f9yJeHThboLJIvlfEHBVOM9+LaSfE4JlZ3eABiSE9x/bGXrv5S1kXuJ9Vdfa9lyweopT gCHP5V7ALmpKynNFN6aTScxOFWm5ZZGbEyCGJ+tk8ItXIg6WWJ3a8LbmhfOTeWfQXAl5 MUP9QX49LuLdTnRu/s1TfAn9DldO7/esUhAsdLLZtpWpXYpywMcFgzQH0zm8w24PYPfy pjZqI3e3G7ydkAre+TPxheulB0uH+qs4ZLazNdeA2pThLg3Vw1PtR21/7i0Ns0JKEZMT AT4w== X-Gm-Message-State: AOJu0Yykm4BewEbxYbt7kzzzUO8nh6LDvtfkbxhoh1cJI06VT1DKuE+m tgZm8HetSU35wbLmm7cq8b7DSyzlr19P0EsKHctqqvdtiIHBByxzRFJ8PEGS0oeEEyLVlY83Ah1 hjslZpMg= X-Gm-Gg: ASbGncv3U5ZmBXD5yiOXDHKYbeEBfSD4D0obJXunOlMnQ1bfy4JESuswMxYDVJYhFb6 KRzwOi1/MVkuomXVo+YNwuAMaZu+tbNSLeRL+gQaK5NvxWCPI3JHEVzugPy+WZyJwzo7EX+87pg 3Ss6DmQ973FspPAMhY6BcxeHT0xwWA43lmt7rGJku0nWaAotEzXJJMGCPT4gZyTRuIgZBx/bsWy xtlXLxI80H/XQGXw6c8NuIz0MyYZl9hbCdeMTbTyQyBEr4xlx52aMGBjzJw8a7mNv6BCL/8VHHI a3ko+BQEY0wSPQX3cJCo8eEGoYcZteheC2i663Q0kMkHN6n0EKV+6FE9byf0Tky0cnXV1mZNTQp MXuoPuvo= X-Google-Smtp-Source: AGHT+IE1NwdQoqQgbfAY1JEAXk9KRTDRbEZx5QUwzRgH1GVnZHf4zvUOH8UxYRwMZTE9C3tN3eoidA== X-Received: by 2002:a05:6000:2903:b0:3a3:6e62:d8e8 with SMTP id ffacd0b85a97d-3a36e62db92mr11285984f8f.55.1747832009938; Wed, 21 May 2025 05:53:29 -0700 (PDT) Received: from raspberrypi.pitowers.org ([2a00:1098:3142:1f:ffc9:aff6:7f7f:893b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f6f0556bsm67938395e9.12.2025.05.21.05.53.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 May 2025 05:53:29 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Cc: David Plowman Subject: [PATCH 0/1] Fix AeEnable when camera starts Date: Wed, 21 May 2025 13:53:26 +0100 Message-Id: <20250521125327.6378-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone Not a big patch, but also not a lovely one, so folks might have some opinions on how it should look. The problem is that we patch up control lists for the "AeEnable" control when we queue a request, but not when the camera starts - leading to different behaviour depending on when you send your controls. This patch fixes that, by factoring the patch-up code into a separate method, and then, in Camera::start(), we copy the control list because the one passed in is const. Anyway, opinions on how this should look gratefully received, and I'll do another version once things seem clear. Thanks! David David Plowman (1): libcamera: camera: Fix up the AeEnable control during Camera::start() include/libcamera/camera.h | 2 ++ src/libcamera/camera.cpp | 57 +++++++++++++++++++++++++------------- 2 files changed, 40 insertions(+), 19 deletions(-)