From patchwork Sat May 10 14:12:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 23352 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D9342C3226 for ; Sat, 10 May 2025 14:12:34 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2A21C68AD7; Sat, 10 May 2025 16:12:34 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="AfVcV0IU"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 46EBB6175C for ; Sat, 10 May 2025 16:12:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746886351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=36Au2nfCR/z1nayuLN7rVxa36GiISBpjHetrBLZlbcA=; b=AfVcV0IUCeFnJsY6w2mAQ3cgshxc6QS2GVR8pQzEi9YeYfVRWZ6Mkgls2xUHKc6L9sT+Lz 8z3F4nnwf99WMvrA6PqlC1ZMmMFhWKolrn80/ADUJ/Oc0xCFFTPwUccJIPxL4WMCIKkeFE hV4B2uS6WvdAZ5l0Y+GarO9CI/k+PGg= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-SUcVxy0WO26o95zJhwb-bw-1; Sat, 10 May 2025 10:12:29 -0400 X-MC-Unique: SUcVxy0WO26o95zJhwb-bw-1 X-Mimecast-MFC-AGG-ID: SUcVxy0WO26o95zJhwb-bw_1746886348 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3FF2D1955DBA for ; Sat, 10 May 2025 14:12:28 +0000 (UTC) Received: from localhost.localdomain (unknown [10.45.224.58]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A970B1800359; Sat, 10 May 2025 14:12:26 +0000 (UTC) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Hans de Goede Subject: [PATCH v2 0/8] libcamera: Add swstats_cpu::processFrame() and atomisp pipeline handler Date: Sat, 10 May 2025 16:12:12 +0200 Message-ID: <20250510141220.54872-1-hdegoede@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: e7pwHSF4oHSWln8_tL-6tnKnDrt8QzOoWj6b59_ff0U_1746886348 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi All, Here is v2 of my patch series adding support to the swstats_cpu code to process a whole frame in one go (also useful for the GPU-ISP work) and adding a new pipeline handler for the atomisp. Original v1 series: https://patchwork.libcamera.org/cover/21798/ Later rebased resend of just the swstats_cpu::processFrame() changes: https://patchwork.libcamera.org/cover/22186/ Changes in v2: - Rebase on top of latest master - Fix the lack of doxygen documentation - Reworked "[PATCH v2 7/8] libcamera: ipa_manager: createIPA: Allow matching by IPA name instead of by pipeline" this probably is the most controversial change in this series - Modify atomisp pipeline handler to also work with sensors where there is an ISP on the sensor which the driver registers as a separate v4l2-subdev like the MT9M114 sensor driver Patches 1-4 have already been reviewed by both Kieran and Milan. Please review patches 5-8. This has already successfully passed the CI, see: https://gitlab.freedesktop.org/camera/libcamera-softisp/-/commits/atomisp-v2/ Regards, Hans Hans de Goede (8): libcamera: swstats_cpu: Update statsProcessFn() / processLine0() documentation libcamera: swstats_cpu: Drop patternSize_ documentation libcamera: swstats_cpu: Move header to libcamera/internal/software_isp libcamera: software_isp: Move benchmark code to its own class libcamera: swstats_cpu: Add processFrame() method libcamera: swstats_cpu: Add support for YUV420 libcamera: ipa_manager: createIPA: Allow matching by IPA name instead of by pipeline libcamera: Add new atomisp pipeline handler include/libcamera/internal/ipa_manager.h | 7 +- include/libcamera/internal/ipa_module.h | 4 +- .../internal/software_isp/benchmark.h | 36 + .../internal/software_isp/meson.build | 2 + .../internal}/software_isp/swstats_cpu.h | 18 + meson.build | 1 + meson_options.txt | 1 + src/ipa/simple/data/uncalibrated_atomisp.yaml | 7 + src/libcamera/ipa_manager.cpp | 6 +- src/libcamera/ipa_module.cpp | 19 +- src/libcamera/pipeline/atomisp/atomisp.cpp | 636 ++++++++++++++++++ src/libcamera/pipeline/atomisp/meson.build | 5 + src/libcamera/software_isp/benchmark.cpp | 93 +++ src/libcamera/software_isp/debayer_cpu.cpp | 36 +- src/libcamera/software_isp/debayer_cpu.h | 9 +- src/libcamera/software_isp/meson.build | 3 +- src/libcamera/software_isp/swstats_cpu.cpp | 178 ++++- 17 files changed, 985 insertions(+), 76 deletions(-) create mode 100644 include/libcamera/internal/software_isp/benchmark.h rename {src/libcamera => include/libcamera/internal}/software_isp/swstats_cpu.h (79%) create mode 100644 src/ipa/simple/data/uncalibrated_atomisp.yaml create mode 100644 src/libcamera/pipeline/atomisp/atomisp.cpp create mode 100644 src/libcamera/pipeline/atomisp/meson.build create mode 100644 src/libcamera/software_isp/benchmark.cpp Tested-by: Bryan O'Donoghue # Dell Tested-by: Bryan O'Donoghue # Dell