From patchwork Thu May 1 09:58:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 23324 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8E549BE08B for ; Thu, 1 May 2025 09:58:24 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B7B2268ADC; Thu, 1 May 2025 11:58:23 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="UK+2opQ8"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6216068ACC for ; Thu, 1 May 2025 11:58:22 +0200 (CEST) Received: from pb-laptop.local (185.221.143.50.nat.pool.zt.hu [185.221.143.50]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 450AA2E0 for ; Thu, 1 May 2025 11:58:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1746093495; bh=INfHlWHcmHZmmKqtY4vUpLGgUUwXbuYzrAgms6ycLOc=; h=From:To:Subject:Date:From; b=UK+2opQ89d0thN1aRrZxsr55ZssVBLmiGdavncpSzIq2mukJAwWBHM8HOaKsVAHI1 a95UjCbDCYnf6U4uALoYd8Pb3WYKpYYOobmFMUg/hq+iLABqZQU92aFZRvXwJ1NOjz 8NGsfNrz9KK42FtTQqRHYFDrlCcyFXFJtvKlT4c4= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [PATCH v2 0/3] libcamera: controls: String controls as `std::string_view` Date: Thu, 1 May 2025 11:58:15 +0200 Message-ID: <20250501095818.3996419-1-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This change brings string controls in line with other controls in that no non-trivial copies will be made when a value is retrieved from a `ControlValue` instance. https://bugs.libcamera.org/show_bug.cgi?id=256 changes in v2: * fix rebuilding when controls.py is modified v1: https://patchwork.libcamera.org/cover/23204/ Barnabás Pőcze (3): apps: cam: capture_script: Disallow arrays of strings utils: codegen: Make users depend on `controls.py` in meson libcamera: controls: Expose string controls as `std::string_view` include/libcamera/control_ids.h.in | 1 + include/libcamera/controls.h | 15 ++++++++------- include/libcamera/meson.build | 1 + src/apps/cam/capture_script.cpp | 6 +----- src/apps/cam/main.cpp | 2 +- src/apps/common/dng_writer.cpp | 2 +- src/apps/qcam/cam_select_dialog.cpp | 6 +++--- src/gstreamer/meson.build | 1 + src/libcamera/meson.build | 1 + src/py/libcamera/meson.build | 2 ++ src/py/libcamera/py_helpers.cpp | 4 ++-- test/controls/control_value.cpp | 4 ++-- utils/codegen/controls.py | 2 +- utils/codegen/meson.build | 2 ++ 14 files changed, 27 insertions(+), 22 deletions(-) --- 2.49.0