From patchwork Fri Apr 11 12:36:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 23157 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id F179DC327D for ; Fri, 11 Apr 2025 12:36:49 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 38FB968A9D; Fri, 11 Apr 2025 14:36:49 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="XEA57ej6"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C38DA689A5 for ; Fri, 11 Apr 2025 14:36:46 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:5b21:2ad5:1023:7179]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 40A021E6; Fri, 11 Apr 2025 14:34:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1744374887; bh=JPGQBzDo5WX5OABaFTGGZcGdshovcZrdP4Ko6E2wdkc=; h=From:To:Cc:Subject:Date:From; b=XEA57ej6h8+sf9Kok9hqcPcAeWDlgIMbj1a1voKxmGGLwfBmUwb0Rm7HYtaZ/SwP9 GGjpJMvYKQbPA2bnsN1/QNXVch54eeMbZBP5O2bctyUnOjam5gggRjVqhHVUvYJLfK tyMHzaFjO2OUZBPMSU4DlbhPqTkAUEwM8B/jxKIY= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v2 0/9] Wdr preparations Date: Fri, 11 Apr 2025 14:36:28 +0200 Message-ID: <20250411123641.2144530-1-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi all, This v2 fixes a few minor errors found in v1. The main reason for the repost is to create a basis for the upcoming WDR series. The rest of the text here is unmodified (the changelogs are in the patches). This patch series does a bit of preparatory work for the upcoming WDR support. The patches are a mix of topics but as they are all quite small, I thought that a small series might be the best fit. Patches 1-3 are tiny improvements in gen-debug-controls that ease the day to day work. Patches 4 and 7 add a bit of debug logging. Patches 5-6 fix a bug in the rkisp1 parameters handling. Patches 8-9 add support for exposure compensation in rkisp1. I hope you all like it :-) Best regards, Stefan Stefan Klug (9): utils: gen-debug-controls: Remove line number from control description utils: gen-debug-controls: Fix handling of controls that appear multiple times utils: gen-debug-controls: Improve log output libipa: agc_mean_luminance: Add debug logging ipa: rkisp1: params: Check for empty parameters pipeline: rkisp1: Add more info when parameter queue fails pipeline: rkisp1: Add color space information to debug log libipa: agc_mean_luminance: Add exposure compensation support ipa: rkisp1: agc: Implement ExposureValue control src/ipa/libipa/agc_mean_luminance.cpp | 31 +++++++++++++++++++++--- src/ipa/libipa/agc_mean_luminance.h | 6 +++++ src/ipa/rkisp1/algorithms/agc.cpp | 10 ++++++++ src/ipa/rkisp1/ipa_context.h | 2 ++ src/ipa/rkisp1/params.cpp | 3 +++ src/ipa/rkisp1/params.h | 3 +++ src/libcamera/pipeline/rkisp1/rkisp1.cpp | 13 ++++++++-- utils/gen-debug-controls.py | 28 ++++++++++++++++++--- 8 files changed, 86 insertions(+), 10 deletions(-)