From patchwork Tue Apr 1 12:36:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 23087 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 39353C3213 for ; Tue, 1 Apr 2025 12:36:39 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 786B168981; Tue, 1 Apr 2025 14:36:38 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="At1ao7Kg"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C708A68947 for ; Tue, 1 Apr 2025 14:36:37 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:14c7:4fcc:495b:719f]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 80DD16F9; Tue, 1 Apr 2025 14:34:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1743510885; bh=uksJ+BbnDNFPjbGwQAb7CA98DUZvTbwmFhloWJEmolY=; h=From:To:Cc:Subject:Date:From; b=At1ao7KgJd5ylVQ7tyFt42jp3SJVqLOaWKhfEPTxzEsFcisGcczyxTZks3wgEPJxb umlFXI6hS+HQJsFG2axlj2gI1q2DnJ8XBIqSSmyQt22XhTAvsYYLMrOcClg1DYf62L wJSY7c+yOFcmxhUHU1PxFH7QSbRaOkiPaRP1kxAs= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v2 0/5] Fix histogram for some (corner) cases Date: Tue, 1 Apr 2025 14:36:08 +0200 Message-ID: <20250401123633.58887-1-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi all, during my work on WDR I stumbled over a few non-linearities when dealing with small inter quantile mean ranges. These led to hard to handle oscillations. This series adds a testcase for the histogram class and fixes the related issues. Patch 1 adds the basic tests that pass with the current implementation. Patch 2-3 fix issues in the quantile() implementation and add corresponding tests. Patch 4-5 fix issues in the interQuantileMean() implementation and also add tests. Best regards, Stefan Changes in v2: - Add failing tests before the fix patches - Include stylistic changes from review Stefan Klug (5): test: ipa: libipa: Add histogram tests test: ipa: libipa: histogram: Add tests for quantile() returning a fraction libipa: histogram: Fix quantile() calculation for fractional results test: ipa: libipa: histogram: Add tests for small inter quantile mean ranges libipa: histogram: Fix interQuantileMean() for small ranges src/ipa/libipa/histogram.cpp | 42 ++++++++++++++-------- test/ipa/libipa/histogram.cpp | 66 +++++++++++++++++++++++++++++++++++ test/ipa/libipa/meson.build | 4 ++- 3 files changed, 96 insertions(+), 16 deletions(-) create mode 100644 test/ipa/libipa/histogram.cpp