From patchwork Wed Mar 26 13:47:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 23054 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 040F6C323E for ; Wed, 26 Mar 2025 13:48:05 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A47C768969; Wed, 26 Mar 2025 14:48:03 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="me3eQhpF"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B1FB968950 for ; Wed, 26 Mar 2025 14:48:01 +0100 (CET) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:b21a:42f4:9f3:1df6]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9B5FE3A4; Wed, 26 Mar 2025 14:46:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1742996773; bh=R4vb4SbSonixNEI6uFq49WpwamWzRe8aMaESrtPvIYw=; h=From:To:Cc:Subject:Date:From; b=me3eQhpFE6GeacQb39pjNvnk3IPm0Mn/TQ6PfA0ilp0KpHF7fpAh42qMzxluDupkd rzgkWJhI8pGWNdkWirbly79P1Exh574ncY+Lov9x9hsrreqlEqQbl9ldVLg9jBkfU6 J10mDh88QZWVudsHYtfOfEKEH6tnY4y5RrvRU0qM= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v2 0/3] rkisp1: Reduce oscillations on startup Date: Wed, 26 Mar 2025 14:47:19 +0100 Message-ID: <20250326134727.279393-1-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi all, This tiny series further reduces startup AE oscillations on rkisp1. While analyzing the issue it got clear that the regulation had to cope with images that had an exposure value of 0 which should not happen in first place. Patch 1 adds a log message that could help debug such ill behavior. Patch 2 add error handling for the exposurevalue == 0 case. Patch 3 fixes it for rkisp1. Please see the individual patches for the technical details. Best regards, Stefan Changes in v2: - Some fixes from review (see individual changelogs) Stefan Klug (3): ipa: rkisp1: Add debug log for the sensor controls being set ipa: libipa: agc_mean_luminance: Error out when effectiveExposureValue is zero ipa: rksip1: Remove setControls(0) to reduce startup oscillations src/ipa/libipa/agc_mean_luminance.cpp | 12 ++++++++++++ src/ipa/rkisp1/rkisp1.cpp | 7 +++++-- 2 files changed, 17 insertions(+), 2 deletions(-)