From patchwork Mon Mar 24 17:07:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 23001 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 506F3C3213 for ; Mon, 24 Mar 2025 17:08:16 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 45F3F68951; Mon, 24 Mar 2025 18:08:15 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="gIZDFq7a"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id EC4856893F for ; Mon, 24 Mar 2025 18:08:13 +0100 (CET) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:854:5bc6:b2a7:e242]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 344C5455; Mon, 24 Mar 2025 18:06:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1742835987; bh=ekyF1p9TGbcdXbbdAvgVW2OAPFBvhiEo/w3YhNdsQEw=; h=From:To:Cc:Subject:Date:From; b=gIZDFq7ajAQJFNPKbO8lH/CnFyNVD4HkZhiDYEDr14dVVdCPYqWKfXw0/lA5ceBJY YQSjvFU68n8fQMbvzjH2ACnL1Fi3zJggVE2xKtB2ARYqCbUGP8u0fM+M8IBMT2Flkw 7mJuN1iO27KbMyQPYVDDby4WG0JQR8mJ4OZ548jg= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH 0/5] Fix histogram for some (corner) cases Date: Mon, 24 Mar 2025 18:07:35 +0100 Message-ID: <20250324170803.103296-1-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi all, during my work on WDR I stumbled over a few non-linearities when dealing with small inter quantile mean ranges. These led to hard to handle oscillations. This series adds a testcase for the histogram class and fixes the related issues. Patch 1 adds the basic tests that pass with the current implementation. Patch 2-3 fix issues in the quantile() implementation and add corresponding tests. Patch 4-5 fix issues in the interQuantileMean() implementation and also add tests. I added the tests after the fixes, so that I don't have to toggle should_fail in the meson.build file all the time (And CI doesn't test every commit anyways). To test that in review, I believe the easiest is to temporarily revert the corresponding fix and see the test fail. Best regards, Stefan Stefan Klug (5): test: ipa: libipa: Add histogram tests libipa: histogram: Fix quantile() calculation for fractional results test: ipa: libipa: histogram: Add tests for quantile() returning a fraction libipa: histogram: Fix interQuantileMean() for small ranges test: ipa: libipa: histogram: Add tests for small inter quantile mean ranges src/ipa/libipa/histogram.cpp | 23 ++++++------ test/ipa/libipa/histogram.cpp | 66 +++++++++++++++++++++++++++++++++++ test/ipa/libipa/meson.build | 1 + 3 files changed, 80 insertions(+), 10 deletions(-) create mode 100644 test/ipa/libipa/histogram.cpp