From patchwork Wed Mar 5 13:52:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislaw Gruszka X-Patchwork-Id: 22925 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 12080C3257 for ; Wed, 5 Mar 2025 13:53:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0C00B687DD; Wed, 5 Mar 2025 14:53:06 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="U4UB3Ybb"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7CCB768778 for ; Wed, 5 Mar 2025 14:53:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741182784; x=1772718784; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=4pa1IhaOjmOYqbs0LTNGWq43gGCOXFxtGjjmouq3dZs=; b=U4UB3YbbEmOlA8/7Yk8/YrogNiuRtNMGEJKD069Kj9e61qsQ0kqyTlZj Yu5bD3WwrUOOEbmSczHjgPnihQhk8kvv8G93EHIwCWfxbb462qMdPJpDl rRGeRdXsfRLeUs0IfIN6U8W/SVe2Acgbn2Z1nluxuzYuWP+WELveiYS0c qpsi9uXIdjfmQpb4rsjG4qjAqNaHaz378kW4L0Q/yBJUpgT1pFop/ye5O RpRO4iBVoWN9wBz4WknWXNKvnATxgNGJzmYfQ6CmiGwY8qZYyQ9SqFrPz 5Lqk4UFcLlDpMHSnfK3r2LiuEJigr1dQptAJgYrXRS9dzxp9C/oUy2+LU A==; X-CSE-ConnectionGUID: DVAxU1MyRcWjuzFrlUrogA== X-CSE-MsgGUID: eH5QcYFeQUm0yt6jUoNqmw== X-IronPort-AV: E=McAfee;i="6700,10204,11363"; a="53134750" X-IronPort-AV: E=Sophos;i="6.14,223,1736841600"; d="scan'208";a="53134750" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2025 05:53:02 -0800 X-CSE-ConnectionGUID: 5CnPP4iDRWyfXRDmg4qgxQ== X-CSE-MsgGUID: vIql2V4eTbW+kPg/iwVyPw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,223,1736841600"; d="scan'208";a="123735754" Received: from sgruszka-mobl.ger.corp.intel.com (HELO localhost) ([10.245.112.97]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2025 05:52:59 -0800 From: Stanislaw Gruszka To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Laurent Pinchart , Kieran Bingham , Naushir Patuck , Sakari Ailus , Hans de Goede Subject: [PATCH v6 0/5] libcamera: start frame events changes Date: Wed, 5 Mar 2025 14:52:51 +0100 Message-Id: <20250305135256.801351-1-stanislaw.gruszka@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" v5 -> v6: - remove changelog paragraph not applicable any longer in patch1 - use new clang-format formatting in patch1 - split patches differently - use Laurent changelog wording - add various comments in the code - use '' in log when printing emitter name v4 -> v5: - split patch2 into 3 separte patches - drop frameStartEnabled(), return error from start - use for (const Entity &entity : entities_) insted of iterator - reset delayed controls before enabling events v3 -> v4: - constify frameStartEnabled() - make supportsFrameStartEvent() more readable - rename eventEmitter to startFrameEmitter - update patch2 changelog to make it more clear v2 -> v3: - add helpers for v4l2_device - initialize eventEmitter_ in init(), when no proper device is found use nullptr (this fix crash seen by Kieran as eventEmitetter was not nullptr in v2) v1 -> v2: - make eventEmitter_ subdevice part of SimpleCameraData - add debug log when found event emitter device - nullify eventEmitter_ on stop - remove direct sensor_->setControls() - add delayedCtrls_->reset() on start Laurent Pinchart (1): pipeline: simple: Create DelayedControls instance once only Stanislaw Gruszka (4): libcamera: v4l2_device: add frame start event helpers pipeline: simple: Connect/disconnect frameStart signal at start/stop time pipeline: simple: Enable frame start events pipeline: simple: Reset delayedCtrls at start. include/libcamera/internal/v4l2_device.h | 1 + src/libcamera/pipeline/simple/simple.cpp | 66 +++++++++++++++++++----- src/libcamera/v4l2_device.cpp | 18 +++++++ 3 files changed, 72 insertions(+), 13 deletions(-) --- 2.43.0