From patchwork Fri Feb 28 12:55:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 22896 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1CF2DC3259 for ; Fri, 28 Feb 2025 12:56:09 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E7E6B68775; Fri, 28 Feb 2025 13:56:07 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="dbm3rzXU"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D81D161853 for ; Fri, 28 Feb 2025 13:56:05 +0100 (CET) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:a7e:b81b:5754:579]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 74A34606; Fri, 28 Feb 2025 13:54:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1740747276; bh=jWn9X9awEk1Fp1gGtAHf2JFzduoGI/fYlwvNx4EtB+o=; h=From:To:Cc:Subject:Date:From; b=dbm3rzXUvYaSQfKmG9l1SUQ1FTEZ8gpL2ay4J3Tj0ACD7hyQLqeVDbO06wcelL8p1 qq1aBl0YmaveNPwrePWGST6BfBaV4laxf+vrh+NZo4ZTyDYD4rPcJTMVGHnz/oKVYO 72NdAUk3C2xHhX/LjDAhXhuYlrndhFbAdow8CgyA= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH 0/3] rkisp1: Reduce oscillations on startup Date: Fri, 28 Feb 2025 13:55:52 +0100 Message-ID: <20250228125600.3241397-1-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi all, This tiny series further reduces startup AE oscillations on rkisp1. While analyzing the issue it got clear that the regulation had to cope with images that had an exposure value of 0 which should not happen in first place. Patch 1 adds a log message that could help debug such ill behavior. Patch 2 add error handling for the exposurevalue == 0 case. Patch 3 fixes it for rkisp1. Please see the individual patches for the technical details. Best regards, Stefan Stefan Klug (3): ipa: rkisp1: Add debug log for the sensor controls being set ipa: libipa: agc_mean_luminance: Error out when effectiveExposureValue is zero ipa: rksip1: Remove setControls(0) to reduce startup oscillations src/ipa/libipa/agc_mean_luminance.cpp | 7 +++++++ src/ipa/rkisp1/rkisp1.cpp | 7 +++++-- 2 files changed, 12 insertions(+), 2 deletions(-)